From deacb2853e429296b1603d949b8b5006c1821ef6 Mon Sep 17 00:00:00 2001
From: Ondrej Samohel <ondrej.samohel@ynput.io>
Date: Fri, 20 Jun 2025 16:13:07 +0200
Subject: [PATCH] :recycle: refactor filtering and add some tests

---
 client/ayon_core/pipeline/load/plugins.py     | 20 +++--
 .../ayon_core/pipeline/load/test_loaders.py   | 88 +++++++++++++++++++
 2 files changed, 103 insertions(+), 5 deletions(-)
 create mode 100644 tests/client/ayon_core/pipeline/load/test_loaders.py

diff --git a/client/ayon_core/pipeline/load/plugins.py b/client/ayon_core/pipeline/load/plugins.py
index 39343b76c6..5725133432 100644
--- a/client/ayon_core/pipeline/load/plugins.py
+++ b/client/ayon_core/pipeline/load/plugins.py
@@ -129,6 +129,10 @@ class LoaderPlugin(list):
         plugin_repre_names = cls.get_representations()
         plugin_product_types = cls.product_types
         plugin_product_base_types = cls.product_base_types
+        # If product type isn't defined on the loader plugin,
+        # then we will use the product types.
+        plugin_product_filter = (
+                plugin_product_base_types or plugin_product_types)
         repre_entity = context.get("representation")
         product_entity = context["product"]
 
@@ -136,8 +140,8 @@ class LoaderPlugin(list):
         # then loader is not compatible with any context.
         if (
             not plugin_repre_names
-            or (not plugin_product_types and not plugin_product_base_types)
-            or not cls.extensions
+            and not plugin_product_filter
+            and not cls.extensions
         ):
             return False
 
@@ -148,7 +152,7 @@ class LoaderPlugin(list):
 
         # Check the compatibility with the representation names.
         plugin_repre_names = set(plugin_repre_names)
-        if not plugin_repre_names or (
+        if (
             "*" not in plugin_repre_names
             and repre_entity["name"] not in plugin_repre_names
         ):
@@ -169,8 +173,6 @@ class LoaderPlugin(list):
         if product_filter is None:
             product_filter = product_type
 
-        # If no product type isn't defined on the loader plugin,
-        # then we will use the product types.
         plugin_product_filter = (
                 plugin_product_base_types or plugin_product_types)
 
@@ -179,6 +181,14 @@ class LoaderPlugin(list):
         if "*" in plugin_product_filter:
             return True
 
+        # compatibility with legacy loader
+        if cls.product_base_types is None and product_base_type:
+            cls.log.error(
+                f"Loader {cls.__name__} is doesn't specify "
+                "`product_base_types` but product entity has "
+                f"`productBaseType` defined as `{product_base_type}`. "
+            )
+
         return product_filter in plugin_product_filter
 
     @classmethod
diff --git a/tests/client/ayon_core/pipeline/load/test_loaders.py b/tests/client/ayon_core/pipeline/load/test_loaders.py
new file mode 100644
index 0000000000..490efe1b1e
--- /dev/null
+++ b/tests/client/ayon_core/pipeline/load/test_loaders.py
@@ -0,0 +1,88 @@
+"""Test loaders in the pipeline module."""
+
+from ayon_core.pipeline.load import LoaderPlugin
+
+
+def test_is_compatible_loader():
+    """Test if a loader is compatible with a given representation."""
+    from ayon_core.pipeline.load import is_compatible_loader
+
+    # Create a mock representation context
+    context = {
+        "loader": "test_loader",
+        "representation": {"name": "test_representation"},
+    }
+
+    # Create a mock loader plugin
+    class MockLoader(LoaderPlugin):
+        name = "test_loader"
+        version = "1.0.0"
+
+        def is_compatible_loader(self, context):
+            return True
+
+    # Check compatibility
+    assert is_compatible_loader(MockLoader(), context) is True
+
+
+def test_complex_is_compatible_loader():
+    """Test if a loader is compatible with a complex representation."""
+    from ayon_core.pipeline.load import is_compatible_loader
+
+    # Create a mock complex representation context
+    context = {
+        "loader": "complex_loader",
+        "representation": {
+            "name": "complex_representation",
+            "extension": "exr"
+        },
+        "additional_data": {"key": "value"},
+        "product": {
+            "name": "complex_product",
+            "productType": "foo",
+            "productBaseType": "bar",
+        },
+    }
+
+    # Create a mock loader plugin
+    class ComplexLoaderA(LoaderPlugin):
+        name = "complex_loaderA"
+
+    # False because the loader doesn't specify any compatibility (missing
+    # wildcard for product type and product base type)
+    assert is_compatible_loader(ComplexLoaderA(), context) is False
+
+    class ComplexLoaderB(LoaderPlugin):
+        name = "complex_loaderB"
+        product_types = {"*"}
+        representations = {"*"}
+
+    # True, it is compatible with any product type
+    assert is_compatible_loader(ComplexLoaderB(), context) is True
+
+    class ComplexLoaderC(LoaderPlugin):
+        name = "complex_loaderC"
+        product_base_types = {"*"}
+        representations = {"*"}
+
+    # True, it is compatible with any product base type
+    assert is_compatible_loader(ComplexLoaderC(), context) is True
+
+    class ComplexLoaderD(LoaderPlugin):
+        name = "complex_loaderD"
+        product_types = {"foo"}
+        representations = {"*"}
+
+    # legacy loader defining compatibility only with product type
+    # is compatible provided the same product type is defined in context
+    assert is_compatible_loader(ComplexLoaderD(), context) is False
+
+    class ComplexLoaderE(LoaderPlugin):
+        name = "complex_loaderE"
+        product_types = {"foo"}
+        representations = {"*"}
+
+    # remove productBaseType from context to simulate legacy behavior
+    context["product"].pop("productBaseType", None)
+
+    assert is_compatible_loader(ComplexLoaderE(), context) is True