From aad896f1f457ded905c32e135c746a36778d670d Mon Sep 17 00:00:00 2001 From: Roy Nieterau Date: Fri, 24 Aug 2018 17:06:13 +0200 Subject: [PATCH 1/4] Remove verbosity - since non-verbose output was way too confusing for artists as it didn't show the causing conflicts --- .../plugins/maya/publish/validate_transfers.py | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/colorbleed/plugins/maya/publish/validate_transfers.py b/colorbleed/plugins/maya/publish/validate_transfers.py index 41544b63cf..d1ea7d362e 100644 --- a/colorbleed/plugins/maya/publish/validate_transfers.py +++ b/colorbleed/plugins/maya/publish/validate_transfers.py @@ -22,8 +22,6 @@ class ValidateTransfers(pyblish.api.InstancePlugin): if not transfers: return - verbose = instance.data.get('verbose', False) - # Collect all destination with its sources collected = defaultdict(set) for source, destination in transfers: @@ -39,16 +37,9 @@ class ValidateTransfers(pyblish.api.InstancePlugin): if len(sources) > 1: invalid_destinations.append(destination) - if verbose: - self.log.error("Non-unique file transfer for resources: " - "{0} (sources: {1})".format(destination, - sources)) + self.log.error("Non-unique file transfer for resources: " + "{0} (sources: {1})".format(destination, + list(sources))) if invalid_destinations: - if not verbose: - # If not verbose then still log the resource destination as - # opposed to every individual file transfer - self.log.error("Non-unique file transfers to destinations: " - "%s" % "\n".join(invalid_destinations)) - raise RuntimeError("Invalid transfers in queue.") From 4108c680aa20ae3949446d14041bf45a045062f5 Mon Sep 17 00:00:00 2001 From: Roy Nieterau Date: Thu, 6 Sep 2018 09:52:56 +0200 Subject: [PATCH 2/4] Fix `extract_alembic` not supporting writeUVSets --- colorbleed/maya/lib.py | 1 + 1 file changed, 1 insertion(+) diff --git a/colorbleed/maya/lib.py b/colorbleed/maya/lib.py index bb2690e3f8..5b247d88a0 100644 --- a/colorbleed/maya/lib.py +++ b/colorbleed/maya/lib.py @@ -76,6 +76,7 @@ _alembic_options = { "writeColorSets": bool, "writeFaceSets": bool, "writeCreases": bool, # Maya 2015 Ext1+ + "writeUVSets": bool, # Maya 2017+ "dataFormat": str, "root": (list, tuple), "attr": (list, tuple), From 8b02cce5b1ff2e9a655fdb40d77c56bcf02909a6 Mon Sep 17 00:00:00 2001 From: Roy Nieterau Date: Thu, 6 Sep 2018 10:36:33 +0200 Subject: [PATCH 3/4] Correct message, and remove verbose nodes logging --- colorbleed/plugins/maya/publish/extract_pointcache.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/colorbleed/plugins/maya/publish/extract_pointcache.py b/colorbleed/plugins/maya/publish/extract_pointcache.py index 405d1e6549..4cfb8c9c25 100644 --- a/colorbleed/plugins/maya/publish/extract_pointcache.py +++ b/colorbleed/plugins/maya/publish/extract_pointcache.py @@ -35,11 +35,9 @@ class ExtractColorbleedAlembic(colorbleed.api.Extractor): # Get extra export arguments writeColorSets = instance.data.get("writeColorSets", False) - self.log.info("Extracting animation..") + self.log.info("Extracting pointcache..") dirname = self.staging_dir(instance) - self.log.info("nodes: %s" % str(nodes)) - parent_dir = self.staging_dir(instance) filename = "{name}.abc".format(**instance.data) path = os.path.join(parent_dir, filename) From 4d224517e4c7d4cc2ad781d864146d5e4213b5a9 Mon Sep 17 00:00:00 2001 From: Roy Nieterau Date: Thu, 6 Sep 2018 10:57:11 +0200 Subject: [PATCH 4/4] Log a warning when option key is being ignored --- colorbleed/maya/lib.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/colorbleed/maya/lib.py b/colorbleed/maya/lib.py index 5b247d88a0..bb41b4a738 100644 --- a/colorbleed/maya/lib.py +++ b/colorbleed/maya/lib.py @@ -608,6 +608,8 @@ def extract_alembic(file, # Discard unknown options if key not in _alembic_options: + log.warning("extract_alembic() does not support option '%s'. " + "Flag will be ignored..", key) options.pop(key) continue