From e33c06f95e58db53eb27edbfb85909e6643679dd Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Fri, 27 May 2022 17:26:30 +0200
Subject: [PATCH] Nuke: abstracting function for correct knob type value

---
 openpype/hosts/nuke/api/__init__.py |  4 ++-
 openpype/hosts/nuke/api/lib.py      | 43 +++++++++++++++++------------
 2 files changed, 28 insertions(+), 19 deletions(-)

diff --git a/openpype/hosts/nuke/api/__init__.py b/openpype/hosts/nuke/api/__init__.py
index b571c4098c..f7288bb287 100644
--- a/openpype/hosts/nuke/api/__init__.py
+++ b/openpype/hosts/nuke/api/__init__.py
@@ -26,7 +26,8 @@ from .pipeline import (
     update_container,
 )
 from .lib import (
-    maintained_selection
+    maintained_selection,
+    convert_knob_value_to_correct_type
 )
 
 from .utils import (
@@ -58,6 +59,7 @@ __all__ = (
     "update_container",
 
     "maintained_selection",
+    "convert_knob_value_to_correct_type",
 
     "colorspace_exists_on_node",
     "get_colorspace_list"
diff --git a/openpype/hosts/nuke/api/lib.py b/openpype/hosts/nuke/api/lib.py
index ba8aa7a8db..457e5d851f 100644
--- a/openpype/hosts/nuke/api/lib.py
+++ b/openpype/hosts/nuke/api/lib.py
@@ -1528,28 +1528,35 @@ def set_node_knobs_from_settings(node, knob_settings, **kwargs):
         if not knob_value:
             continue
 
-        # first convert string types to string
-        # just to ditch unicode
-        if isinstance(knob_value, six.text_type):
-            knob_value = str(knob_value)
-
-        # set correctly knob types
-        if knob_type == "bool":
-            knob_value = bool(knob_value)
-        elif knob_type == "decimal_number":
-            knob_value = float(knob_value)
-        elif knob_type == "number":
-            knob_value = int(knob_value)
-        elif knob_type == "text":
-            knob_value = knob_value
-        elif knob_type == "color_gui":
-            knob_value = color_gui_to_int(knob_value)
-        elif knob_type in ["2d_vector", "3d_vector", "color"]:
-            knob_value = [float(v) for v in knob_value]
+        knob_value = convert_knob_value_to_correct_type(
+            knob_type, knob_value)
 
         node[knob_name].setValue(knob_value)
 
 
+def convert_knob_value_to_correct_type(knob_type, knob_value):
+    # first convert string types to string
+    # just to ditch unicode
+    if isinstance(knob_value, six.text_type):
+        knob_value = str(knob_value)
+
+    # set correctly knob types
+    if knob_type == "bool":
+        knob_value = bool(knob_value)
+    elif knob_type == "decimal_number":
+        knob_value = float(knob_value)
+    elif knob_type == "number":
+        knob_value = int(knob_value)
+    elif knob_type == "text":
+        knob_value = knob_value
+    elif knob_type == "color_gui":
+        knob_value = color_gui_to_int(knob_value)
+    elif knob_type in ["2d_vector", "3d_vector", "color"]:
+        knob_value = [float(v) for v in knob_value]
+
+    return knob_value
+
+
 def color_gui_to_int(color_gui):
     hex_value = (
         "0x{0:0>2x}{1:0>2x}{2:0>2x}{3:0>2x}").format(*color_gui)