From e4881e2fec7599863e311fd9124db89bc35fd2b8 Mon Sep 17 00:00:00 2001
From: MustafaJafar <mustafataherzaky@outlook.com>
Date: Thu, 5 Sep 2024 22:04:55 +0300
Subject: [PATCH] refactor and simplify `build_template` method

---
 .../workfile/workfile_template_builder.py     | 29 ++++++-------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/client/ayon_core/pipeline/workfile/workfile_template_builder.py b/client/ayon_core/pipeline/workfile/workfile_template_builder.py
index 1fce07a722..283408452e 100644
--- a/client/ayon_core/pipeline/workfile/workfile_template_builder.py
+++ b/client/ayon_core/pipeline/workfile/workfile_template_builder.py
@@ -512,39 +512,28 @@ class AbstractTemplateBuilder(ABC):
                                               process if version is created
 
         """
-        if any(
-            value is None
-            for value in [
-                template_path,
-                keep_placeholders,
-                create_first_version,
-            ]
-        ):
-            template_preset = self.get_template_preset()
-            if template_path is None:
-                template_path = template_preset["path"]
+        # Get default values if not provided
+        if template_path is None or keep_placeholders is None or create_first_version is None:
+            preset = self.get_template_preset()
+            template_path = template_path or preset["path"]
             if keep_placeholders is None:
-                keep_placeholders = template_preset["keep_placeholder"]
+                keep_placeholders = preset["keep_placeholder"]
             if create_first_version is None:
-                create_first_version = template_preset["create_first_version"]
+                create_first_version = preset["create_first_version"]
 
         # check if first version is created
-        created_version_workfile = False
-        if create_first_version:
-            created_version_workfile = self.create_first_workfile_version()
+        created_version_workfile = create_first_version and self.create_first_workfile_version()
 
         # Build the template
         if (
-            create_first_version
-            and workfile_creation_enabled
-            and (created_version_workfile or self.host.get_current_workfile() is None)
+            not self.host.get_current_workfile() or created_version_workfile
         ):
             self.import_template(template_path)
             self.populate_scene_placeholders(
                 level_limit, keep_placeholders)
 
         # save workfile if a workfile was created.
-        if created_version_workfile:
+        if workfile_creation_enabled and created_version_workfile:
             self.save_workfile(created_version_workfile)
 
     def rebuild_template(self):