Merge pull request #5587 from BigRoy/chore/loader_deprecate_fname_attribute

Chore: Loader log deprecation warning for 'fname' attribute

openpype/hosts/blender/plugins/load/load_blend.py

@@ -119,7 +119,7 @@ class BlendLoader(plugin.AssetLoader):
             context: Full parenthood of representation to load
             options: Additional settings dictionary
         """
-        libpath = self.fname
+        libpath = self.filepath_from_context(context)
         asset = context["asset"]["name"]
         subset = context["subset"]["name"]
 

openpype/pipeline/load/plugins.py

@@ -234,6 +234,19 @@ class LoaderPlugin(list):
         """
         return cls.options or []
 
+    @property
+    def fname(self):
+        """Backwards compatibility with deprecation warning"""
+
+        self.log.warning((
+            "DEPRECATION WARNING: Source - Loader plugin {}."
+            " The 'fname' property on the Loader plugin will be removed in"
+            " future versions of OpenPype. Planned version to drop the support"
+            " is 3.16.6 or 3.17.0."
+        ).format(self.__class__.__name__))
+        if hasattr(self, "_fname"):
+            return self._fname
+
 
 class SubsetLoaderPlugin(LoaderPlugin):
     """Load subset into host application

openpype/pipeline/load/utils.py

@@ -318,7 +318,8 @@ def load_with_repre_context(
 
     # Backwards compatibility: Originally the loader's __init__ required the
     # representation context to set `fname` attribute to the filename to load
-    loader.fname = get_representation_path_from_context(repre_context)
+    # Deprecated - to be removed in OpenPype 3.16.6 or 3.17.0.
+    loader._fname = get_representation_path_from_context(repre_context)
 
     return loader.load(repre_context, name, namespace, options)