Merged in tokejepsen/pype/feature/extract_review_better_logging (pull request #224)

Log output from ffmpeg process.
This commit is contained in:
Toke Jepsen 2019-07-25 11:19:47 +00:00 committed by Jakub Jezek
commit e8dfd87af4

View file

@ -136,12 +136,21 @@ class ExtractReview(pyblish.api.InstancePlugin):
# run subprocess # run subprocess
self.log.debug("{}".format(subprcs_cmd)) self.log.debug("{}".format(subprcs_cmd))
sub_proc = subprocess.Popen(subprcs_cmd) sub_proc = subprocess.Popen(
sub_proc.wait() subprcs_cmd,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
stdin=subprocess.PIPE,
cwd=os.path.dirname(output_args[-1])
)
output = sub_proc.communicate()[0]
if not os.path.isfile(full_output_path): if not os.path.isfile(full_output_path):
raise FileExistsError( raise ValueError(
"Quicktime wasn't created succesfully") "Quicktime wasn't created succesfully: "
"{}".format(output)
)
# create representation data # create representation data
repre_new.update({ repre_new.update({