addressing PR comments

This commit is contained in:
Jakub Jezek 2022-02-10 12:58:50 +01:00
parent 255bf9e6ea
commit e9b7501a17
No known key found for this signature in database
GPG key ID: D8548FBF690B100A
3 changed files with 8 additions and 20 deletions

View file

@ -6,7 +6,6 @@ import contextlib
from avalon import api as avalon
from avalon.pipeline import AVALON_CONTAINER_ID
from pyblish import api as pyblish
from collections import OrderedDict
from openpype.api import Logger
from .lib import (
set_segment_data_marker,
@ -77,18 +76,18 @@ def containerise(flame_clip,
loader=None,
data=None):
data_imprint = OrderedDict({
data_imprint = {
"schema": "openpype:container-2.0",
"id": AVALON_CONTAINER_ID,
"name": str(name),
"namespace": str(namespace),
"loader": str(loader),
"representation": str(context["representation"]["_id"]),
})
}
if data:
for k, v in data.items():
data_imprint.update({k: v})
data_imprint[k] = v
log.debug("_ data_imprint: {}".format(data_imprint))

View file

@ -4,7 +4,6 @@ import shutil
import sys
from avalon.vendor import qargparse
from xml.etree import ElementTree as ET
import shutil
import six
from Qt import QtWidgets, QtCore
import openpype.api as openpype
@ -680,16 +679,6 @@ class ClipLoader(avalon.Loader):
):
pass
def update(self, container, representation):
"""Update an existing `container`
"""
pass
def remove(self, container):
"""Remove an existing `container`
"""
pass
class OpenClipSolver:
media_script_path = "/opt/Autodesk/mio/current/dl_get_media_info"
@ -734,7 +723,7 @@ class OpenClipSolver:
self.log.info("Temp File: {}".format(self.tmp_file))
def make(self):
self._get_media_info_args()
self._generate_media_info_file()
if self.create_new_clip:
# New openClip
@ -747,7 +736,7 @@ class OpenClipSolver:
raise IOError("Media Scirpt does not exist: `{}`".format(
self.media_script_path))
def _get_media_info_args(self):
def _generate_media_info_file(self):
# Create cmd arguments for gettig xml file info file
cmd_args = [
self.media_script_path,

View file

@ -4,9 +4,9 @@ import os
import sys
try:
import six
except ImportError:
raise ImportError("Cannot import this module")
import six # noqa
except ImportError as msg:
raise ImportError("Cannot import this module: {}".format(msg)) from msg
SCRIPT_DIR = os.path.dirname(__file__)
PACKAGE_DIR = os.path.join(SCRIPT_DIR, "modules")