add validators and change to take the frame range from the render setting

openpype/hosts/max/api/lib.py

@@ -150,10 +150,10 @@ def set_framerange(start_frame, end_frame):
     Todo:
         Current type is hard-coded, there should be a custom setting for this.
     """
-    rt.rendTimeType = 4
+    rt.rendTimeType = 3
     if start_frame is not None and end_frame is not None:
-        frame_range = "{0}-{1}".format(start_frame, end_frame)
-        rt.rendPickupFrames = frame_range
+        rt.rendStart = int(start_frame)
+        rt.rendEnd = int(end_frame)
 
 
 def get_multipass_setting(project_setting=None):
@@ -243,6 +243,7 @@ def reset_frame_range(fps: bool = True):
     frame_end = frame_range["frameEnd"] + int(frame_range["handleEnd"])
     frange_cmd = f"animationRange = interval {frame_start} {frame_end}"
     rt.execute(frange_cmd)
+    set_framerange(frame_start, frame_end)
 
 
 def set_context_setting():
@@ -259,6 +260,7 @@ def set_context_setting():
         None
     """
     reset_scene_resolution()
+    reset_frame_range()
 
 
 def get_max_version():

openpype/hosts/max/api/lib_renderproducts.py

@@ -36,8 +36,9 @@ class RenderProducts(object):
                                    container)
 
         context = get_current_project_asset()
-        startFrame = context["data"].get("frameStart")
-        endFrame = context["data"].get("frameEnd") + 1
+        # TODO: change the frame range follows the current render setting
+        startFrame = int(rt.rendStart)
+        endFrame = int(rt.rendEnd) + 1
 
         img_fmt = self._project_settings["max"]["RenderSettings"]["image_format"]   # noqa
         full_render_list = self.beauty_render_product(output_file,

openpype/hosts/max/plugins/publish/collect_render.py

@@ -59,8 +59,8 @@ class CollectRender(pyblish.api.InstancePlugin):
             "source": filepath,
             "expectedFiles": render_layer_files,
             "plugin": "3dsmax",
-            "frameStart": context.data['frameStart'],
-            "frameEnd": context.data['frameEnd'],
+            "frameStart": int(rt.rendStart),
+            "frameEnd": int(rt.rendEnd),
             "version": version_int,
             "farm": True
         }

openpype/hosts/max/plugins/publish/validate_frame_range.py

@@ -0,0 +1,61 @@
+import pyblish.api
+
+from pymxs import runtime as rt
+from openpype.pipeline import (
+    OptionalPyblishPluginMixin
+)
+from openpype.pipeline.publish import (
+    RepairAction,
+    ValidateContentsOrder,
+    PublishValidationError
+)
+
+
+class ValidateFrameRange(pyblish.api.InstancePlugin,
+                         OptionalPyblishPluginMixin):
+    """Validates the frame ranges.
+
+    This is an optional validator checking if the frame range on instance
+    matches the frame range specified for the asset.
+
+    It also validates render frame ranges of render layers.
+
+    Repair action will change everything to match the asset frame range.
+
+    This can be turned off by the artist to allow custom ranges.
+    """
+
+    label = "Validate Frame Range"
+    order = ValidateContentsOrder
+    families = ["maxrender"]
+    hosts = ["max"]
+    optional = True
+    actions = [RepairAction]
+
+    def process(self, instance):
+        if not self.is_active(instance.data):
+            self.log.info("Skipping validation...")
+            return
+        context = instance.context
+
+        frame_start = int(context.data.get("frameStart"))
+        frame_end = int(context.data.get("frameEnd"))
+
+        inst_frame_start = int(instance.data.get("frameStart"))
+        inst_frame_end = int(instance.data.get("frameEnd"))
+
+
+        if frame_start != inst_frame_start:
+            raise PublishValidationError(
+                "startFrame on instance does not match"
+                " with startFrame from the context data")
+
+        if frame_end != inst_frame_end:
+            raise PublishValidationError(
+                "endFrame on instance does not match"
+                " with endFrame from the context data")
+
+    @classmethod
+    def repair(cls, instance):
+        rt.rendStart = instance.context.data.get("frameStart")
+        rt.rendEnd = instance.context.data.get("frameEnd")

openpype/hosts/max/plugins/publish/validate_frame_range_type.py

@@ -0,0 +1,32 @@
+import pyblish.api
+
+from pymxs import runtime as rt
+from openpype.pipeline.publish import (
+    RepairAction,
+    ValidateContentsOrder,
+    PublishValidationError
+)
+
+
+class ValidateFrameRangeType(pyblish.api.InstancePlugin):
+    """
+    Validates whether the User
+    specified Frame Range(Type 3) is used in render setting
+
+    """
+
+    label = "Validate Render Frame Range Type"
+    order = ValidateContentsOrder
+    families = ["maxrender"]
+    hosts = ["max"]
+    actions = [RepairAction]
+
+    def process(self, instance):
+        if rt.rendTimeType != 3:
+            raise PublishValidationError("Incorrect type of frame range"
+                                         " used in render setting..")
+
+    @classmethod
+    def repair(cls, instance):
+        rt.renderTimeType = 3
+        return instance