plural form for extract_review_intermediate

This commit is contained in:
Kayla Man 2023-09-28 20:27:55 +08:00
parent 6c1e066b3b
commit ef12a5229d
7 changed files with 14 additions and 14 deletions

View file

@ -8,7 +8,7 @@ from openpype.hosts.nuke.api import plugin
from openpype.hosts.nuke.api.lib import maintained_selection
class ExtractReviewIntermediate(publish.Extractor):
class ExtractReviewIntermediates(publish.Extractor):
"""Extracts Sequences and thumbnail with baked in luts
must be run after extract_render_local.py
@ -32,7 +32,7 @@ class ExtractReviewIntermediate(publish.Extractor):
"""
nuke_publish = project_settings["nuke"]["publish"]
deprecated_setting = nuke_publish["ExtractReviewDataMov"]
current_setting = nuke_publish["ExtractReviewIntermediate"]
current_setting = nuke_publish["ExtractReviewIntermediates"]
if deprecated_setting["enabled"]:
# Use deprecated settings if they are still enabled
cls.viewer_lut_raw = deprecated_setting["viewer_lut_raw"]

View file

@ -753,7 +753,7 @@ def _convert_nuke_project_settings(ayon_settings, output):
# settings for backwards compatibility
deprecrated_review_settings = ayon_publish["ExtractReviewDataMov"]
current_review_settings = (
ayon_publish["ExtractReviewIntermediate"]
ayon_publish["ExtractReviewIntermediates"]
)
if deprecrated_review_settings["enabled"]:
outputs_settings = deprecrated_review_settings["outputs"]

View file

@ -501,7 +501,7 @@
}
}
},
"ExtractReviewIntermediate": {
"ExtractReviewIntermediates": {
"enabled": true,
"viewer_lut_raw": false,
"outputs": {

View file

@ -373,14 +373,14 @@
},
{
"type": "label",
"label": "^ Settings and for <span style=\"color:#FF0000\";><b>ExtractReviewDataMov</b></span> is deprecated and will be soon removed. <br> Please use <b>ExtractReviewIntermediate</b> instead."
"label": "^ Settings and for <span style=\"color:#FF0000\";><b>ExtractReviewDataMov</b></span> is deprecated and will be soon removed. <br> Please use <b>ExtractReviewIntermediates</b> instead."
},
{
"type": "dict",
"collapsible": true,
"checkbox_key": "enabled",
"key": "ExtractReviewIntermediate",
"label": "ExtractReviewIntermediate",
"key": "ExtractReviewIntermediates",
"label": "ExtractReviewIntermediates",
"is_group": true,
"children": [
{

View file

@ -177,7 +177,7 @@ class ExtractReviewDataMovModel(BaseSettingsModel):
)
class ExtractReviewBakingStreamsModel(BaseSettingsModel):
class ExtractReviewIntermediatesModel(BaseSettingsModel):
enabled: bool = Field(title="Enabled")
viewer_lut_raw: bool = Field(title="Viewer lut raw")
outputs: list[BakingStreamModel] = Field(
@ -282,9 +282,9 @@ class PublishPuginsModel(BaseSettingsModel):
title="Extract Review Data Mov",
default_factory=ExtractReviewDataMovModel
)
ExtractReviewIntermediate: ExtractReviewBakingStreamsModel = Field(
title="Extract Review Data Baking Streams",
default_factory=ExtractReviewBakingStreamsModel
ExtractReviewIntermediates: ExtractReviewIntermediatesModel = Field(
title="Extract Review Intermediates",
default_factory=ExtractReviewIntermediatesModel
)
ExtractSlateFrame: ExtractSlateFrameModel = Field(
title="Extract Slate Frame",
@ -481,7 +481,7 @@ DEFAULT_PUBLISH_PLUGIN_SETTINGS = {
}
]
},
"ExtractReviewIntermediate": {
"ExtractReviewIntermediates": {
"enabled": True,
"viewer_lut_raw": False,
"outputs": [

View file

@ -189,7 +189,7 @@ A profile may generate multiple outputs from a single input. Each output must de
- Profile filtering defines which group of output definitions is used but output definitions may require more specific filters on their own.
- They may filter by subset name (regex can be used) or publish families. Publish families are more complex as are based on knowing code base.
- Filtering by custom tags -> this is used for targeting to output definitions from other extractors using settings (at this moment only Nuke bake extractor can target using custom tags).
- Nuke extractor settings path: `project_settings/nuke/publish/ExtractReviewIntermediate/outputs/baking/add_custom_tags`
- Nuke extractor settings path: `project_settings/nuke/publish/ExtractReviewIntermediates/outputs/baking/add_custom_tags`
- Filtering by input length. Input may be video, sequence or single image. It is possible that `.mp4` should be created only when input is video or sequence and to create review `.png` when input is single frame. In some cases the output should be created even if it's single frame or multi frame input.

View file

@ -534,7 +534,7 @@ Plugin responsible for generating thumbnails with colorspace controlled by Nuke.
}
```
### `ExtractReviewIntermediate`
### `ExtractReviewIntermediates`
`viewer_lut_raw` **true** will publish the baked mov file without any colorspace conversion. It will be baked with the workfile workspace. This can happen in case the Viewer input process uses baked screen space luts.
#### baking with controlled colorspace