From f19b39185d47b4666a8065bb155823dbcaefd4dd Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 4 Nov 2021 13:04:54 +0100
Subject: [PATCH] OP-1937 - fixes to stabilize sftp provider if wrong settings

---
 .../sync_server/providers/sftp.py                | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/openpype/modules/default_modules/sync_server/providers/sftp.py b/openpype/modules/default_modules/sync_server/providers/sftp.py
index 07450265e2..8549c1c981 100644
--- a/openpype/modules/default_modules/sync_server/providers/sftp.py
+++ b/openpype/modules/default_modules/sync_server/providers/sftp.py
@@ -1,8 +1,7 @@
 import os
 import os.path
 import time
-import sys
-import six
+import paramiko
 import threading
 import platform
 
@@ -37,7 +36,6 @@ class SFTPHandler(AbstractProvider):
 
     def __init__(self, project_name, site_name, tree=None, presets=None):
         self.presets = None
-        self.active = False
         self.project_name = project_name
         self.site_name = site_name
         self.root = None
@@ -64,7 +62,6 @@ class SFTPHandler(AbstractProvider):
         self.sftp_key_pass = provider_presets["sftp_key_pass"]
 
         self._tree = None
-        self.active = True
 
     @property
     def conn(self):
@@ -80,7 +77,9 @@ class SFTPHandler(AbstractProvider):
         Returns:
             (boolean)
         """
-        return self.conn is not None
+        return self.presets.get(self.CODE) and \
+            self.presets[self.CODE].get("sftp_host") and \
+            self.conn is not None
 
     @classmethod
     def get_system_settings_schema(cls):
@@ -108,7 +107,7 @@ class SFTPHandler(AbstractProvider):
         editable = [
             # credentials could be overriden on Project or User level
             {
-                'key': "sftp_server",
+                'key': "sftp_host",
                 'label': "SFTP host name",
                 'type': 'text'
             },
@@ -421,7 +420,10 @@ class SFTPHandler(AbstractProvider):
         if self.sftp_key_pass:
             conn_params['private_key_pass'] = self.sftp_key_pass
 
-        return pysftp.Connection(**conn_params)
+        try:
+            return pysftp.Connection(**conn_params)
+        except paramiko.ssh_exception.SSHException:
+            log.warning("Couldn't connect", exc_info=True)
 
     def _mark_progress(self, collection, file, representation, server, site,
                        source_path, target_path, direction):