Merge branch 'develop' into feature/OP-2637_Houdini-Farm-publishingrendering

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,33 +0,0 @@
----
-name: Bug report
-about: Create a report to help us improve
-title: ''
-labels: bug
-assignees: ''
-
----
-**Running version**
-[ex. 3.14.1-nightly.2]
-
-**Describe the bug**
-A clear and concise description of what the bug is.
-
-**To Reproduce**
-Steps to reproduce the behavior:
-1. Go to '...'
-2. Click on '....'
-3. Scroll down to '....'
-4. See error
-
-**Expected behavior**
-A clear and concise description of what you expected to happen.
-
-**Screenshots**
-If applicable, add screenshots to help explain your problem.
-
-**Desktop (please complete the following information):**
- - OS: [e.g. windows]
- - Host: [e.g. Maya, Nuke, Houdini]
-
-**Additional context**
-Add any other context about the problem here.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -0,0 +1,108 @@
+name: Bug Report
+description: File a bug report
+title: 'bug: '
+labels:
+  - 'type: bug'
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this bug report!
+  - type: checkboxes
+    attributes:
+      label: Is there an existing issue for this?
+      description: >-
+        Please search to see if an issue already exists for the bug you
+        encountered.
+      options:
+        - label: I have searched the existing issues
+          required: true
+  - type: textarea
+    attributes:
+      label: 'Current Behavior:'
+      description: A concise description of what you're experiencing.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: 'Expected Behavior:'
+      description: A concise description of what you expected to happen.
+    validations:
+      required: false
+  - type: dropdown
+    id: _version
+    attributes:
+      label: Version
+      description: What version are you running? Look to OpenPype Tray
+      options:
+        - 3.15.3
+        - 3.15.2
+        - 3.15.1
+        - 3.15.0
+        - 3.14.10
+        - 3.14.9
+        - 3.14.8
+        - 3.14.7
+        - 3.14.6
+        - 3.14.5
+        - 3.14.4
+        - 3.14.3
+        - 3.14.2
+        - 3.14.1
+        - 3.14.0
+        - 3.13.0
+        - 3.12.2
+        - 3.12.1
+        - 3.12.0
+        - 3.11.1
+        - 3.11.0
+        - 3.10.0
+        - 3.9.8
+        - 3.9.7
+        - 3.9.6
+    validations:
+      required: true
+  - type: dropdown
+    validations:
+      required: true
+    attributes:
+      label: What platform you are running OpenPype on?
+      description: |
+        Please specify the operating systems you are running OpenPype with.
+      multiple: true
+      options:
+        - Windows
+        - Linux / Centos
+        - Linux / Ubuntu
+        - Linux / RedHat
+        - MacOS
+  - type: textarea
+    id: to-reproduce
+    attributes:
+      label: 'Steps To Reproduce:'
+      description: Steps to reproduce the behavior.
+      placeholder: |
+        1. How did the configuration look like
+        2. What type of action was made
+    validations:
+      required: true
+  - type: checkboxes
+    attributes:
+      label: Is there any more labels you wish to add?
+      description: Please search labels and identify those related to your bug.
+      options:
+        - label: I have searched labels and added any
+          required: true
+  - type: textarea
+    id: logs
+    attributes:
+      label: 'Relevant log output:'
+      description: >-
+        Please copy and paste any relevant log output. This will be
+        automatically formatted into code, so no need for backticks.
+      render: shell
+  - type: textarea
+    id: additional-context
+    attributes:
+      label: 'Additional context:'
+      description: Add any other context about the problem here.

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Ynput Discord Server
+    url: https://discord.gg/ynput
+    about: For community quick chats.

.github/ISSUE_TEMPLATE/enhancement_request.yml

@@ -0,0 +1,52 @@
+name: Enhancement Request
+description: Create a report to help us enhance a particular feature
+title: "enhancement: "
+labels:
+  - "type: enhancement"
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this enhancement request report!
+  - type: checkboxes
+    attributes:
+      label: Is there an existing issue for this?
+      description: Please search to see if an issue already exists for the bug you encountered.
+      options:
+      - label: I have searched the existing issues
+        required: true
+  - type: textarea
+    id: related-feature
+    attributes:
+      label: Please state which of feature you have in mind and describe what are its shortcomings?
+      description: A clear and concise description of what the problem is.
+    validations:
+      required: true
+  - type: textarea
+    id: enhancement-proposal
+    attributes:
+      label: How would you imagine the enhancement of the feature?
+      description: A clear and concise description of what you want to happen.
+    validations:
+      required: true
+  - type: checkboxes
+    attributes:
+      label: Is there any more labels you wish to add?
+      description: Please search labels and identify those related to your enhancement.
+      options:
+      - label: I have searched labels and added any
+        required: true
+  - type: textarea
+    id: alternatives
+    attributes:
+      label: "Describe alternatives you've considered:"
+      description: A clear and concise description of any alternative solutions or features you've considered.
+    validations:
+      required: false
+  - type: textarea
+    id: additional-context
+    attributes:
+      label: "Additional context:"
+      description: Add any other context or screenshots about the enhancement request here.
+    validations:
+      required: false

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,20 +0,0 @@
----
-name: Feature request
-about: Suggest an idea for this project
-title: ''
-labels: enhancement
-assignees: ''
-
----
-
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-
-**Describe the solution you'd like**
-A clear and concise description of what you want to happen.
-
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
-
-**Additional context**
-Add any other context or screenshots about the feature request here.

.github/workflows/documentation.yml

@@ -1,4 +1,4 @@
-name: documentation
+name: 📜 Documentation
 
 on:
   pull_request:

.github/workflows/milestone_assign.yml

@@ -1,4 +1,4 @@
-name: Milestone - assign to PRs
+name: 👉🏻 Milestone - assign to PRs
 
 on:
   pull_request_target:

.github/workflows/milestone_create.yml

@@ -1,4 +1,4 @@
-name: Milestone - create default
+name: ➕ Milestone - create default
 
 on:
   milestone:

.github/workflows/miletone_release_trigger.yml

@@ -1,4 +1,4 @@
-name: Milestone Release [trigger]
+name: 🚩 Milestone Release [trigger]
 
 on:
   workflow_dispatch:

.github/workflows/nightly_merge.yml

@@ -1,4 +1,4 @@
-name: Dev -> Main
+name: 🔀 Dev -> Main
 
 on:
   schedule:

.github/workflows/pr_labels.yml

@@ -0,0 +1,49 @@
+name: 🔖 PR labels
+
+on:
+  pull_request_target:
+    types: [opened, assigned]
+
+jobs:
+  size-label:
+    name: pr_size_label
+    runs-on: ubuntu-latest
+    if: github.event.action == 'assigned' || github.event.action == 'opened'
+    steps:
+      - name: Add size label
+        uses: "pascalgn/size-label-action@v0.4.3"
+        env:
+          GITHUB_TOKEN: "${{ secrets.YNPUT_BOT_TOKEN }}"
+          IGNORED: ".gitignore\n*.md\n*.json"
+        with:
+          sizes: >
+            {
+              "0": "XS",
+              "100": "S",
+              "500": "M",
+              "1000": "L",
+              "1500": "XL",
+              "2500": "XXL"
+            }
+
+  label_prs_branch:
+    name: pr_branch_label
+    runs-on: ubuntu-latest
+    if: github.event.action == 'assigned' || github.event.action == 'opened'
+    steps:
+    - name: Label PRs - Branch name detection
+      uses: ffittschen/pr-branch-labeler@v1
+      with:
+        repo-token: ${{ secrets.YNPUT_BOT_TOKEN }}
+
+  label_prs_globe:
+    name: pr_globe_label
+    runs-on: ubuntu-latest
+    if: github.event.action == 'assigned' || github.event.action == 'opened'
+    steps:
+    - name: Label PRs - Globe detection
+      uses: actions/labeler@v4.0.3
+      with:
+        repo-token: ${{ secrets.YNPUT_BOT_TOKEN }}
+        configuration-path: ".github/pr-glob-labeler.yml"
+        sync-labels: false

.github/workflows/prerelease.yml

@@ -1,4 +1,4 @@
-name: Nightly Prerelease
+name: ⏳ Nightly Prerelease
 
 on:
   workflow_dispatch:

.github/workflows/project_task_statuses.yml

@@ -1,8 +1,6 @@
-name: project-actions
+name: 📊 Project task statuses
 
 on:
-  pull_request_target:
-    types: [opened, assigned]
   pull_request_review:
     types: [submitted]
   issue_comment:
@@ -70,46 +68,3 @@ jobs:
           -d '{
              "status": "in progress"
            }'
-
-  size-label:
-    name: pr_size_label
-    runs-on: ubuntu-latest
-    if: github.event.action == 'assigned' || github.event.action == 'opened'
-    steps:
-      - name: Add size label
-        uses: "pascalgn/size-label-action@v0.4.3"
-        env:
-          GITHUB_TOKEN: "${{ secrets.YNPUT_BOT_TOKEN }}"
-          IGNORED: ".gitignore\n*.md\n*.json"
-        with:
-          sizes: >
-            {
-              "0": "XS",
-              "100": "S",
-              "500": "M",
-              "1000": "L",
-              "1500": "XL",
-              "2500": "XXL"
-            }
-
-  label_prs_branch:
-    name: pr_branch_label
-    runs-on: ubuntu-latest
-    if: github.event.action == 'assigned' || github.event.action == 'opened'
-    steps:
-    - name: Label PRs - Branch name detection
-      uses: ffittschen/pr-branch-labeler@v1
-      with:
-        repo-token: ${{ secrets.YNPUT_BOT_TOKEN }}
-
-  label_prs_globe:
-    name: pr_globe_label
-    runs-on: ubuntu-latest
-    if: github.event.action == 'assigned' || github.event.action == 'opened'
-    steps:
-    - name: Label PRs - Globe detection
-      uses: actions/labeler@v4.0.3
-      with:
-        repo-token: ${{ secrets.YNPUT_BOT_TOKEN }}
-        configuration-path: ".github/pr-glob-labeler.yml"
-        sync-labels: false

.github/workflows/test_build.yml

@@ -1,7 +1,7 @@
 # This workflow will upload a Python Package using Twine when a release is created
 # For more information see: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries
 
-name: Test Build
+name: 🏗️ Test Build
 
 on:
   pull_request:

.github/workflows/update_bug_report.yml

@@ -0,0 +1,25 @@
+name: 🐞 Update Bug Report
+
+on:
+  workflow_dispatch:
+  release:
+    # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
+    types: [published]
+
+jobs:
+  update-bug-report:
+    runs-on: ubuntu-latest
+    name: Update bug report
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          ref: ${{ github.event.release.target_commitish }}
+      - name: Update version
+        uses: ShaMan123/gha-populate-form-version@v2.0.2
+        with:
+          github_token: ${{ secrets.YNPUT_BOT_TOKEN }}
+          registry: github
+          dropdown: _version
+          limit_to: 25
+          form: .github/ISSUE_TEMPLATE/bug_report.yml
+          commit_message: 'chore(): update bug report / version'

openpype/hosts/maya/plugins/publish/extract_look.py

@@ -26,7 +26,7 @@ HARDLINK = 2
 
 
 @attr.s
-class TextureResult:
+class TextureResult(object):
     """The resulting texture of a processed file for a resource"""
     # Path to the file
     path = attr.ib()

openpype/hosts/nuke/plugins/publish/validate_asset_name.py

@@ -9,9 +9,9 @@ import openpype.hosts.nuke.api.lib as nlib
 from openpype.pipeline.publish import (
     ValidateContentsOrder,
     PublishXmlValidationError,
+    OptionalPyblishPluginMixin
 )
 
-
 class SelectInvalidInstances(pyblish.api.Action):
     """Select invalid instances in Outliner."""
 
@@ -92,7 +92,10 @@ class RepairSelectInvalidInstances(pyblish.api.Action):
             nlib.set_node_data(node, nlib.INSTANCE_DATA_KNOB, node_data)
 
 
-class ValidateCorrectAssetName(pyblish.api.InstancePlugin):
+class ValidateCorrectAssetName(
+    pyblish.api.InstancePlugin,
+    OptionalPyblishPluginMixin
+):
     """Validator to check if instance asset match context asset.
 
     When working in per-shot style you always publish data in context of
@@ -111,6 +114,9 @@ class ValidateCorrectAssetName(pyblish.api.InstancePlugin):
     optional = True
 
     def process(self, instance):
+        if not self.is_active(instance.data):
+            return
+
         asset = instance.data.get("asset")
         context_asset = instance.context.data["assetEntity"]["name"]
         node = instance.data["transientData"]["node"]

openpype/hosts/nuke/plugins/publish/validate_backdrop.py

@@ -1,8 +1,12 @@
 import nuke
 import pyblish
 from openpype.hosts.nuke import api as napi
-from openpype.pipeline import PublishXmlValidationError
 
+from openpype.pipeline.publish import (
+    ValidateContentsOrder,
+    PublishXmlValidationError,
+    OptionalPyblishPluginMixin
+)
 
 class SelectCenterInNodeGraph(pyblish.api.Action):
     """
@@ -46,12 +50,15 @@ class SelectCenterInNodeGraph(pyblish.api.Action):
         nuke.zoom(2, [min(all_xC), min(all_yC)])
 
 
-class ValidateBackdrop(pyblish.api.InstancePlugin):
+class ValidateBackdrop(
+    pyblish.api.InstancePlugin,
+    OptionalPyblishPluginMixin
+):
     """ Validate amount of nodes on backdrop node in case user
     forgotten to add nodes above the publishing backdrop node.
     """
 
-    order = pyblish.api.ValidatorOrder
+    order = ValidateContentsOrder
     optional = True
     families = ["nukenodes"]
     label = "Validate Backdrop"
@@ -59,6 +66,9 @@ class ValidateBackdrop(pyblish.api.InstancePlugin):
     actions = [SelectCenterInNodeGraph]
 
     def process(self, instance):
+        if not self.is_active(instance.data):
+            return
+
         child_nodes = instance.data["transientData"]["childNodes"]
         connections_out = instance.data["transientData"]["nodeConnectionsOut"]
 

openpype/hosts/nuke/plugins/publish/validate_script_attributes.py

@@ -18,7 +18,7 @@ class ValidateScriptAttributes(
 
     order = pyblish.api.ValidatorOrder + 0.1
     families = ["workfile"]
-    label = "Validatte script attributes"
+    label = "Validate script attributes"
     hosts = ["nuke"]
     optional = True
     actions = [RepairAction]

openpype/settings/defaults/project_settings/nuke.json

@@ -363,6 +363,11 @@
             "optional": true,
             "active": true
         },
+        "ValidateBackdrop": {
+            "enabled": true,
+            "optional": true,
+            "active": true
+        },
         "ValidateScript": {
             "enabled": true,
             "optional": true,

openpype/settings/entities/schemas/projects_schema/schemas/schema_nuke_publish.json

@@ -62,7 +62,7 @@
             "template_data": [
                 {
                     "key": "ValidateCorrectAssetName",
-                    "label": "Validate Correct Asset name"
+                    "label": "Validate Correct Asset Name"
                 }
             ]
         },
@@ -72,7 +72,7 @@
             "template_data": [
                 {
                     "key": "ValidateContainers",
-                    "label": "ValidateContainers"
+                    "label": "Validate Containers"
                 }
             ]
         },
@@ -81,7 +81,7 @@
             "collapsible": true,
             "checkbox_key": "enabled",
             "key": "ValidateKnobs",
-            "label": "ValidateKnobs",
+            "label": "Validate Knobs",
             "is_group": true,
             "children": [
                 {
@@ -104,6 +104,10 @@
                     "key": "ValidateOutputResolution",
                     "label": "Validate Output Resolution"
                 },
+                {
+                    "key": "ValidateBackdrop",
+                    "label": "Validate Backdrop"
+                },
                 {
                     "key": "ValidateGizmo",
                     "label": "Validate Gizmo (Group)"