Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-25 05:14:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Removed shell flag in subprocess call

Browse source 
Shell flag causes issue when ffmpeg is called with a list of arguments
This commit is contained in:
Petr Kalis 2021-09-20 11:32:40 +02:00
parent e086e21276
commit f31ec7bbf3
5 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
openpype/hosts/standalonepublisher/plugins/publish/extract_thumbnail.py
View file

@ -108,7 +108,7 @@ class ExtractThumbnailSP(pyblish.api.InstancePlugin):
# run subprocess
self.log.debug("Executing: {}".format(" ".join(subprocess_args)))
openpype.api.run_subprocess(
subprocess_args, shell=True, logger=self.log
subprocess_args, logger=self.log
)
# remove thumbnail key from origin repre

2
openpype/hosts/standalonepublisher/plugins/publish/extract_trim_video_audio.py
View file

@ -84,7 +84,7 @@ class ExtractTrimVideoAudio(openpype.api.Extractor):
joined_args = " ".join(ffmpeg_args)
self.log.info(f"Processing: {joined_args}")
openpype.api.run_subprocess(
ffmpeg_args, shell=True, logger=self.log
ffmpeg_args, logger=self.log
)
repre = {

3
openpype/plugins/publish/extract_jpeg_exr.py
View file

@ -122,13 +122,14 @@ class ExtractJpegEXR(pyblish.api.InstancePlugin):
self.log.debug("{}".format(subprocess_command))
try: # temporary until oiiotool is supported cross platform
run_subprocess(
subprocess_args, shell=True, logger=self.log
subprocess_args, logger=self.log
)
except RuntimeError as exp:
if "Compression" in str(exp):
self.log.debug("Unsupported compression on input files. " +
"Skipping!!!")
return
self.log.warning("Conversion crashed", exc_info=True)
raise
if "representations" not in instance.data:

2
openpype/plugins/publish/extract_review.py
View file

@ -228,7 +228,7 @@ class ExtractReview(pyblish.api.InstancePlugin):
)
openpype.api.run_subprocess(
subprocess_args, shell=True, logger=self.log
subprocess_args, logger=self.log
)
# delete files added to fill gaps

4
openpype/plugins/publish/extract_review_slate.py
View file

@ -209,7 +209,7 @@ class ExtractReviewSlate(openpype.api.Extractor):
"Slate Executing: {}".format(" ".join(slate_subprocess_args))
)
openpype.api.run_subprocess(
slate_subprocess_args, shell=True, logger=self.log
slate_subprocess_args, logger=self.log
)
# create ffmpeg concat text file path
@ -244,7 +244,7 @@ class ExtractReviewSlate(openpype.api.Extractor):
"Executing concat: {}".format(" ".join(concat_args))
)
openpype.api.run_subprocess(
concat_args, shell=True, logger=self.log
concat_args, logger=self.log
)
self.log.debug("__ repre[tags]: {}".format(repre["tags"]))