From 6b09504eadb131dfcb78834c6b67ae90102fd8ca Mon Sep 17 00:00:00 2001
From: Zipodod <49460980+Zipodod@users.noreply.github.com>
Date: Wed, 17 May 2023 08:14:26 -0400
Subject: [PATCH] Bugfix/frame variable fix (#4978)

* Fix variable name on Max reset frame range

* Fix variable name on Maya collect animation

* Fix variable name on Nuke reset frame range

* Fix lines over max width

* Fix error on variable rename

* Fix line over max width

---------

Co-authored-by: jbeaulieu <jbeaulieu@alkemy-x.com>
---
 openpype/hosts/max/api/lib.py  | 12 ++++++++----
 openpype/hosts/maya/api/lib.py | 10 ++++++----
 openpype/hosts/nuke/api/lib.py |  8 ++++----
 3 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/openpype/hosts/max/api/lib.py b/openpype/hosts/max/api/lib.py
index 1310097f29..d9213863b1 100644
--- a/openpype/hosts/max/api/lib.py
+++ b/openpype/hosts/max/api/lib.py
@@ -245,11 +245,15 @@ def reset_frame_range(fps: bool = True):
         fps_number = float(data_fps["data"]["fps"])
         rt.frameRate = fps_number
     frame_range = get_frame_range()
-    frame_start = frame_range["frameStart"] - int(frame_range["handleStart"])
-    frame_end = frame_range["frameEnd"] + int(frame_range["handleEnd"])
-    frange_cmd = f"animationRange = interval {frame_start} {frame_end}"
+    frame_start_handle = frame_range["frameStart"] - int(
+        frame_range["handleStart"]
+    )
+    frame_end_handle = frame_range["frameEnd"] + int(frame_range["handleEnd"])
+    frange_cmd = (
+        f"animationRange = interval {frame_start_handle} {frame_end_handle}"
+    )
     rt.execute(frange_cmd)
-    set_render_frame_range(frame_start, frame_end)
+    set_render_frame_range(frame_start_handle, frame_end_handle)
 
 
 def set_context_setting():
diff --git a/openpype/hosts/maya/api/lib.py b/openpype/hosts/maya/api/lib.py
index f814187cc1..0bcadbe76e 100644
--- a/openpype/hosts/maya/api/lib.py
+++ b/openpype/hosts/maya/api/lib.py
@@ -316,11 +316,13 @@ def collect_animation_data(fps=False):
     # get scene values as defaults
     frame_start = cmds.playbackOptions(query=True, minTime=True)
     frame_end = cmds.playbackOptions(query=True, maxTime=True)
-    handle_start = cmds.playbackOptions(query=True, animationStartTime=True)
-    handle_end = cmds.playbackOptions(query=True, animationEndTime=True)
+    frame_start_handle = cmds.playbackOptions(
+        query=True, animationStartTime=True
+    )
+    frame_end_handle = cmds.playbackOptions(query=True, animationEndTime=True)
 
-    handle_start = frame_start - handle_start
-    handle_end = handle_end - frame_end
+    handle_start = frame_start - frame_start_handle
+    handle_end = frame_end_handle - frame_end
 
     # build attributes
     data = OrderedDict()
diff --git a/openpype/hosts/nuke/api/lib.py b/openpype/hosts/nuke/api/lib.py
index 64fa32a383..a439142051 100644
--- a/openpype/hosts/nuke/api/lib.py
+++ b/openpype/hosts/nuke/api/lib.py
@@ -2239,13 +2239,13 @@ class WorkfileSettings(object):
         handle_end = data["handleEnd"]
 
         fps = float(data["fps"])
-        frame_start = int(data["frameStart"]) - handle_start
-        frame_end = int(data["frameEnd"]) + handle_end
+        frame_start_handle = int(data["frameStart"]) - handle_start
+        frame_end_handle = int(data["frameEnd"]) + handle_end
 
         self._root_node["lock_range"].setValue(False)
         self._root_node["fps"].setValue(fps)
-        self._root_node["first_frame"].setValue(frame_start)
-        self._root_node["last_frame"].setValue(frame_end)
+        self._root_node["first_frame"].setValue(frame_start_handle)
+        self._root_node["last_frame"].setValue(frame_end_handle)
         self._root_node["lock_range"].setValue(True)
 
         # setting active viewers