From fe02a093128b17a02d0c2e87405c8beca7bc23e4 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 24 May 2023 10:01:59 +0200
Subject: [PATCH] Deadline: fix selection from multiple webservices (#5015)

* OP-4380 - override default DL from project settings

* OP-4380 - updated documentation
---
 .../collect_default_deadline_server.py        | 26 ++++++++++++++++++-
 website/docs/module_deadline.md               |  3 +++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/openpype/modules/deadline/plugins/publish/collect_default_deadline_server.py b/openpype/modules/deadline/plugins/publish/collect_default_deadline_server.py
index e6ad6a9aa1..cb2b0cf156 100644
--- a/openpype/modules/deadline/plugins/publish/collect_default_deadline_server.py
+++ b/openpype/modules/deadline/plugins/publish/collect_default_deadline_server.py
@@ -4,7 +4,18 @@ import pyblish.api
 
 
 class CollectDefaultDeadlineServer(pyblish.api.ContextPlugin):
-    """Collect default Deadline Webservice URL."""
+    """Collect default Deadline Webservice URL.
+
+    DL webservice addresses must be configured first in System Settings for
+    project settings enum to work.
+
+    Default webservice could be overriden by
+    `project_settings/deadline/deadline_servers`. Currently only single url
+    is expected.
+
+    This url could be overriden by some hosts directly on instances with
+    `CollectDeadlineServerFromInstance`.
+    """
 
     order = pyblish.api.CollectorOrder + 0.410
     label = "Default Deadline Webservice"
@@ -23,3 +34,16 @@ class CollectDefaultDeadlineServer(pyblish.api.ContextPlugin):
         context.data["defaultDeadline"] = deadline_module.deadline_urls["default"]  # noqa: E501
 
         context.data["deadlinePassMongoUrl"] = self.pass_mongo_url
+
+        deadline_servers = (context.data
+                            ["project_settings"]
+                            ["deadline"]
+                            ["deadline_servers"])
+        if deadline_servers:
+            deadline_server_name = deadline_servers[0]
+            deadline_webservice = deadline_module.deadline_urls.get(
+                deadline_server_name)
+            if deadline_webservice:
+                context.data["defaultDeadline"] = deadline_webservice
+                self.log.debug("Overriding from project settings with {}".format(  # noqa: E501
+                    deadline_webservice))
diff --git a/website/docs/module_deadline.md b/website/docs/module_deadline.md
index 94b6a381c2..bca2a83936 100644
--- a/website/docs/module_deadline.md
+++ b/website/docs/module_deadline.md
@@ -22,6 +22,9 @@ For [AWS Thinkbox Deadline](https://www.awsthinkbox.com/deadline) support you ne
 
 5. Install our custom plugin and scripts to your deadline repository. It should be as simple as copying content of `openpype/modules/deadline/repository/custom` to `path/to/your/deadline/repository/custom`.
 
+Multiple different DL webservice could be configured. First set them in point 4., then they could be configured per project in `project_settings/deadline/deadline_servers`.
+Only single webservice could be a target of publish though.
+
 
 ## Configuration