Commit graph

455 commits

Author SHA1 Message Date
Petr Kalis
e7aa413038
AfterEffects: add review flag to each instance (#4884)
* OP-5657 - add artist control for review in AfterEffects

Artist can disable review to be created for particular publish.

* OP-5657 - add artist control for review in AfterEffects

Removed configuration for Deadline, should be controlled by what is on instance.

* OP-5657 - handle legacy instances

Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.

* OP-5657 - remove explicit review for all AE

Now handled directly on instance

* OP-5657 - fix - cannot remove now

Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.

* OP-5657 - fix - correct host name used

* OP-5657 - fix - correct handling of review

On local renders review should be added only from families, not from older approach through Settings.

Farm instance cannot have review in families or extract_review would get triggered even locally.

* OP-5657 - refactor - changed label

* OP-5657 - Hound

* OP-5657 - added explicitly skipping review

Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).

* OP-5657 - updated setting of review variable

instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.

* OP-5657 - fix adding review flag

* OP-5657 - updated test

Removed review for second instance.

* OP-5657 - refactor to context plugin

* OP-5657 - tie thumbnail to review for local render

Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
2023-05-04 12:16:58 +02:00
Jakub Jezek
602a4ae8ec
Merge branch 'develop' into feature/OP-5207_Global-host-color-management-activation 2023-05-02 20:56:58 +02:00
Petr Kalis
b8ce6e9e9c
Photoshop: add autocreators for review and flat image (#4871)
* OP-5656 - added auto creator for review in PS

Review instance should be togglable.
Review instance needs to be created for non publisher based workflows.

* OP-5656 - refactored names

* OP-5656 - refactored names

* OP-5656 - new auto creator for flat image

In old version flat image was created if no instances were created. Explicit auto creator added for clarity.

Standardization of state of plugins

* OP-5656 - updated according to auto image creator

Subset template should be used from autocreator and not be separate.

* OP-5656 - fix proper creator name

* OP-5656 - fix log message

* OP-5656 - fix use enable state

* OP-5656 - fix formatting

* OP-5656 - add review toggle to image instance

For special cases where each image should have separate review.

* OP-5656 - fix description

* OP-5656 - fix not present asset and task in instance context

* OP-5656 - refactor - both auto creators should use same class

Provided separate description.

* OP-5656 - fix - propagate review to families

Image and auto image could have now review flag.
Bottom logic is only for Webpublisher.

* OP-5656 - fix - rename review files to avaid collision

Image family produces jpg and png, jpg review would clash with name. It should be replaced by 'jpg_jpg'.

* OP-5656 - fix - limit additional auto created only on WP

In artist based publishing auto image would be created by auto creator (if enabled). Artist might want to disable image creation.

* OP-5656 - added mark_for_review flag to Publish tab

* OP-5656 - fixes for auto creator

* OP-5656 - fixe - outputDef not needed

outputDef should contain dict of output definition. In PS it doesn't make sense as it has separate extract_review without output definitions.

* OP-5656 - added persistency of changes to auto creators

Changes as enabling/disabling, changing review flag should persist.

* OP-5656 - added documentation for admins

* OP-5656 - added link to new documentation for admins

* OP-5656 - Hound

* OP-5656 - Hound

* OP-5656 - fix shared families list

* OP-5656 - added default variant for review and workfile creator

For workfile Main was default variant, "" was for review.

* OP-5656 - fix - use values from Settings

* OP-5656 - fix - use original name of review for main review family

outputName cannot be in repre or file would have ..._jpg.jpg

* OP-5656 - refactor - standardized settings

Active by default denotes if created instance is active (eg. publishable) when created.

* OP-5656 - fixes for skipping collecting auto_image

data["ids"] are necessary for extracting. Members are physical layers in image, ids are "virtual" items, won't get grouped into real image instance.

* OP-5656 - reworked auto collectors

This allows to use automatic test for proper testing.

* OP-5656 - added automatic tests

* OP-5656 - fixes for auto collectors

* OP-5656 - removed unnecessary collector

Logic moved to auto collectors.

* OP-5656 - Hound
2023-05-02 11:19:50 +02:00
Jakub Jezek
aa2d683dd9
adding test routine for the slate condition 2023-04-20 21:49:58 +02:00
Jakub Ježek
864d1fc8e8
Merge branch 'develop' into feature/OP-5207_Global-host-color-management-activation 2023-04-17 12:30:53 +02:00
Jakub Jezek
6ae7b41533
fixing tests 2023-04-12 22:50:32 +02:00
Petr Kalis
80c50af2b9 OP-3951 - Hound 2023-03-30 13:45:37 +02:00
Petr Kalis
028d46597e Merge remote-tracking branch 'origin/bugfix/OP-3951_Deadline-checking-existing-frames-fails-when-there-is-number-in-file-name' into bugfix/OP-3951_Deadline-checking-existing-frames-fails-when-there-is-number-in-file-name 2023-03-30 13:43:11 +02:00
Petr Kalis
97d5b187e8 OP-3951 - updated logic
Doesn't make sense to validate sequence for single frame.
Updated tests accordingly. No sense in testing single frames so widely.
2023-03-30 13:42:30 +02:00
Petr Kalis
53d395e708
OP-3951 - updated value
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-29 13:19:21 +02:00
Petr Kalis
0a642d475c
OP-3951 - changed debug value
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-29 13:19:02 +02:00
Petr Kalis
e2546e5547
OP-3951 - removed unnecessary key
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-29 13:18:37 +02:00
Petr Kalis
36328f8b1a
OP-3951 - removed unnecessary key
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-29 13:18:07 +02:00
Petr Kalis
93d98c3f9c OP-3951 - use ext on representation
Without it ass.gz files won't work
2023-03-27 16:55:19 +02:00
Petr Kalis
94ceba790e OP-3951 - updated tests 2023-03-24 16:49:43 +01:00
Petr Kalis
f95007b660 OP-3951 - Hound 2023-03-24 11:15:27 +01:00
Petr Kalis
0648271ec7 OP-3951 - added tests for validate_sequence_frames
Introduced conftest with dummy environment for basic tests
2023-03-23 18:15:11 +01:00
Jakub Ježek
a2f56b7921
Merge pull request #4623 from ynput/bugfix/nuke-deadline-submitter 2023-03-21 11:37:47 +01:00
Petr Kalis
4506a2f3ef Fix broken Nuke local test
Accidentally used DL version
2023-03-20 13:41:17 +01:00
Petr Kalis
8449c2131d Extended Nuke testing classes with representation details 2023-03-15 18:28:55 +01:00
Roy Nieterau
ee7e2f1bcd Update tests and documentation for ExtractorColormanaged refactor to ColormanagedPyblishPluginMixin 2023-03-13 23:00:03 +01:00
Petr Kalis
ff19ae0385
Added setup_only to tests (#4591)
Allows to download test zip, unzip and restore DB in preparation for new test.
2023-03-13 15:37:23 +01:00
Petr Kalis
6704ba1531 OP-4850 - fix AE multicomposition
3 subsets >> 3 versions
2023-01-31 18:35:36 +01:00
Petr Kalis
148c55361f OP-4850 - fix AE tests
'png' extension have 2 representations instead 1. (One is regular, one is from review, with name 'png_png'
2023-01-31 18:06:44 +01:00
Jakub Jezek
37dc18b837
hound comments 2023-01-25 15:55:03 +01:00
Jakub Jezek
3d4d63bd08
flake8 fixes 2023-01-17 14:47:54 +01:00
Jakub Jezek
29d51b0209
testing: updating test data to colorspace 2023-01-13 13:19:53 +01:00
Jakub Jezek
54f04dd7de
testing: refactor set_representation_colorspace to address new inputs 2023-01-11 17:32:11 +01:00
Jakub Jezek
e13a99782f
testing: updating to new gdrive data 2023-01-05 17:20:09 +01:00
Jakub Jezek
f2a9169ffd
testing: publish plugins finalisation 2023-01-05 17:16:42 +01:00
Jakub Jezek
70b2df5fff
testing: adding publish plugins tests 2023-01-04 21:32:59 +01:00
Jakub Jezek
a429352964
testing: abstracting legacy_io fixture to lib for other pipeline tests 2023-01-04 21:32:40 +01:00
Jakub Jezek
c87b147d48
testing: removing prints form colorspace tests 2023-01-04 16:06:46 +01:00
Jakub Jezek
14b52ac625
testing: colorspace legacy_io fixture 2023-01-04 13:54:08 +01:00
Jakub Jezek
233808f1ee
testing: fixing relation of fixture 2023-01-04 13:53:41 +01:00
Jakub Jezek
4518d57543
testing: colorspace update 2023-01-04 13:46:51 +01:00
Petr Kalis
7e73aba4ae Move setting of project root to dbcon fixture
Previously root was only set for launched app, it should be available also for unit tests.
2023-01-04 11:52:07 +01:00
Jakub Jezek
ff9edbdc26
testing: improving test module unit test class 2023-01-03 22:04:02 +01:00
Jakub Jezek
f40495ebbf
testing: colorspace test file rules 2023-01-03 22:02:49 +01:00
Jakub Jezek
4d24aa6984
testing: colorspace legacy_io to fixture 2023-01-03 21:19:21 +01:00
Jakub Jezek
e36b441426
testing: improving colorspace 2023-01-03 20:53:33 +01:00
Petr Kalis
05a11f642b Bumped log higher
It is better to have it earlier because of possible errors during downloading
2023-01-03 13:41:40 +01:00
Jakub Jezek
72cb5ae754
testing: pipeline colorspace get views 2022-12-30 20:48:43 +01:00
Jakub Jezek
56aca63056
testing: adding basic colorspace testing 2022-12-30 16:54:45 +01:00
Petr Kalis
492e5bbd03 Merge develop 2022-12-08 11:21:38 +01:00
Petr Kalis
e2ec1457c9 Fix Nuke legacy test
Legacy Nuke tests are not cleaning up `renders` folders. Branch with DL version disables Cleanup for now.
2022-12-02 16:35:04 +01:00
Petr Kalis
1fcc15583c Fix AE legacy test 2022-12-02 16:31:56 +01:00
Petr Kalis
e68ad503e7 Remove temporarily AE tests configured for Tray Publisher 2022-12-02 16:07:47 +01:00
Petr Kalis
5207387352 Added AE test with old stored instances
Release 3.15 will move to New Publisher
2022-12-02 16:07:04 +01:00
Petr Kalis
bf58eb8322 Hound 2022-12-02 16:04:10 +01:00