Commit graph

88 commits

Author SHA1 Message Date
Jakub Trllo
93fb76f359
Extract Review: Multilayer specification for ffmpeg (#5613)
* added function to extract more information about channels

* specify layer name which should be used for ffmpeg

* changed 'get_channels_info_by_layer_name' to 'get_review_info_by_layer_name'

* modify docstring

* fix dosctring again
2023-09-14 13:55:25 +02:00
Roy Nieterau
3a02964af5 Do not show debug log about ffmpeg probe in artist-facing report 2023-09-07 15:58:28 +02:00
Jakub Trllo
d63aa34a76
AYON: 3rd party addon usage (#5300)
* implemented helper functions to get ffmpeg and oiio tool arguments

* modified validation functions to be able to handle list of arguments

* path getters can return a path in AYON mode if one argument is returned

* removed test exception

* modified docstrings

* is_oiio_supported is using new functions to get launch arguments

* new functions are in lib public =

* use new functions all over the place

* renamed 'ffmpeg_path' to 'ffmpeg_args'

* raise 'ToolNotFoundError' if tool argument could not be found

* reraise 'KnownPublishError' in publish plugins

* fix comment

* simplify args start

* ffmpeg and oiio function require tool name and support additional arguments

* renamed 'get_oiio_tools_args' to 'get_oiio_tool_args'

* fix variable name
2023-07-27 10:54:45 +02:00
Jakub Jezek
fbb6afe5c3
adding psd to IMAGE_EXTENSIONS constant 2023-06-06 17:17:42 +02:00
Roy Nieterau
3fae1f8521 Just some grammar tweaks 2023-03-30 13:59:22 +02:00
Petr Kalis
be6a22b485 Fix - newline 2023-02-23 16:42:48 +01:00
Petr Kalis
72a3572d95 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 16:35:42 +01:00
Petr Kalis
945f1dfe55 OP-4643 - added explicit enum for transcoding type
As transcoding info (colorspace, display) might be collected from DCC, it must be explicit which should be used.
2023-02-23 15:39:55 +01:00
Petr Kalis
5678bdbf06 OP-4643 - different splitting for oiio
It seems that logic in ExtractReview does different thing.
2023-02-23 15:39:55 +01:00
Petr Kalis
559d54c3a1 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 15:39:55 +01:00
Petr Kalis
984974d7e0 OP-4643 - split command line arguments to separate items
Reuse existing method from ExtractReview, put it into transcoding.py
2023-02-23 15:39:54 +01:00
Petr Kalis
3921982365 OP-4642 - added additional command arguments for oiiotool
Some extension requires special command line arguments (.dpx and binary depth).
2023-02-23 15:39:54 +01:00
Petr Kalis
925c7a9564 OP-4643 - updated docstring for convert_colorspace 2023-02-23 15:39:53 +01:00
Petr Kalis
016111ab33 OP-4643 - changed docstring
Elaborated more that 'target_colorspace' and ('view', 'display') are disjunctive.
2023-02-23 15:39:53 +01:00
Petr Kalis
97a2014c12 OP-4643 - moved output argument to the end 2023-02-23 15:39:53 +01:00
Petr Kalis
7e9d707226 OP-4643 - updated docstring, standardized arguments 2023-02-23 15:39:52 +01:00
Petr Kalis
be176bbeb2 OP-4643 - implemented display and viewer color space 2023-02-23 15:39:52 +01:00
Petr Kalis
83d21d9d77 OP-4643 - changed oiio_cmd creation
Co-authored-by: Toke Jepsen <tokejepsen@gmail.com>
2023-02-23 15:39:52 +01:00
Petr Kalis
9fc4070e06 OP-4643 - refactored according to review
Function turned into single filepath input.
2023-02-23 15:39:51 +01:00
Petr Kalis
ec299f0d3c OP-4643 - pass path for ocio config 2023-02-23 15:39:51 +01:00
Petr Kalis
2f1888bbfb OP-4643 - added ExtractColorTranscode
Added method to convert from one colorspace to another to transcoding lib
2023-02-23 15:39:50 +01:00
Petr Kalis
6cb8cbd6fc OP-4643 - added explicit enum for transcoding type
As transcoding info (colorspace, display) might be collected from DCC, it must be explicit which should be used.
2023-02-23 15:36:03 +01:00
Petr Kalis
840f681134 OP-4643 - different splitting for oiio
It seems that logic in ExtractReview does different thing.
2023-02-23 15:36:03 +01:00
Petr Kalis
94ee028792 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 15:36:03 +01:00
Petr Kalis
b304d63461 OP-4643 - split command line arguments to separate items
Reuse existing method from ExtractReview, put it into transcoding.py
2023-02-23 15:36:02 +01:00
Petr Kalis
b1d30058b0 OP-4642 - added additional command arguments for oiiotool
Some extension requires special command line arguments (.dpx and binary depth).
2023-02-23 15:36:01 +01:00
Petr Kalis
7eacd1f30f OP-4643 - updated docstring for convert_colorspace 2023-02-23 15:36:00 +01:00
Petr Kalis
190a79a836 OP-4643 - changed docstring
Elaborated more that 'target_colorspace' and ('view', 'display') are disjunctive.
2023-02-23 15:36:00 +01:00
Petr Kalis
8598c1ec39 OP-4643 - moved output argument to the end 2023-02-23 15:36:00 +01:00
Petr Kalis
176f53117f OP-4643 - updated docstring, standardized arguments 2023-02-23 15:35:59 +01:00
Petr Kalis
382074b54c OP-4643 - implemented display and viewer color space 2023-02-23 15:35:59 +01:00
Petr Kalis
756661f71b OP-4643 - changed oiio_cmd creation
Co-authored-by: Toke Jepsen <tokejepsen@gmail.com>
2023-02-23 15:35:59 +01:00
Petr Kalis
5a562dc821 OP-4643 - refactored according to review
Function turned into single filepath input.
2023-02-23 15:35:58 +01:00
Petr Kalis
52a5865341 OP-4643 - pass path for ocio config 2023-02-23 15:35:57 +01:00
Petr Kalis
8a67065fce OP-4643 - added ExtractColorTranscode
Added method to convert from one colorspace to another to transcoding lib
2023-02-23 15:35:57 +01:00
Jakub Trllo
cf17ff50b5 use detached process in ffprobe 2023-02-22 14:07:38 +01:00
Jakub Trllo
2d5969a732
Merge pull request #4060 from pypeclub/bugfix/oiio_conversion_multipart_fix
General: Oiio conversion multipart fix
2022-12-06 16:30:51 +01:00
Jakub Trllo
5c37d91138 uncomment subimages because multipart exr is created which actually can't ffmpeg handle 2022-11-16 17:20:44 +01:00
Jakub Trllo
ebbf827f08 fix line length 2022-11-02 16:43:11 +01:00
Jakub Trllo
560f327de1 comment out subimage 2022-11-02 16:38:57 +01:00
Jakub Trllo
f437ce7c98 fix variable names 2022-11-02 16:37:26 +01:00
Jakub Trllo
61d9657ce1 subimages are reason for conversion and skip definition of input channels if there are subimages 2022-11-02 12:20:58 +01:00
Jakub Trllo
7aca8136f5 'get_oiio_info_for_input' can return information about all subimages 2022-11-02 12:19:32 +01:00
Jakub Trllo
7cf4e085f7 handle more types 2022-11-02 12:19:02 +01:00
Jakub Trllo
bebb9031c1 change type of 'IMAGE_EXTENSIONS' and 'VIDEO_EXTENSIONS' to set 2022-11-01 10:12:26 +01:00
Petr Kalis
1c7827aab0
Merge pull request #3908 from pypeclub/feature/OP-3938_Ftrack-image-review-instead-of-single-frame-video
Photoshop: create single frame image in Ftrack as review
2022-10-07 09:27:13 +02:00
Petr Kalis
8d9c3f2b5e OP-3938 - extracted image an video extensions to lib.transcoding
Extracted to lib for better reusability.
2022-09-22 14:51:29 +02:00
Jakub Trllo
022b6c6f54
Merge pull request #3849 from pypeclub/feature/transcoding_float2_attr_type
General: Transcoding handle float2 attr type
2022-09-22 09:37:13 +02:00
Jakub Trllo
e5b82d1123 lowered log level and modified messages on unknown value type 2022-09-14 13:50:21 +02:00
Jakub Trllo
6186c63c59 added 'float2' type support 2022-09-14 13:50:01 +02:00