Commit graph

92 commits

Author SHA1 Message Date
Petr Kalis
e7aa413038
AfterEffects: add review flag to each instance (#4884)
* OP-5657 - add artist control for review in AfterEffects

Artist can disable review to be created for particular publish.

* OP-5657 - add artist control for review in AfterEffects

Removed configuration for Deadline, should be controlled by what is on instance.

* OP-5657 - handle legacy instances

Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.

* OP-5657 - remove explicit review for all AE

Now handled directly on instance

* OP-5657 - fix - cannot remove now

Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.

* OP-5657 - fix - correct host name used

* OP-5657 - fix - correct handling of review

On local renders review should be added only from families, not from older approach through Settings.

Farm instance cannot have review in families or extract_review would get triggered even locally.

* OP-5657 - refactor - changed label

* OP-5657 - Hound

* OP-5657 - added explicitly skipping review

Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).

* OP-5657 - updated setting of review variable

instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.

* OP-5657 - fix adding review flag

* OP-5657 - updated test

Removed review for second instance.

* OP-5657 - refactor to context plugin

* OP-5657 - tie thumbnail to review for local render

Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
2023-05-04 12:16:58 +02:00
Petr Kalis
b8ce6e9e9c
Photoshop: add autocreators for review and flat image (#4871)
* OP-5656 - added auto creator for review in PS

Review instance should be togglable.
Review instance needs to be created for non publisher based workflows.

* OP-5656 - refactored names

* OP-5656 - refactored names

* OP-5656 - new auto creator for flat image

In old version flat image was created if no instances were created. Explicit auto creator added for clarity.

Standardization of state of plugins

* OP-5656 - updated according to auto image creator

Subset template should be used from autocreator and not be separate.

* OP-5656 - fix proper creator name

* OP-5656 - fix log message

* OP-5656 - fix use enable state

* OP-5656 - fix formatting

* OP-5656 - add review toggle to image instance

For special cases where each image should have separate review.

* OP-5656 - fix description

* OP-5656 - fix not present asset and task in instance context

* OP-5656 - refactor - both auto creators should use same class

Provided separate description.

* OP-5656 - fix - propagate review to families

Image and auto image could have now review flag.
Bottom logic is only for Webpublisher.

* OP-5656 - fix - rename review files to avaid collision

Image family produces jpg and png, jpg review would clash with name. It should be replaced by 'jpg_jpg'.

* OP-5656 - fix - limit additional auto created only on WP

In artist based publishing auto image would be created by auto creator (if enabled). Artist might want to disable image creation.

* OP-5656 - added mark_for_review flag to Publish tab

* OP-5656 - fixes for auto creator

* OP-5656 - fixe - outputDef not needed

outputDef should contain dict of output definition. In PS it doesn't make sense as it has separate extract_review without output definitions.

* OP-5656 - added persistency of changes to auto creators

Changes as enabling/disabling, changing review flag should persist.

* OP-5656 - added documentation for admins

* OP-5656 - added link to new documentation for admins

* OP-5656 - Hound

* OP-5656 - Hound

* OP-5656 - fix shared families list

* OP-5656 - added default variant for review and workfile creator

For workfile Main was default variant, "" was for review.

* OP-5656 - fix - use values from Settings

* OP-5656 - fix - use original name of review for main review family

outputName cannot be in repre or file would have ..._jpg.jpg

* OP-5656 - refactor - standardized settings

Active by default denotes if created instance is active (eg. publishable) when created.

* OP-5656 - fixes for skipping collecting auto_image

data["ids"] are necessary for extracting. Members are physical layers in image, ids are "virtual" items, won't get grouped into real image instance.

* OP-5656 - reworked auto collectors

This allows to use automatic test for proper testing.

* OP-5656 - added automatic tests

* OP-5656 - fixes for auto collectors

* OP-5656 - removed unnecessary collector

Logic moved to auto collectors.

* OP-5656 - Hound
2023-05-02 11:19:50 +02:00
Petr Kalis
4506a2f3ef Fix broken Nuke local test
Accidentally used DL version
2023-03-20 13:41:17 +01:00
Petr Kalis
8449c2131d Extended Nuke testing classes with representation details 2023-03-15 18:28:55 +01:00
Petr Kalis
6704ba1531 OP-4850 - fix AE multicomposition
3 subsets >> 3 versions
2023-01-31 18:35:36 +01:00
Petr Kalis
148c55361f OP-4850 - fix AE tests
'png' extension have 2 representations instead 1. (One is regular, one is from review, with name 'png_png'
2023-01-31 18:06:44 +01:00
Jakub Jezek
37dc18b837
hound comments 2023-01-25 15:55:03 +01:00
Petr Kalis
492e5bbd03 Merge develop 2022-12-08 11:21:38 +01:00
Petr Kalis
e2ec1457c9 Fix Nuke legacy test
Legacy Nuke tests are not cleaning up `renders` folders. Branch with DL version disables Cleanup for now.
2022-12-02 16:35:04 +01:00
Petr Kalis
1fcc15583c Fix AE legacy test 2022-12-02 16:31:56 +01:00
Petr Kalis
e68ad503e7 Remove temporarily AE tests configured for Tray Publisher 2022-12-02 16:07:47 +01:00
Petr Kalis
5207387352 Added AE test with old stored instances
Release 3.15 will move to New Publisher
2022-12-02 16:07:04 +01:00
Petr Kalis
bf58eb8322 Hound 2022-12-02 16:04:10 +01:00
Petr Kalis
412d03d382 Merge fixes for tests from branch with Deadline tests.
Branch with newly implemented DL tests is targetted to release 3.15, but changes from it affects tests in develop.
This branch should solve issues with automatic tests in develop without need of full release 3.15 changes.
2022-12-02 15:52:04 +01:00
Petr Kalis
02b7c64491 OP-3426 - fix expected count of representation
This changed as default for single frame is png, not mp4 now.
2022-11-21 17:12:39 +01:00
Petr Kalis
bd5e8285e9 OP-3426 - added legacy publish in AE
Instances creaed in Publisher are not working in old Pyblish, but old instances should be publishable automatically.
2022-11-21 14:01:46 +01:00
Petr Kalis
7f166ddf3f OP-3426 - fix AE tests
ExtractReview for single frames was merged, therefore it is expected, that only png representation is expected.
2022-11-14 17:36:22 +01:00
Petr Kalis
40d2571487 OP-3426 - added test job for multi composition in AE in DL
Depends on OP-4361
2022-11-11 19:30:05 +01:00
Petr Kalis
0c9c9c40b8 OP-3426 - remove not working set of failed 2022-11-11 19:21:52 +01:00
Petr Kalis
a48c76b003 OP-3426 - set failed when assertion error
Failed is used to persist errrored run.
2022-11-11 18:21:33 +01:00
Petr Kalis
81a3cba025 OP-4361 - cleaned up AE tests 2022-11-11 16:42:30 +01:00
Petr Kalis
350685b4c6 OP-3426 - changed APP to APP_GROUP
APP_GROUP is more descriptive
2022-11-04 18:08:01 +01:00
Petr Kalis
381ea92477 OP-3426 - fix subset name in Nuke 2022-10-27 15:57:41 +02:00
Petr Kalis
9192005a84 OP-3426 - increase timeout for Nuke
It seems that it takes longer on testing PC, this should be safe.
2022-10-27 15:40:05 +02:00
Petr Kalis
f73330565e OP-3426 - filter out Auto-Save folder 2022-10-25 11:28:14 +02:00
Petr Kalis
22a86f89f7 OP-3426 - updated PS testing class 2022-10-24 18:22:34 +02:00
Petr Kalis
1f18639c4e OP-3426 - fix - counts of expected items in DB
Format of subset names was changed, default settings contain also hero version etc.
2022-10-24 16:43:40 +02:00
Petr Kalis
e94c524ece OP-3426 - fix - counts of expected items in DB
Format of subset names was changed, default settings contain also hero version etc.
2022-10-24 15:10:26 +02:00
Petr Kalis
d35ea96bd0 OP-3426 - added filtering of published folders from comparing
Some files or folders are dynamically created and cannot be part of comparing of published and expected folder structure.
(Example is Logs in AE from DL)
2022-10-24 11:52:08 +02:00
Petr Kalis
e38ae9d919 OP-3426 - refactor - rename workfile 2022-10-21 16:45:14 +02:00
Petr Kalis
5d9aaecea0 OP-3426 - fix output folder
output_folder_url should be used, contains already 'output' subfolder
2022-10-21 15:58:25 +02:00
Petr Kalis
76de4e4bbb OP-3426 - added support for automatic tests into GlobalJobPreLoad
Jobs sent to DL must propagate flag IS_TEST to note that job is an automatic tests, it should use different DBs from regular jobs.
2022-10-19 13:40:33 +02:00
Petr Kalis
29ca3f8556 OP-4180 - change output folder
It should be in `output` subfolder, not in root
2022-10-19 12:30:03 +02:00
Petr Kalis
b98e03726d OP-4180 - renamed DL testing class for Nuke
Updated test scene name
2022-10-19 12:27:24 +02:00
Petr Kalis
0056be47b1 OP-3426 - fix - wrong testing class used 2022-10-18 13:23:22 +02:00
Petr Kalis
c27d8a2678 OP-3426 - refactor - changed style of db asserts for Maya 2022-10-18 13:05:51 +02:00
Petr Kalis
eb772dd05a OP-3426 - update db asserts for PS
Removed integrate of thumbnails by default, eg less representations.
2022-10-18 12:58:03 +02:00
Petr Kalis
2436fabd7f OP-3426 - update db asserts for simple Maya test 2022-10-18 12:54:00 +02:00
Petr Kalis
7c904861fd OP-3426 - test class for Maya and Deadline 2022-10-18 12:36:56 +02:00
Petr Kalis
9159b67051 OP-3426 - fix source zip file for Nuke 2022-10-17 15:45:06 +02:00
Petr Kalis
fdaa7774a4 OP-3426 - added new Nuke deadline testing class 2022-10-17 14:22:52 +02:00
Petr Kalis
6f5c91c785 OP-3426 - refactor - Nuke to new testing classes 2022-10-17 14:11:54 +02:00
Petr Kalis
646dcd92ae OP-3426 - fix proper zip id for deadline test 2022-10-17 14:02:39 +02:00
Petr Kalis
5ee97fa8e2 OP-3426 - DL support for AE automatic tests
WIP
2022-10-14 15:24:48 +02:00
Petr Kalis
e3864ead41 OP-3426 - DL support for Maya automatic tests
WIP
2022-10-14 15:21:25 +02:00
Petr Kalis
67b9946f20 OP-3684 - added new testing class for multiframe AE publish
Previous test published only single frame, didn't catch issue in new integrate.
2022-08-03 13:36:20 +02:00
Petr Kalis
b376743373 Fix - moved conftest to be applicable for all kind of tests 2022-04-06 14:15:38 +02:00
Petr Kalis
c6805d5b5a Added timeout to command line arguments 2022-02-16 18:08:15 +01:00
Petr Kalis
8b8f952437 Updated db asserts in After Effects 2022-02-14 20:06:45 +01:00
Petr Kalis
7042330924 Updated db_asserts for Photoshop publish test 2022-02-14 20:02:38 +01:00