Commit graph

156 commits

Author SHA1 Message Date
Petr Kalis
136af34a71
AfterEffects: set frame range and resolution (#4983)
* OP-5660 - adding menu buttons to Set frame range in AE

* OP-5660 - refactored location of scripts

set_settings should be in lib as it is used elsewhere, but launch_logic and lib created circular dependency.
Moved main to launch logic as it is actually handling launching.

* OP-5660 - added set_settings to creator

When instance gets created, set frame range and resolution from DB.

* OP-5660 - minor fix

* OP-5660 - updated extension zip

* OP-5660 - updated documentation

* OP-5660 - fixed missing exception

* OP-5660 - fixed argument

* OP-5560 - fix imports

* OP-5660 - updated extension

* OP-5660 - add js alert message for buttons

* OP-5660 - repacked extension

Without Anastasyi showed success, but extension wasn't loaded.

* OP-5660 - make log message nicer

* OP-5660 - added log if workfile not saved

* OP-5660 - provide defaults to limit None exception

* OP-5660 - updated error message
2023-05-22 10:45:20 +02:00
Petr Kalis
e7aa413038
AfterEffects: add review flag to each instance (#4884)
* OP-5657 - add artist control for review in AfterEffects

Artist can disable review to be created for particular publish.

* OP-5657 - add artist control for review in AfterEffects

Removed configuration for Deadline, should be controlled by what is on instance.

* OP-5657 - handle legacy instances

Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.

* OP-5657 - remove explicit review for all AE

Now handled directly on instance

* OP-5657 - fix - cannot remove now

Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.

* OP-5657 - fix - correct host name used

* OP-5657 - fix - correct handling of review

On local renders review should be added only from families, not from older approach through Settings.

Farm instance cannot have review in families or extract_review would get triggered even locally.

* OP-5657 - refactor - changed label

* OP-5657 - Hound

* OP-5657 - added explicitly skipping review

Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).

* OP-5657 - updated setting of review variable

instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.

* OP-5657 - fix adding review flag

* OP-5657 - updated test

Removed review for second instance.

* OP-5657 - refactor to context plugin

* OP-5657 - tie thumbnail to review for local render

Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
2023-05-04 12:16:58 +02:00
Thomas Fricard
fcffb91948
After Effects: fix handles KeyError (#4727)
* get handles from context if not in asset

* fix linting errors

* get frameStart, frameEnd, handleStart and handleEnd from context

---------

Co-authored-by: clement hector <clement.hector@fixstudio.com>
Co-authored-by: Thomas Fricard <tfricard@ws114.prs.vfx.int>
2023-04-14 17:39:53 +02:00
Petr Kalis
b70c6e4bfd OP-4938 - fix obsolete access to instance change 2023-02-15 18:32:56 +01:00
Petr Kalis
0301309502 OP-4928 - removed legacy_io in workfile creator in AE
Legacy_io should be eradicated, replaced by abstracted methods
2023-02-15 12:33:35 +01:00
Petr Kalis
410ea87e18 OP-4928 - fix wrong usage of legacy_io
Import should be removed. Now it should be replaced from context.
2023-02-15 12:27:44 +01:00
Petr Kalis
59010eb9a6 OP-4653 - refactor - move most important method higher 2023-02-03 17:19:02 +01:00
Petr Kalis
31b137fa1d OP-4653 - Hound 2023-02-03 17:17:27 +01:00
Petr Kalis
993145e6f8 OP-4653 - fix wrong name 2023-02-03 17:16:55 +01:00
Petr Kalis
f2930ed156 OP-4653 - updated description in AE creator 2023-02-03 17:04:06 +01:00
Petr Kalis
53c1c842f5 OP-4653 - standardize use_composition_name
Follow more closely login in PS, eg. if {composition} placeholder not present in subset template and should be used, add capitalized.
Clean composition name
2023-02-03 17:02:33 +01:00
Petr Kalis
161e09bcdb OP-4615 - AE - fix missing list_instances 2023-01-17 12:30:59 +01:00
Petr Kalis
b0e433e520 OP-4362 - remove unnecessary call to super 2022-11-16 11:24:36 +01:00
Petr Kalis
9a503fce6a OP-4361 - fix wrong usage of regex 2022-11-15 16:49:40 +01:00
Petr Kalis
fb154ad4f1 OP-4361 - implemented multiple output modules per composition
Working version for local rendering.
2022-11-15 16:11:55 +01:00
Petr Kalis
2e1004c618 OP-4361 - rename composition after update, delete 2022-11-15 16:03:45 +01:00
Petr Kalis
702edb0efe OP-4361 - rename composition after create
Previously it was renaming composition with subset name, this was missing in new creator.
Renamed items to more descriptive 'comps'.
2022-11-15 12:17:27 +01:00
Petr Kalis
6a18fa0fda OP-4361 - updated Creator to use composition name
There is new flag to allow use composition name
Updated subset template. Removed obsolete 'renderLocal', now it is only 'render' with a flag.
2022-11-15 12:11:26 +01:00
Petr Kalis
5f302eb95c OP-4361 - streamline local render
Do not do get render queue again, should be already collected.
2022-11-11 12:20:19 +01:00
Petr Kalis
7ca8b4ddf4 OP-4361 - addd support for multiple composition in AE
There cannot be multiple Render items for same composition in Render Queue.
There cannot be multiple output modules for same Render item.
2022-11-10 17:36:58 +01:00
Petr Kalis
a48650512e OP-3909 - updated error messages 2022-11-04 11:33:47 +01:00
Petr Kalis
fbdb2336d8 OP-3909 - fix wrong host variable 2022-11-03 17:13:15 +01:00
Petr Kalis
de5decbcbb OP-3908 - revert back to AE specific cache method
Standard approach doesn't handle legacy instances, eg. instance without creator_identifier.
2022-11-03 13:20:24 +01:00
Petr Kalis
64f8e2fc9c OP-3909 - fix - use values, filtering is later 2022-11-03 12:49:49 +01:00
Petr Kalis
ab4ed37604 OP-3909 - fix - use family to filter instances
cached instances are dictionary where keys are creator identifier, eg family.
2022-11-03 12:15:22 +01:00
Petr Kalis
adb683bdfc OP-3909 - use caching function from creator
In between cache function was extracted into creator_plugins, use this to standardize betwen different hosts.
2022-11-03 10:46:20 +01:00
Petr Kalis
f78bd11977 OP-3909 - added caching of list_instances
list_instances could be expensive in larger workfiles, it makes sense to cache it for all creator, but only for collecting phase. (This is why creator.collection_shared_data is used.)
2022-11-03 10:26:53 +01:00
Petr Kalis
e44da54da8 OP-3909 - remove legacy creators 2022-11-02 19:01:51 +01:00
Petr Kalis
b52a2eef1f OP-3909 - remove initialization of AfterEffectsHost
Initialization might be expensive, use self.host instead.
2022-11-02 19:00:24 +01:00
Petr Kalis
64148737ff OP-3909 - fix usage of internal variable 2022-11-01 17:46:40 +01:00
Petr Kalis
dc9058bcb7 OP-3909 - refactor - added missed argument 2022-11-01 16:42:41 +01:00
Petr Kalis
53097c642f OP-3909 - refactor - introduced AfterEffectsHost
Use base class and implement abstract methods to standardize.
2022-11-01 16:41:54 +01:00
Jakub Trllo
e5c662d941 use Extractor from openpype.pipeline 2022-09-01 11:59:48 +02:00
Jakub Trllo
cd4b5ce227 Merge branch 'develop' into feature/OP-3835_Move-publish-utils-to-pipeline 2022-08-30 13:48:02 +02:00
Jakub Trllo
9e7abf5804 Merge branch 'develop' into feature/OP-3819_Move-subset-name-functionality 2022-08-26 14:59:49 +02:00
Jakub Trllo
10758ec144 use new source of order variables 2022-08-26 14:51:22 +02:00
Jakub Trllo
27517897ab use new imports of 'get_errored_plugins_from_context' and 'get_errored_instances_from_context' 2022-08-26 12:07:26 +02:00
Jakub Trllo
5d83a428d9 change imports to new location in loaders 2022-08-25 12:02:37 +02:00
Jakub Trllo
7a4cd9c1fa removed 'get_subset_name' and renamed 'get_subset_name_with_asset_doc' to 'get_subset_name' 2022-08-23 19:20:04 +02:00
Jakub Trllo
ce31b9a477 provide more data as arguments during publishing 2022-08-23 19:13:23 +02:00
Jakub Trllo
7e59a577a6 use new import of 'get_subset_name_with_asset_doc' 2022-08-23 19:12:28 +02:00
Petr Kalis
0e7c183c1d Added overwrite subset for different context in AE 2022-08-22 18:03:57 +02:00
Petr Kalis
be568a0e41 Added default variant for workfile creator for AE 2022-08-22 18:03:17 +02:00
Petr Kalis
5df9c1b41f Added default variant to workfile collectors for PS|AE
Will only propagate in workfile subset (and final published name of workfile) if {variant} is used in subset name template. (By default it isn't.)
2022-08-22 16:48:32 +02:00
Petr Kalis
7cfd9624a3 "OP-3684 - revert - fix for new publisher"
This reverts commit 80b6ef98

Made obsolete by https://github.com/pypeclub/OpenPype/pull/3611
2022-08-03 17:39:35 +02:00
Petr Kalis
bab5629e35 OP-3684 - use instance.data["farm"] to skip local integrate
No Settings necessary, instance itself should hold if it is targetted for farm (eg. not locally integrated.)
2022-08-03 16:26:46 +02:00
Petr Kalis
80b6ef981a OP-3684 - fix for new publisher
New publisher expects frames in file names in '.0000.' format, AE by default provides ('_0000.'). Locally rendered files need to be renamed to appropriate format.
2022-08-02 18:13:39 +02:00
Jakub Trllo
db79c1b282
Merge pull request #3442 from pypeclub/feature/OP-3499_Move-publish-render-abstractions
General: Move publish plugin and publish render abstractions
2022-07-12 12:15:29 +02:00
Jakub Trllo
56764f638f modified after effects creator init to use new args order 2022-07-08 11:34:08 +02:00
Jakub Trllo
2d8c41cc6e moved render abstractions to openpype.pipeline.publish 2022-06-30 10:39:05 +02:00