Commit graph

229 commits

Author SHA1 Message Date
Petr Kalis
136af34a71
AfterEffects: set frame range and resolution (#4983)
* OP-5660 - adding menu buttons to Set frame range in AE

* OP-5660 - refactored location of scripts

set_settings should be in lib as it is used elsewhere, but launch_logic and lib created circular dependency.
Moved main to launch logic as it is actually handling launching.

* OP-5660 - added set_settings to creator

When instance gets created, set frame range and resolution from DB.

* OP-5660 - minor fix

* OP-5660 - updated extension zip

* OP-5660 - updated documentation

* OP-5660 - fixed missing exception

* OP-5660 - fixed argument

* OP-5560 - fix imports

* OP-5660 - updated extension

* OP-5660 - add js alert message for buttons

* OP-5660 - repacked extension

Without Anastasyi showed success, but extension wasn't loaded.

* OP-5660 - make log message nicer

* OP-5660 - added log if workfile not saved

* OP-5660 - provide defaults to limit None exception

* OP-5660 - updated error message
2023-05-22 10:45:20 +02:00
Petr Kalis
60efa939a8
OP-5714 - allow returning stub with not saved workfile (#4984)
Without it is not possible to create first workile.
2023-05-18 10:59:13 +02:00
Petr Kalis
e7aa413038
AfterEffects: add review flag to each instance (#4884)
* OP-5657 - add artist control for review in AfterEffects

Artist can disable review to be created for particular publish.

* OP-5657 - add artist control for review in AfterEffects

Removed configuration for Deadline, should be controlled by what is on instance.

* OP-5657 - handle legacy instances

Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.

* OP-5657 - remove explicit review for all AE

Now handled directly on instance

* OP-5657 - fix - cannot remove now

Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.

* OP-5657 - fix - correct host name used

* OP-5657 - fix - correct handling of review

On local renders review should be added only from families, not from older approach through Settings.

Farm instance cannot have review in families or extract_review would get triggered even locally.

* OP-5657 - refactor - changed label

* OP-5657 - Hound

* OP-5657 - added explicitly skipping review

Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).

* OP-5657 - updated setting of review variable

instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.

* OP-5657 - fix adding review flag

* OP-5657 - updated test

Removed review for second instance.

* OP-5657 - refactor to context plugin

* OP-5657 - tie thumbnail to review for local render

Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
2023-05-04 12:16:58 +02:00
Thomas Fricard
fcffb91948
After Effects: fix handles KeyError (#4727)
* get handles from context if not in asset

* fix linting errors

* get frameStart, frameEnd, handleStart and handleEnd from context

---------

Co-authored-by: clement hector <clement.hector@fixstudio.com>
Co-authored-by: Thomas Fricard <tfricard@ws114.prs.vfx.int>
2023-04-14 17:39:53 +02:00
Roy Nieterau
3fae1f8521 Just some grammar tweaks 2023-03-30 13:59:22 +02:00
Petr Kalis
b70c6e4bfd OP-4938 - fix obsolete access to instance change 2023-02-15 18:32:56 +01:00
Petr Kalis
0301309502 OP-4928 - removed legacy_io in workfile creator in AE
Legacy_io should be eradicated, replaced by abstracted methods
2023-02-15 12:33:35 +01:00
Petr Kalis
410ea87e18 OP-4928 - fix wrong usage of legacy_io
Import should be removed. Now it should be replaced from context.
2023-02-15 12:27:44 +01:00
Petr Kalis
59010eb9a6 OP-4653 - refactor - move most important method higher 2023-02-03 17:19:02 +01:00
Petr Kalis
31b137fa1d OP-4653 - Hound 2023-02-03 17:17:27 +01:00
Petr Kalis
993145e6f8 OP-4653 - fix wrong name 2023-02-03 17:16:55 +01:00
Petr Kalis
f2930ed156 OP-4653 - updated description in AE creator 2023-02-03 17:04:06 +01:00
Petr Kalis
53c1c842f5 OP-4653 - standardize use_composition_name
Follow more closely login in PS, eg. if {composition} placeholder not present in subset template and should be used, add capitalized.
Clean composition name
2023-02-03 17:02:33 +01:00
Petr Kalis
161e09bcdb OP-4615 - AE - fix missing list_instances 2023-01-17 12:30:59 +01:00
Jakub Trllo
d3753fef31 Merge branch 'develop' into release/3.15.x
# Conflicts:
#	openpype/hosts/aftereffects/api/pipeline.py
#	openpype/hosts/photoshop/api/pipeline.py
#	openpype/hosts/photoshop/plugins/create/create_legacy_image.py
#	openpype/modules/deadline/plugins/publish/submit_publish_job.py
2022-12-16 12:09:01 +01:00
Jakub Trllo
a3db8a0539 use qtpy in hosts which have use openpype process 2022-12-13 17:47:52 +01:00
Petr Kalis
7959bfb958
Merge branch 'release/3.15.x' into feature/OP-3426_Add-support-for-Deadline-for-automatic-tests 2022-12-02 15:35:00 +01:00
Petr Kalis
b0e433e520 OP-4362 - remove unnecessary call to super 2022-11-16 11:24:36 +01:00
Petr Kalis
9a503fce6a OP-4361 - fix wrong usage of regex 2022-11-15 16:49:40 +01:00
Petr Kalis
fb154ad4f1 OP-4361 - implemented multiple output modules per composition
Working version for local rendering.
2022-11-15 16:11:55 +01:00
Petr Kalis
2e1004c618 OP-4361 - rename composition after update, delete 2022-11-15 16:03:45 +01:00
Petr Kalis
702edb0efe OP-4361 - rename composition after create
Previously it was renaming composition with subset name, this was missing in new creator.
Renamed items to more descriptive 'comps'.
2022-11-15 12:17:27 +01:00
Petr Kalis
6a18fa0fda OP-4361 - updated Creator to use composition name
There is new flag to allow use composition name
Updated subset template. Removed obsolete 'renderLocal', now it is only 'render' with a flag.
2022-11-15 12:11:26 +01:00
Petr Kalis
9ba1028e61 OP-4361 - fixed issue in render info
Weird synchronization issue was happening in getRenderInfo when re-publishing published workfile. This implementation is ugly, but seems to work.
2022-11-11 12:53:22 +01:00
Petr Kalis
5f302eb95c OP-4361 - streamline local render
Do not do get render queue again, should be already collected.
2022-11-11 12:20:19 +01:00
Petr Kalis
104fc1fd83 OP-4361 - removed forgotten debug method call 2022-11-10 17:49:35 +01:00
Petr Kalis
7ca8b4ddf4 OP-4361 - addd support for multiple composition in AE
There cannot be multiple Render items for same composition in Render Queue.
There cannot be multiple output modules for same Render item.
2022-11-10 17:36:58 +01:00
Petr Kalis
418135cde0 Merge remote-tracking branch 'origin/release/3.15.x' into feature/OP-3426_Add-support-for-Deadline-for-automatic-tests 2022-11-07 12:40:41 +01:00
Petr Kalis
66bea60bdd OP-3426 - refactor - replaced check of env var with function
It would be better to modify single function if necessary.
2022-11-07 11:40:15 +01:00
Jakub Trllo
26ee6ade64 Merge branch 'develop' into release/3.15.x 2022-11-04 12:51:48 +01:00
Petr Kalis
a48650512e OP-3909 - updated error messages 2022-11-04 11:33:47 +01:00
Petr Kalis
b396a8d76b OP-4371 - fix - wrong call of list_instances 2022-11-04 11:18:50 +01:00
Petr Kalis
5a8876e364 OP-3908 - removed get_context_title
Not necessary to override, same functionality as in HostBase.
2022-11-03 17:24:45 +01:00
Petr Kalis
6c9483c2ad OP-3909 - remove uninstall
Not needed, not used anywhere.
2022-11-03 17:14:12 +01:00
Petr Kalis
fbdb2336d8 OP-3909 - fix wrong host variable 2022-11-03 17:13:15 +01:00
Petr Kalis
8502ea0139 OP-3908 - Hound 2022-11-03 17:12:42 +01:00
Jakub Trllo
12c28fe466 change imports in hosts 2022-11-03 16:27:38 +01:00
Petr Kalis
de5decbcbb OP-3908 - revert back to AE specific cache method
Standard approach doesn't handle legacy instances, eg. instance without creator_identifier.
2022-11-03 13:20:24 +01:00
Petr Kalis
64f8e2fc9c OP-3909 - fix - use values, filtering is later 2022-11-03 12:49:49 +01:00
Petr Kalis
e9834d973d OP-3909 - fix - add internal variable 2022-11-03 12:47:01 +01:00
Petr Kalis
ab4ed37604 OP-3909 - fix - use family to filter instances
cached instances are dictionary where keys are creator identifier, eg family.
2022-11-03 12:15:22 +01:00
Petr Kalis
adb683bdfc OP-3909 - use caching function from creator
In between cache function was extracted into creator_plugins, use this to standardize betwen different hosts.
2022-11-03 10:46:20 +01:00
Petr Kalis
f78bd11977 OP-3909 - added caching of list_instances
list_instances could be expensive in larger workfiles, it makes sense to cache it for all creator, but only for collecting phase. (This is why creator.collection_shared_data is used.)
2022-11-03 10:26:53 +01:00
Petr Kalis
414afab0c0 OP-3909 - Hound 2022-11-02 19:11:34 +01:00
Petr Kalis
e44da54da8 OP-3909 - remove legacy creators 2022-11-02 19:01:51 +01:00
Petr Kalis
9c880d9b15 OP-3909 - added missed interface 2022-11-02 19:01:27 +01:00
Petr Kalis
b52a2eef1f OP-3909 - remove initialization of AfterEffectsHost
Initialization might be expensive, use self.host instead.
2022-11-02 19:00:24 +01:00
Petr Kalis
64148737ff OP-3909 - fix usage of internal variable 2022-11-01 17:46:40 +01:00
Petr Kalis
0f39c4d0d7 OP-3909 - refactor - remove subsetmanager route
Replaced by Publisher
2022-11-01 16:48:56 +01:00
Petr Kalis
39b2945e09 OP-3909 - refactor - move get_asset_settings to lib
It makes more sense there than in pipeline.py
2022-11-01 16:44:28 +01:00