Commit graph

103 commits

Author SHA1 Message Date
Jakub Jezek
30800c1c2c
Refactor transcoding and thumbnail extraction code
- Removed the unused `additional_input_args` parameter from the `convert_colorspace` function in `transcoding.py`
- Renamed the `additional_input_args` parameter to `additional_command_args` in the `ExtractThumbnail` class in `extract_thumbnail.py`

These changes improve code clarity and remove unnecessary parameters.
2023-12-07 15:06:20 +01:00
Jakub Jezek
4229461755
hound 2023-12-06 21:05:32 +01:00
Jakub Jezek
206e1d94eb
removing duplicity of get_oiio_input_and_channel_args 2023-12-06 16:04:47 +01:00
Jakub Jezek
6be699bb82
Merge branch 'develop' into enhancement/OP-6659_extract-thumbnails-settings-size-frame 2023-12-06 15:53:23 +01:00
Jakub Jezek
54205db222
Refactor transcoding.py to fix sample aspect ratio parsing
The code change fixes an issue in the transcoding.py file where the sample aspect ratio was not being parsed correctly. The fix involves modifying the way the sample aspect ratio is accessed from the stream object.
2023-12-06 15:24:19 +01:00
Jakub Jezek
8cf109340b
rising amount of colors so it matches input of 8bits
https://github.com/ynput/OpenPype/pull/5944#discussion_r1404641936
2023-11-27 16:03:09 +01:00
Jakub Jezek
6b02f779b3
improving readability of code
https://github.com/ynput/OpenPype/pull/5944#discussion_r1404643069
2023-11-27 16:00:16 +01:00
Jakub Jezek
069977b327
improving rescale functionality 2023-11-24 21:35:06 +01:00
Jakub Jezek
09b3646bec
rescaling wip 2023-11-24 14:37:21 +01:00
Jakub Jezek
50c37b7e11
typos and code style 2023-11-21 17:05:06 +01:00
Jakub Jezek
d3de3fc295
removing input arguments 2023-11-21 17:04:35 +01:00
Jakub Jezek
fc900780cd
typo 2023-10-17 17:33:38 +02:00
Jakub Jezek
4113655725
updating pr changes to latest changes 2023-10-17 17:19:58 +02:00
Jakub Jezek
ea5bf33c1c
Merge branch 'develop' into bugfix/extract_thumbnail_oiio 2023-10-17 16:43:39 +02:00
Jakub Trllo
93fb76f359
Extract Review: Multilayer specification for ffmpeg (#5613)
* added function to extract more information about channels

* specify layer name which should be used for ffmpeg

* changed 'get_channels_info_by_layer_name' to 'get_review_info_by_layer_name'

* modify docstring

* fix dosctring again
2023-09-14 13:55:25 +02:00
Roy Nieterau
3a02964af5 Do not show debug log about ffmpeg probe in artist-facing report 2023-09-07 15:58:28 +02:00
Jakub Trllo
d63aa34a76
AYON: 3rd party addon usage (#5300)
* implemented helper functions to get ffmpeg and oiio tool arguments

* modified validation functions to be able to handle list of arguments

* path getters can return a path in AYON mode if one argument is returned

* removed test exception

* modified docstrings

* is_oiio_supported is using new functions to get launch arguments

* new functions are in lib public =

* use new functions all over the place

* renamed 'ffmpeg_path' to 'ffmpeg_args'

* raise 'ToolNotFoundError' if tool argument could not be found

* reraise 'KnownPublishError' in publish plugins

* fix comment

* simplify args start

* ffmpeg and oiio function require tool name and support additional arguments

* renamed 'get_oiio_tools_args' to 'get_oiio_tool_args'

* fix variable name
2023-07-27 10:54:45 +02:00
Toke Stuart Jepsen
f814db2ce0 Use colorspace data when creating thumbnail. 2023-07-06 10:45:00 +01:00
Jakub Jezek
fbb6afe5c3
adding psd to IMAGE_EXTENSIONS constant 2023-06-06 17:17:42 +02:00
Roy Nieterau
3fae1f8521 Just some grammar tweaks 2023-03-30 13:59:22 +02:00
Petr Kalis
be6a22b485 Fix - newline 2023-02-23 16:42:48 +01:00
Petr Kalis
72a3572d95 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 16:35:42 +01:00
Petr Kalis
945f1dfe55 OP-4643 - added explicit enum for transcoding type
As transcoding info (colorspace, display) might be collected from DCC, it must be explicit which should be used.
2023-02-23 15:39:55 +01:00
Petr Kalis
5678bdbf06 OP-4643 - different splitting for oiio
It seems that logic in ExtractReview does different thing.
2023-02-23 15:39:55 +01:00
Petr Kalis
559d54c3a1 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 15:39:55 +01:00
Petr Kalis
984974d7e0 OP-4643 - split command line arguments to separate items
Reuse existing method from ExtractReview, put it into transcoding.py
2023-02-23 15:39:54 +01:00
Petr Kalis
3921982365 OP-4642 - added additional command arguments for oiiotool
Some extension requires special command line arguments (.dpx and binary depth).
2023-02-23 15:39:54 +01:00
Petr Kalis
925c7a9564 OP-4643 - updated docstring for convert_colorspace 2023-02-23 15:39:53 +01:00
Petr Kalis
016111ab33 OP-4643 - changed docstring
Elaborated more that 'target_colorspace' and ('view', 'display') are disjunctive.
2023-02-23 15:39:53 +01:00
Petr Kalis
97a2014c12 OP-4643 - moved output argument to the end 2023-02-23 15:39:53 +01:00
Petr Kalis
7e9d707226 OP-4643 - updated docstring, standardized arguments 2023-02-23 15:39:52 +01:00
Petr Kalis
be176bbeb2 OP-4643 - implemented display and viewer color space 2023-02-23 15:39:52 +01:00
Petr Kalis
83d21d9d77 OP-4643 - changed oiio_cmd creation
Co-authored-by: Toke Jepsen <tokejepsen@gmail.com>
2023-02-23 15:39:52 +01:00
Petr Kalis
9fc4070e06 OP-4643 - refactored according to review
Function turned into single filepath input.
2023-02-23 15:39:51 +01:00
Petr Kalis
ec299f0d3c OP-4643 - pass path for ocio config 2023-02-23 15:39:51 +01:00
Petr Kalis
2f1888bbfb OP-4643 - added ExtractColorTranscode
Added method to convert from one colorspace to another to transcoding lib
2023-02-23 15:39:50 +01:00
Petr Kalis
6cb8cbd6fc OP-4643 - added explicit enum for transcoding type
As transcoding info (colorspace, display) might be collected from DCC, it must be explicit which should be used.
2023-02-23 15:36:03 +01:00
Petr Kalis
840f681134 OP-4643 - different splitting for oiio
It seems that logic in ExtractReview does different thing.
2023-02-23 15:36:03 +01:00
Petr Kalis
94ee028792 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 15:36:03 +01:00
Petr Kalis
b304d63461 OP-4643 - split command line arguments to separate items
Reuse existing method from ExtractReview, put it into transcoding.py
2023-02-23 15:36:02 +01:00
Petr Kalis
b1d30058b0 OP-4642 - added additional command arguments for oiiotool
Some extension requires special command line arguments (.dpx and binary depth).
2023-02-23 15:36:01 +01:00
Petr Kalis
7eacd1f30f OP-4643 - updated docstring for convert_colorspace 2023-02-23 15:36:00 +01:00
Petr Kalis
190a79a836 OP-4643 - changed docstring
Elaborated more that 'target_colorspace' and ('view', 'display') are disjunctive.
2023-02-23 15:36:00 +01:00
Petr Kalis
8598c1ec39 OP-4643 - moved output argument to the end 2023-02-23 15:36:00 +01:00
Petr Kalis
176f53117f OP-4643 - updated docstring, standardized arguments 2023-02-23 15:35:59 +01:00
Petr Kalis
382074b54c OP-4643 - implemented display and viewer color space 2023-02-23 15:35:59 +01:00
Petr Kalis
756661f71b OP-4643 - changed oiio_cmd creation
Co-authored-by: Toke Jepsen <tokejepsen@gmail.com>
2023-02-23 15:35:59 +01:00
Petr Kalis
5a562dc821 OP-4643 - refactored according to review
Function turned into single filepath input.
2023-02-23 15:35:58 +01:00
Petr Kalis
52a5865341 OP-4643 - pass path for ocio config 2023-02-23 15:35:57 +01:00
Petr Kalis
8a67065fce OP-4643 - added ExtractColorTranscode
Added method to convert from one colorspace to another to transcoding lib
2023-02-23 15:35:57 +01:00