Commit graph

1494 commits

Author SHA1 Message Date
Jakub Jezek
c4570200ff
Refactor code to handle missing "representations" key in instance data
The code change modifies the `ExtractThumbnail` class in `extract_thumbnail.py`. It updates the loop that iterates over representations to handle cases where the "representations" key is missing from the instance data. This change ensures that cleanup occurs for representations with both "delete" and "need_thumbnail" tags.
2023-12-07 22:08:19 +01:00
Jakub Jezek
bb5d48eae1
Refactor code to skip instance creation for new assets
- Removed the check for `newAssetPublishing` in `CollectResourcesPath.process()`
- This change allows instances to be processed even if they are creating new assets
2023-12-07 16:48:43 +01:00
Jakub Jezek
3ec7f9149f
Add thumbnail path to instance data and integrate thumbnails in Ayon plugin.
- Added code to add the thumbnail path to the instance data.
- Modified code to retrieve the thumbnail path from the instance data in Ayon plugin.
- Updated code to handle cases where the thumbnail source is not available or specified.
- Improved logic for finding the thumbnail representation in published representations.
2023-12-07 15:28:07 +01:00
Jakub Jezek
30800c1c2c
Refactor transcoding and thumbnail extraction code
- Removed the unused `additional_input_args` parameter from the `convert_colorspace` function in `transcoding.py`
- Renamed the `additional_input_args` parameter to `additional_command_args` in the `ExtractThumbnail` class in `extract_thumbnail.py`

These changes improve code clarity and remove unnecessary parameters.
2023-12-07 15:06:20 +01:00
Jakub Jezek
d5c5f4f9aa
Merge branch 'develop' into enhancement/OP-6659_nuke-explicit-thumbnail-workflow 2023-12-07 13:15:07 +01:00
Jakub Jezek
cdbf764a85
improving comments 2023-12-07 11:13:22 +01:00
Jakub Jezek
f31cfe9cf5
Refactor code to use deep copy for repre_files_thumb variable 2023-12-06 22:51:28 +01:00
Jakub Jezek
4229461755
hound 2023-12-06 21:05:32 +01:00
Jakub Jezek
25ea0a76e5
Merge branch 'develop' into enhancement/OP-6659_extract-thumbnails-settings-size-frame 2023-12-06 21:01:50 +01:00
Jakub Jezek
6be699bb82
Merge branch 'develop' into enhancement/OP-6659_extract-thumbnails-settings-size-frame 2023-12-06 15:53:23 +01:00
Ondřej Samohel
610ed75aaf 🗑️ remove simple unreal texture publishing 2023-12-06 12:02:50 +01:00
Libor Batek
e14688910d
Merge branch 'develop' into enhancement/use_manual_thumbnail_when_publishing 2023-11-30 09:22:55 +01:00
Jakub Ježek
ced3e1ecc2
Merge pull request #5938 from ynput/enhancement/OP-6659_thumbnail-color-managed
General: Use colorspace data when creating thumbnail
2023-11-29 21:25:58 +01:00
Jakub Trllo
955a6e2253 make sure single entity id changes thumbnail id only once in operations 2023-11-29 16:48:22 +01:00
Simone Barbieri
f899191fb1 Use manual thumbnail if present when publishing 2023-11-29 14:38:39 +01:00
Jakub Ježek
7146b7b784
Update openpype/plugins/publish/extract_thumbnail.py 2023-11-27 16:42:31 +01:00
Jakub Ježek
ddfb95467e
Update openpype/plugins/publish/extract_thumbnail.py
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-11-27 16:39:34 +01:00
Jakub Jezek
cd8451e811
adding reformating to oiiotool process
- removing it from wrong ffmpeg process
2023-11-24 22:04:11 +01:00
Jakub Jezek
069977b327
improving rescale functionality 2023-11-24 21:35:06 +01:00
Jakub Jezek
09b3646bec
rescaling wip 2023-11-24 14:37:21 +01:00
Jakub Jezek
3833819557
inverting bugged condition 2023-11-23 10:10:08 +01:00
Jakub Jezek
e51ddf8682
fixing situation where display and view are in representation 2023-11-22 17:10:13 +01:00
Libor Batek
7aa80f2657
Merge branch 'develop' into enhancement/OP-6659_thumbnail-color-managed 2023-11-22 16:41:02 +01:00
Jakub Jezek
2aea1cd8fc
avoid situation where missing outputName
this might happen if only one Intermediate reviewable file stream is used.
2023-11-22 14:52:11 +01:00
Jakub Jezek
24abe0e0f3
comments from https://github.com/ynput/OpenPype/pull/5936 2023-11-22 12:16:02 +01:00
Jakub Jezek
835f50e57c
global: adding settings for target size and frame picking 2023-11-22 12:13:36 +01:00
Jakub Jezek
b8838d70cf
ignoring publish_on_farm representations
it was creating thumbnails in Ftrack even the version had to be created in future
2023-11-21 21:55:48 +01:00
Jakub Jezek
93b5a3941d
adding nuke host into extract thumbnail plugin 2023-11-21 21:43:16 +01:00
Jakub Jezek
2f78943791
improving code coment 2023-11-21 17:33:55 +01:00
Jakub Jezek
8914ea0da9
return True if successful oiio conversion 2023-11-21 17:09:23 +01:00
Jakub Jezek
d3de3fc295
removing input arguments 2023-11-21 17:04:35 +01:00
Jakub Jezek
f435408018
typo 2023-11-21 15:41:21 +01:00
Jakub Jezek
7aacc4f0ec
global: extract review with need_thumbnail tag explicit source 2023-11-21 15:40:14 +01:00
Jakub Jezek
5432c2fa69
Global: adding need_thumbnail tag worklfow
extract review and extract review slate
2023-11-21 15:25:22 +01:00
Jakub Trllo
a31214d2c4 use 'newAssetPublishing' instead of 'isEditorial' 2023-11-21 11:05:55 +01:00
Jakub Jezek
97c10d2555
adding oiio defaults from settings 2023-11-20 21:45:46 +01:00
Jakub Ježek
477bc613e2
Hiero | Global: editorial with folder path (#5829)
* hiero: adding folderPath to creator

- some minor typos fixes
- modules sorting

* Hiero: adding asset_name and processing folderPath

- refactor labels

* fixing extract hierarchy to ayon

* hound

* Update openpype/hosts/hiero/api/plugin.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* simplify expression

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-11-20 18:28:18 +01:00
Jakub Trllo
40a1dbed3e Merge branch 'develop' into feature/OP-7176_Use-folder-path-as-unique-identifier
# Conflicts:
#	openpype/hosts/blender/plugins/publish/extract_abc.py
#	openpype/hosts/blender/plugins/publish/extract_abc_animation.py
#	openpype/hosts/blender/plugins/publish/extract_blend.py
#	openpype/hosts/blender/plugins/publish/extract_blend_animation.py
#	openpype/hosts/blender/plugins/publish/extract_camera_abc.py
#	openpype/hosts/blender/plugins/publish/extract_camera_fbx.py
#	openpype/hosts/blender/plugins/publish/extract_fbx.py
#	openpype/hosts/blender/plugins/publish/extract_fbx_animation.py
#	openpype/hosts/blender/plugins/publish/extract_layout.py
2023-11-15 18:26:48 +01:00
Jakub Jezek
b3b890c109
Merge branch 'develop' into bugfix/extract_thumbnail_oiio 2023-11-15 18:24:44 +01:00
Roy Nieterau
9a6cacee4e
Merge branch 'develop' into enhancement/blender_new_publisher 2023-11-15 14:04:40 +01:00
Jakub Trllo
58fd1aa8e2 Merge branch 'develop' into feature/OP-7176_Use-folder-path-as-unique-identifier 2023-11-15 11:33:20 +01:00
Jakub Ježek
424ef2b133
Merge branch 'develop' into bugfix/editorial_publishing_failed_validator 2023-11-15 10:23:26 +01:00
Roy Nieterau
91e230a321
Enhancement: Some publish logs cosmetics (#5917)
* Write logs in sorted order for better logs

* Typo in log message

* More descriptive log

* Skip logging profile since `filter_profiles` already logs "Profile selected: {profile}"

* Fix grammar

* Fix grammar

* Improve logged information
2023-11-15 10:09:37 +01:00
Roy Nieterau
871bf194da Avoid double space in log message 2023-11-14 00:36:33 +01:00
Jakub Trllo
a28d6d34d2 Merge branch 'develop' into feature/OP-7176_Use-folder-path-as-unique-identifier
# Conflicts:
#	openpype/client/server/entities.py
#	openpype/pipeline/context_tools.py
2023-11-13 16:39:09 +01:00
Jakub Ježek
cfbf257763
Merge branch 'develop' into bugfix/extract_thumbnail_oiio 2023-11-13 13:25:43 +01:00
Kayla Man
c0fbe2c091 Merge branch 'develop' into enhancement/3dsmax_review_render_ratio_and_viewport_tweaks 2023-11-09 21:21:37 +08:00
Jakub Jezek
eda0afc260
traypublisher: adding exceptions for editorial instances 2023-11-08 14:27:47 +01:00
Jakub Trllo
fc8342751d Merge branch 'develop' into feature/OP-7176_Use-folder-path-as-unique-identifier 2023-11-07 17:40:40 +01:00
Toke Jepsen
f7d76617c0
Testing: Validate Maya Logs (#5775)
* Working version

* Improve launched app communication

* Move imports to methods.

* Update tests/integration/hosts/maya/test_publish_in_maya.py

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

* Collect errors from process

* fix startup scripts arguments

* Update openpype/lib/applications.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Fix application polling

* Docstring

* Revert stdout and stderr

* Revert subprocess.PIPE

* Added missed imports

If we are moving these because of testing, lets move all of them

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: kalisp <petr.kalis@gmail.com>
2023-11-07 16:51:54 +01:00