Commit graph

6599 commits

Author SHA1 Message Date
Petr Kalis
b8ce6e9e9c
Photoshop: add autocreators for review and flat image (#4871)
* OP-5656 - added auto creator for review in PS

Review instance should be togglable.
Review instance needs to be created for non publisher based workflows.

* OP-5656 - refactored names

* OP-5656 - refactored names

* OP-5656 - new auto creator for flat image

In old version flat image was created if no instances were created. Explicit auto creator added for clarity.

Standardization of state of plugins

* OP-5656 - updated according to auto image creator

Subset template should be used from autocreator and not be separate.

* OP-5656 - fix proper creator name

* OP-5656 - fix log message

* OP-5656 - fix use enable state

* OP-5656 - fix formatting

* OP-5656 - add review toggle to image instance

For special cases where each image should have separate review.

* OP-5656 - fix description

* OP-5656 - fix not present asset and task in instance context

* OP-5656 - refactor - both auto creators should use same class

Provided separate description.

* OP-5656 - fix - propagate review to families

Image and auto image could have now review flag.
Bottom logic is only for Webpublisher.

* OP-5656 - fix - rename review files to avaid collision

Image family produces jpg and png, jpg review would clash with name. It should be replaced by 'jpg_jpg'.

* OP-5656 - fix - limit additional auto created only on WP

In artist based publishing auto image would be created by auto creator (if enabled). Artist might want to disable image creation.

* OP-5656 - added mark_for_review flag to Publish tab

* OP-5656 - fixes for auto creator

* OP-5656 - fixe - outputDef not needed

outputDef should contain dict of output definition. In PS it doesn't make sense as it has separate extract_review without output definitions.

* OP-5656 - added persistency of changes to auto creators

Changes as enabling/disabling, changing review flag should persist.

* OP-5656 - added documentation for admins

* OP-5656 - added link to new documentation for admins

* OP-5656 - Hound

* OP-5656 - Hound

* OP-5656 - fix shared families list

* OP-5656 - added default variant for review and workfile creator

For workfile Main was default variant, "" was for review.

* OP-5656 - fix - use values from Settings

* OP-5656 - fix - use original name of review for main review family

outputName cannot be in repre or file would have ..._jpg.jpg

* OP-5656 - refactor - standardized settings

Active by default denotes if created instance is active (eg. publishable) when created.

* OP-5656 - fixes for skipping collecting auto_image

data["ids"] are necessary for extracting. Members are physical layers in image, ids are "virtual" items, won't get grouped into real image instance.

* OP-5656 - reworked auto collectors

This allows to use automatic test for proper testing.

* OP-5656 - added automatic tests

* OP-5656 - fixes for auto collectors

* OP-5656 - removed unnecessary collector

Logic moved to auto collectors.

* OP-5656 - Hound
2023-05-02 11:19:50 +02:00
Roy Nieterau
5595762164
Fusion: Simplify creator icons code (#4899)
* Simplify setting creator icons

* Use font-awesome 5 explicitly
2023-04-24 17:47:33 +02:00
Ondrej Samohel
60d386b127
🐛 fix missing review flag on instance with pre-render 2023-04-24 12:53:17 +02:00
Ondřej Samohel
20c0745bd8
Merge branch 'develop' into enhancement/unreal-rendering_settings 2023-04-24 12:40:31 +02:00
Ondrej Samohel
7d7206953c
Merge branch 'develop' into enhancement/unreal-render_creator_improvements 2023-04-24 12:38:07 +02:00
Roy Nieterau
cf7e704964
Collect currentFile context data separate from workfile instance (#4883) 2023-04-21 18:43:01 +02:00
Ondřej Samohel
aa3a5134eb
Merge pull request #4878 from ynput/bugfix/OP-5761_look-publishing-texture-hash 2023-04-21 15:32:25 +02:00
Jakub Trllo
34b1ad105b
implemented collector for review instances to fix extract review issues (#4891) 2023-04-21 15:18:41 +02:00
Kayla Man
5b1854e902
Add fps as instance.data in collect review in Houdini. (#4888)
* add fps as instance data in collect review data

* Trllo's feedback
2023-04-21 12:17:01 +02:00
Jakub Trllo
843fd5f1b9
Nuke: Legacy convertor skips deprecation warnings (#4846)
* convert legacy checks for AVALON_TAB to avoid deprecation warnings

* simplify 'get_avalon_knob_data'
2023-04-21 11:31:52 +02:00
Ondřej Samohel
6b19c8c7e1
Merge branch 'develop' into enhancement/maya_hide_animation_creator 2023-04-20 16:28:15 +02:00
Ondřej Samohel
b7b9225252
Merge branch 'develop' into enhancement/houdini_loaders_implement_switch 2023-04-20 16:05:15 +02:00
Roy Nieterau
c90c55edd9
Merge branch 'develop' into enhancement/maya_hide_animation_creator 2023-04-20 14:03:50 +02:00
Ondrej Samohel
a8e5a0c5fc
🎨 calculate hash for tx texture 2023-04-20 12:10:55 +02:00
Milan Kolar
90c71334f7
Merge pull request #4856 from BigRoy/enhancement/maya_arnold_standin_look_abc 2023-04-20 10:08:13 +02:00
Roy Nieterau
5b7d419e18 Cosmetics 2023-04-19 18:07:08 +02:00
Roy Nieterau
fbc0430bb2 Tweak color + icon 2023-04-19 18:06:25 +02:00
Roy Nieterau
1a10e0fc74 Hide animation instance in creator + add inventory action to recreate animation publish instance for loaded rigs 2023-04-19 18:01:43 +02:00
Roy Nieterau
839377696b Implement switch method on loaders 2023-04-19 15:29:20 +02:00
Milan Kolar
56d9334c5d
Merge pull request #4858 from BigRoy/bugfix/maya_get_framerange_keep_timeslider
thank you for quick action.
2023-04-19 10:52:40 +02:00
Roy Nieterau
0ad5442cd4
Update openpype/hosts/maya/api/lib.py 2023-04-19 10:52:04 +02:00
Milan Kolar
59220366e2
Merge pull request #4849 from ynput/bugfix/OP-5668_3dsmax-pre-launch-hook 2023-04-19 09:59:46 +02:00
Roy Nieterau
8c1abf2b5b Allow potential case that frame range might not be defined on an asset.
- Warning will still be printed from `get_frame_range` function
2023-04-18 22:30:02 +02:00
Roy Nieterau
dec2521c05 Do not change time slider ranges in get_frame_range function 2023-04-18 22:29:04 +02:00
Milan Kolar
018d324409
Merge pull request #4852 from tokejepsen/bugfix/maya_nested_model_instance
Maya: Fix nested model instances.
2023-04-18 22:02:47 +02:00
Roy Nieterau
b8e69a5b01 Support .abc files directly for Arnold standin look assignment 2023-04-18 15:21:08 +02:00
Toke Stuart Jepsen
38cc309d43 Fix #4851 2023-04-18 11:34:35 +01:00
Toke Stuart Jepsen
9d8ed55ea5 Fix nested model instances. 2023-04-18 11:07:07 +01:00
Roy Nieterau
b05afaa837
Global: Optimize anatomy formatting by only formatting used templates instead (#4784)
* TemplatesDict can create different type of template

* anatomy templates can be formatted on their own

* return objected templates on get item

* '_rootless_path' is public classmethod 'rootless_path_from_result'

* 'AnatomyStringTemplate' expect anatomy templates

* remove key getters

* fix typo 'create_ojected_templates' -> 'create_objected_templates'

* Fix type of argument

* Fix long line

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Use format strict + code cosmetics

* Get template from the formatted data

* Update openpype/plugins/publish/integrate_legacy.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Cosmetics

* Move template obj definition for path up + rename to `path_template_obj`

* Refactor more cases from `anatomy.format` to template obj `.format_strict`

* Refactor more cases from `anatomy.format` to template obj `.format_strict`

* Refactor more cases from `anatomy.format` to template obj `.format_strict`

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-04-17 14:53:15 +02:00
Ondrej Samohel
ef55dd932d
🎨 move startup script logic to hook 2023-04-17 13:00:01 +02:00
Ondřej Samohel
892e469217
Merge branch 'develop' into enhancement/OP-3807_playblast_profiles 2023-04-14 17:57:09 +02:00
Thomas Fricard
fcffb91948
After Effects: fix handles KeyError (#4727)
* get handles from context if not in asset

* fix linting errors

* get frameStart, frameEnd, handleStart and handleEnd from context

---------

Co-authored-by: clement hector <clement.hector@fixstudio.com>
Co-authored-by: Thomas Fricard <tfricard@ws114.prs.vfx.int>
2023-04-14 17:39:53 +02:00
Toke Stuart Jepsen
281f6186e4 Merge branch 'develop' into enhancement/OP-3807_playblast_profiles
# Conflicts:
#	openpype/hosts/maya/plugins/create/create_review.py
2023-04-14 15:09:44 +01:00
Milan Kolar
158626ffbf
Merge pull request #4714 from tokejepsen/feature/OP-4994_defining-plugins-to-load-on-Maya-start 2023-04-14 15:11:27 +02:00
Milan Kolar
22b0a894e6
Merge pull request #4707 from tokejepsen/bugfix/xgen_fixes 2023-04-14 15:10:43 +02:00
Milan Kolar
708cba0d04
Merge pull request #4145 from tokejepsen/enhancement/maya_review 2023-04-14 14:56:44 +02:00
Toke Jepsen
2ee9c17270
Update openpype/hosts/maya/api/lib.py 2023-04-14 12:28:26 +01:00
Toke Jepsen
119df6d24e
Update openpype/hosts/maya/api/lib.py 2023-04-14 08:39:42 +01:00
Toke Jepsen
a061c89779
Update openpype/hosts/maya/api/lib.py 2023-04-14 08:38:18 +01:00
Milan Kolar
6a992b8ec3
Merge pull request #4840 from BigRoy/enhancement/maya_animation_single_assembly_validation
Great!
2023-04-13 22:37:10 +02:00
Milan Kolar
0be80d3cd0
Merge pull request #4778 from ynput/bugfix/OP-5542
thanks folks
2023-04-13 22:35:12 +02:00
Milan Kolar
d1b59c4aaa
Merge pull request #4761 from quadproduction/363-fix-studio-openpype-does-not-load-assets-linked-to-the-shot
thank you guys. this is great
2023-04-13 22:31:41 +02:00
Jakub Trllo
9a5f86ea1b
add review tag to output of extract sequence if instance is marked for review (#4843) 2023-04-13 18:42:50 +02:00
Toke Stuart Jepsen
9a96a6b2e0 KnownPublishError > PublishValidationError 2023-04-13 16:47:19 +01:00
Jakub Trllo
ce18ab98b9
TrayPublisher: Move 'BatchMovieCreator' settings to 'create' subcategory (#4827)
* move 'BatchMovieCreator' settings to 'create' subcategory

* change label of simple creators

* added label to create plugins
2023-04-13 16:42:05 +02:00
Roy Nieterau
55ccf73ebb Remove single assembly validation for animation instances 2023-04-13 13:31:16 +02:00
Toke Stuart Jepsen
4f79d7fab2 Merge branch 'develop' into enhancement/OP-3807_playblast_profiles
# Conflicts:
#	openpype/hosts/maya/api/lib.py
2023-04-13 11:40:02 +01:00
Ondřej Samohel
84cc7e12cc
Merge branch 'develop' into bugfix/OP-3951_Deadline-checking-existing-frames-fails-when-there-is-number-in-file-name 2023-04-13 12:35:26 +02:00
Ondřej Samohel
5feb9124e7
Merge branch 'develop' into enhancement/unreal-use-common-settings-for-executable 2023-04-13 12:10:57 +02:00
Ondřej Samohel
28b7d6a85f
Merge branch 'develop' into bugfix/3dsmax_render_fails_publish_job 2023-04-13 12:10:04 +02:00