Commit graph

95 commits

Author SHA1 Message Date
Roy Nieterau
ba6dfc5ead Remove unused variables + tweak logs 2023-09-06 23:28:39 +02:00
Jakub Trllo
cb3e83118b maya create plugins do not expecte system settings 2023-09-01 17:14:39 +02:00
Petr Kalis
c5d882c7ea
Maya: Fix wrong subset name of render family in deadline (#5442)
* Use existing subset_name as group_name by default

New publisher already carries real subset name (`renderModelingMain`), it should build group name only if subset_name is weird.

* Let legacy conversion of render instance recreate subset_name

Without it would create subset names like `renderingMain` which are not matching to newly created `renderMain` instances. This would cause issue in version restarts.

* Let Render Creator for Maya create proper subset_name

It was using hardcoded logic not matching other DCCs.

* Hound

* Fix method calls

* Fix typos

* Do not import unnecessary

* Capitalize is wrong function for here

* Overwrite get_subset_name for standardized results

It makes sense to override this method for other parts of code getting same results.

* Force change

It seems that GH doesn't recognize changes with adding()

* Update openpype/hosts/maya/plugins/create/convert_legacy.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Hound

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-08-17 10:33:52 +02:00
Petr Kalis
8b128d91bc
Maya: allow not creation of group for Import loaders (#5427)
* OP-6357 - removed unneeded import

* OP-6357 - extracted logic for getting custom group and namespace from Settings

Mimicing logic in ReferenceLoader, eg. group could be left empty >> no groupping of imported subset.

* OP-6357 - same logic for abc animation as Reference

* OP-6357 - same logic for yeti rig as ReferenceLoder

Allows to not create wrapping group.

* OP-6357 - added separate import_loader to settings

Could be used to not creating wrapping groups when Group kept empty.

* OP-6357 - added product subset conversion for ayon settings

* OP-6357 - fix using correct variable

Artist input comes from `data` not directly from self.options

* OP-6357 - add attach_to_root to options to allow control by same key

* OP-6357 - added docstring

* Added settings for Import loaders in maya

* OP-6357 - refactored formatting
2023-08-11 16:12:05 +02:00
Petr Kalis
7d40debd64
Maya: do not create top level group on reference (#5402)
* OP-6358 - allow not creation of group for reference loader in Maya

Creation of wrapping group could be controlled by checkbox in ReferenceLoader options.

* OP-6358 - group name could be empty in Settings

This enables default behavior of not creating wrapping group without need of artists unchecking `Group imported assets`.

* OP-6358 - changed to safer logic

Stripping of | was weird and potentially dangerous (collision of names), this logic should be safer.
2023-08-08 11:00:02 +02:00
Jakub Trllo
ae3eb37776
AYON: Add folder to template data (#5417)
* added 'folder[name]' to template data

* removed asset <-> folder conversion from conversion utils

* use folder[name] in maya namespace
2023-08-07 17:22:28 +02:00
Jakub Trllo
6196ded1a9
Chore: Python 2 support fix (#5375)
* remove f-string formatting

* added python 2 compatible click into python 2 vendor
2023-08-01 10:46:59 +02:00
Milan Kolar
93260948bf
Merge pull request #5297 from tokejepsen/bugfix/maya_include_disabled_plugins 2023-07-27 09:55:53 +02:00
Milan Kolar
0b58144f2c
Merge pull request #5303 from tokejepsen/bugfix/maya_creators_apply_settings 2023-07-27 09:14:43 +02:00
Toke Stuart Jepsen
70f97b2738 Fix get_pre_create_attr_defs query 2023-07-22 09:24:21 +01:00
Toke Stuart Jepsen
484108cb81 Fix MayaHiddenCreator 2023-07-21 14:59:56 +01:00
Jakub Trllo
464e621880 implemented base classes of auto creator and hidden creator for maya 2023-07-20 15:53:00 +02:00
Jakub Trllo
8c73d22d27 extracted common logic to 'MayaCreatorBase' 2023-07-20 15:51:12 +02:00
Toke Stuart Jepsen
16a9e707d8 Apply project settings to creators 2023-07-14 11:34:42 +01:00
Roy Nieterau
f58994d59c Loader: Remove context argument from Loader.__init__() (#4602)
* Remove Loader `context` argument to __init__

* Add backwards compatibility for Loader.load by still setting `.fname` attr

* Refactor/remove usage of `self.fname` in loaders

* Fix some refactoring

* Fix some refactoring

* Hound

* Revert invalid refactor

* Fix refactor

* Fix playblast panel collection

* Refactor missing method

* Fix typo

* Use the correct `context`

---------

Co-authored-by: Toke Stuart Jepsen <tokejepsen@gmail.com>
Co-authored-by: Kayla Man <64118225+moonyuet@users.noreply.github.com>
Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
2023-07-11 17:48:33 +02:00
Ondrej Samohel
92d18eb970
🔀 Merge remote-tracking branch 'origin/develop' into maya_new_publisher 2023-07-11 15:58:18 +02:00
Roy Nieterau
c14255da22 Remove unused import 2023-06-30 23:21:33 +02:00
Ondrej Samohel
4b12f49dd6
🔀 Merge remote-tracking branch 'origin/develop' into maya_new_publisher 2023-06-30 14:24:33 +02:00
Roy Nieterau
67f012e441 Fix typo + cosmetics 2023-06-12 16:03:26 +02:00
Roy Nieterau
c940b82fb9 Merge branch 'develop' of https://github.com/pypeclub/OpenPype into enhancement/maya_template
# Conflicts:
#	openpype/hosts/maya/api/lib.py
2023-06-12 15:46:13 +02:00
Roy Nieterau
dfaad2d1df Allow conversion from legacy renderlayer singleton instances 2023-05-30 20:08:54 +02:00
Jakub Trllo
9e9a9bd5e6 Merge branch 'develop' into maya_new_publisher
# Conflicts:
#	openpype/hosts/maya/api/lib.py
#	openpype/plugins/publish/collect_scene_version.py
2023-05-26 12:36:03 +02:00
Toke Stuart Jepsen
544c043ece Merge branch 'develop' into maya_new_publisher
# Conflicts:
#	openpype/hosts/maya/api/lib.py
#	openpype/hosts/maya/api/plugin.py
#	openpype/hosts/maya/plugins/create/create_animation.py
#	openpype/hosts/maya/plugins/create/create_review.py
#	openpype/hosts/maya/plugins/load/load_reference.py
#	openpype/modules/deadline/plugins/publish/submit_maya_deadline.py
2023-05-16 10:23:11 +01:00
Seyedmohammadreza Hashemizadeh
8ffe7f5552 fix function call 2023-05-15 16:27:03 +02:00
Seyedmohammadreza Hashemizadeh
2514709977 use custom namespace for animation instance 2023-05-15 15:46:20 +02:00
Toke Stuart Jepsen
f6c32300c2 Log warning when using plugin methods. 2023-04-21 10:32:26 +01:00
Toke Stuart Jepsen
b253e4366d Remove methods from plugin.py 2023-04-20 09:07:47 +01:00
Thomas Fricard
265fec770b add docstrings for get_custom_namespace function 2023-04-07 15:15:53 +02:00
Thomas Fricard
163e01542c create get_custom_namespace function to control the position of the unique index 2023-04-07 15:15:53 +02:00
Thomas Fricard
c38ee97246 refactor custom_namespace and custom_group_name 2023-04-07 15:15:53 +02:00
Thomas Fricard
fc928a1987 change RaiseError to OP LoadError 2023-04-07 15:15:53 +02:00
Thomas Fricard
9cfa795f47 remove 'group_name' from arguments and add it to 'options' dict 2023-04-07 15:15:50 +02:00
Thomas Fricard
cf0debf04b move namespace and group_name logic into for loop 2023-04-07 15:15:32 +02:00
Thomas Fricard
d13fc645e7 adapt custom namespace and group name to new settings + refactoring 2023-04-07 15:14:12 +02:00
Thomas Fricard
6ecaa7dd05 move custom naming logic outside the for loop since it is not dynamic 2023-04-07 15:12:52 +02:00
Thomas Fricard
92a35bc7d2 fix layout 2023-04-07 15:12:52 +02:00
Thomas Fricard
307e57bbfd change variables name for template 2023-04-07 15:12:51 +02:00
Thomas Fricard
8879c8e9e9 remove _ suffix on unique namespace 2023-04-07 15:11:02 +02:00
Thomas Fricard
599af2de23 remove unused import 2023-04-07 15:11:02 +02:00
Thomas Fricard
45f59b4e58 raise value error for wrong namespace format + make namespace unique 2023-04-07 15:11:02 +02:00
Thomas Fricard
1c207b91f4 process custom reference naming for maya 2023-04-07 15:11:02 +02:00
Thomas Fricard
91331acc4a create namespace if it doesn't already exists in maya + replace _ by : in namespace 2023-04-07 15:08:24 +02:00
Roy Nieterau
3cb3641113 Be more explicit about the flattened creator attributes data structure 2023-04-06 20:23:26 +02:00
Roy Nieterau
3b2dce759c Use base class for Renderlayer linked creators 2023-04-06 17:55:07 +02:00
Roy Nieterau
49b2b657a4
Cleanup code from review suggestions
Co-authored-by: Fabià Serra Arrizabalaga <fabia.serra92@gmail.com>
2023-03-21 17:27:08 +01:00
Roy Nieterau
791c7deeb5
Update openpype/hosts/maya/api/plugin.py
Co-authored-by: Fabià Serra Arrizabalaga <fabia.serra92@gmail.com>
2023-03-21 17:20:19 +01:00
Roy Nieterau
9de0a81685 Merge remote-tracking branch 'upstream/develop' into maya_new_publisher
# Conflicts:
#	openpype/hosts/maya/plugins/create/create_animation.py
#	openpype/hosts/maya/plugins/create/create_arnold_scene_source.py
#	openpype/hosts/maya/plugins/create/create_pointcache.py
#	openpype/hosts/maya/plugins/create/create_render.py
#	openpype/hosts/maya/plugins/create/create_review.py
#	openpype/hosts/maya/plugins/create/create_vrayproxy.py
#	openpype/hosts/maya/plugins/create/create_xgen.py
#	openpype/hosts/maya/plugins/publish/extract_xgen_cache.py
#	openpype/hosts/maya/plugins/publish/validate_maya_units.py
#	openpype/hosts/maya/plugins/publish/validate_mesh_has_uv.py
#	openpype/modules/deadline/plugins/publish/submit_maya_deadline.py
#	openpype/modules/deadline/plugins/publish/submit_maya_remote_publish_deadline.py
2023-03-18 10:38:32 +01:00
Toke Stuart Jepsen
926f23d392 Fix updating 2023-02-01 20:57:53 +00:00
Roy Nieterau
4f633aa5a4 Ignore cbId attribute on read 2023-02-01 01:12:17 +01:00
Toke Stuart Jepsen
ab0e3fab01 BigRoy feedback 2023-01-31 17:47:12 +00:00