Commit graph

75 commits

Author SHA1 Message Date
Jakub Trllo
7e9f42b447
Applications: Use prelaunch hooks to extract environments (#5387)
* ApplicationManager can have more granular way how applications are launched

* executable is optional to be able create ApplicationLaunchContext

* launch context can run prelaunch hooks without launching application

* 'get_app_environments_for_context' is using launch context to prepare environments

* added 'launch_type' as one of filtering options for LaunchHook

* added 'local' launch type filter to existing launch hooks

* define 'automated' launch type in remote publish function

* modified publish and extract environments cli commands

* launch types are only for local by default

* fix import

* fix launch types of global host data

* change order or kwargs

* change unreal filter attribute
2023-08-03 10:04:15 +02:00
Petr Kalis
46a238c8b6
Slack - enhanced logging and protection against failure (#5287)
* OP-6248 - enhanced logging and protection against failure

Covered issues found in production on customer site. SlackAPI exception doesn't need to have 'error', covered uncaught exception.

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-07-13 14:20:27 +02:00
Petr Kalis
751586fd41 Revert "Fix - added missed scopes for Slack bot"
This reverts commit 5e0c4a3ab1.
2023-02-23 16:31:26 +01:00
Petr Kalis
4a70ec9c54 Fix - added missed scopes for Slack bot 2023-02-23 16:28:33 +01:00
Petr Kalis
cb551fe83a Revert "Fix - added missed scopes for Slack bot"
This reverts commit 5e0c4a3ab1.
2023-02-23 15:39:54 +01:00
Petr Kalis
bae2ded2f7 Fix - check existence only if not None
review_path might be None
2023-02-23 13:54:00 +01:00
Ondřej Samohel
0e2f495966
Merge pull request #4441 from fabiaserra/bugfix/fix-remote-shotgrid 2023-02-16 13:48:29 +01:00
Fabia Serra Arrizabalaga
27150e4abb Address feedback on PR and move function to pipeline.publish.lib 2023-02-08 20:23:26 +01:00
Fabia Serra Arrizabalaga
c13416b685 Remove unintended code block and fix Hound lint warnings for <79 chars width 2023-02-08 19:39:47 +01:00
Fabia Serra Arrizabalaga
b1ef1b751f Abstract get_representation_path function and use it on shotgrid to fix remote errors with data instances not having 'published_path' 2023-02-08 19:11:20 +01:00
Petr Kalis
e7d60288a1 Fix - added missed scopes for Slack bot 2023-02-08 12:15:43 +01:00
Petr Kalis
49054a53f8 Slack - renamed cache key 2023-01-16 17:42:12 +01:00
Petr Kalis
92f84518d7 Slack - introduced caching
User and group query is expensive operation, this will speed up publishing of multiple instances
2023-01-16 15:34:25 +01:00
Petr Kalis
b167b971a2 Slack - better regex
Handles cases like @test\n@john.doe
2023-01-16 13:31:31 +01:00
Petr Kalis
5ee7c17067 Slack - get users only if necessary
Only trigger when message contains @ sign.
2023-01-16 11:32:41 +01:00
Petr Kalis
dff87d4e1c Hound 2023-01-04 12:52:32 +01:00
Petr Kalis
158b1481d4 Fix - cannot pull response from ordinary exception 2023-01-04 12:51:47 +01:00
Petr Kalis
7a08c5e98c Fix - search pattern
Updated to use user profile
2023-01-04 12:44:07 +01:00
Petr Kalis
b2e8ea6fb8 Hound 2023-01-04 11:36:12 +01:00
Petr Kalis
68fe823238 Fix resolving of user_id
Display name or real_name could be used also.
2023-01-03 17:53:00 +01:00
Petr Kalis
394c678299 Do not throw exception if user or group list error
Skip notification, publish shouldn't fail because of this.
2023-01-03 17:19:50 +01:00
Petr Kalis
f80fe3fb93 Fix obsolete call of method 2023-01-03 17:14:57 +01:00
Petr Kalis
1ee50975c0 Fix wrong position of method 2023-01-03 17:14:41 +01:00
Petr Kalis
6abcd5ef34 Merge develop 2023-01-03 17:08:58 +01:00
Petr Kalis
7a372d1b1c Added possibility to mention users or groups 2023-01-03 17:05:47 +01:00
Petr Kalis
3a41d6a721 OP-4470 - safer handling of review path
'published_path' might be missing.
Thumbnail path was fixed previously, this one was missed.
2022-12-23 14:13:00 +01:00
Petr Kalis
c16a5289e4 OP-4470 - better handle missing keys
Message might contain {placeholder} which are not collected. Previously it would fail without sending message. Now missing keys are double escaped {{}}.
2022-12-23 14:09:03 +01:00
Petr Kalis
ae709afaaf Added dynamic message to Slack notification
Artist can now add additional message, specific per instance and publish, if they are using Publisher.
2022-12-23 12:25:01 +01:00
Petr Kalis
855e7d1c61 OP-4196 - fix filtering profiles
Task types didn't work.
2022-11-22 18:28:01 +01:00
Petr Kalis
3b81c7f573 OP-4196 - better logging of file upload errors 2022-11-22 18:15:27 +01:00
Petr Kalis
3cd241d2db OP-4196 - fix wrong return type 2022-11-22 14:01:10 +01:00
Petr Kalis
ab17acddc7 OP-4196 - better handling of data
It should take task from instance anatomyData, then from context and handle non dict items.
2022-11-22 13:39:24 +01:00
Petr Kalis
f993842c4e OP-4196 - remove unnecessary logging 2022-11-22 13:01:27 +01:00
Petr Kalis
c61098b782 OP-4196 - fix when task_data is not dict
In legacy cases task might be only string with its name, not structure with additional metadata (type etc.). This implementation handles that.
2022-11-22 13:00:34 +01:00
Petr Kalis
ac9b9b208e OP-4196 - safer getter for published_path
published_path might be missing in case of thumbnail not getting published. This implementation takes from staging if published_path not present
2022-11-22 12:54:28 +01:00
Jakub Trllo
81017f90cf added forgotten modules 2022-11-03 16:26:26 +01:00
Jakub Trllo
37371936cf safer task data 2022-09-02 14:08:40 +02:00
Jakub Trllo
198ad3ac90 add both 'user' and 'username' in integrate slack 2022-09-01 13:25:02 +02:00
Jakub Trllo
8cc6086e92 removed usage of 'ILaunchHookPaths' 2022-08-25 12:22:19 +02:00
Jakub Trllo
308d9e9c49 use 'OpenPypeMongoConnection' from 'openpype.client' 2022-07-18 11:20:14 +02:00
Jakub Trllo
e75170d5c6 replace avalon imports in modules 2022-04-14 12:35:27 +02:00
Petr Kalis
ac7b35698d Updated Slack notification message 2022-03-25 10:08:40 +01:00
Petr Kalis
b6d7290887 Merge branch 'develop' of github.com:pypeclub/OpenPype into feature/slack_review_file_size 2022-03-25 09:49:43 +01:00
Petr Kalis
ce4caeabd3 Added configurable maximum file size of review upload to Slack 2022-03-24 13:47:07 +01:00
Petr Kalis
4442ef7128
Update openpype/modules/slack/plugins/publish/integrate_slack_api.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2022-03-24 11:57:56 +01:00
Petr Kalis
aaa4c1d54c Add generic exception handling for Slack notification 2022-03-24 11:53:57 +01:00
Petr Kalis
7f5185b217 OP-2736 - safer way to get paths
Instances without any representations (for example when sending to render to farm) would fail with incorrect settings.
2022-02-23 13:24:55 +01:00
Petr Kalis
eca57b03d6 OP-2736 - fail gracefully if slack exception 2022-02-23 10:36:38 +01:00
Petr Kalis
dbcb8f63e3 OP-2642 - added subset filter to limit Slack notifications 2022-02-21 13:55:24 +01:00
Petr Kalis
5e8f0e0152 OP-1730 - removed obsolete variables
Modification username and icon via message payload doesn't work for both post_method and upload_file. Icon must be set in Slack app configuration.
2022-01-12 17:02:58 +01:00