* Updates to tests because of default Thumbnail non integration
Some previous PR changed default behavior of Thumbnail, they are not integrated anymore. Tests were expecting they are.
Change in AE local render is required to match behavior and provide Colorspace handling.
* Updates to tests because of default Thumbnail non integration
Missed values
* Updates to tests because of default Thumbnail non integration
Missed values
* dump_databases flag
* Remove wrongly placed code.
* Turn flag into format and support json export.
* Added new argument to readme
---------
Co-authored-by: kalisp <petr.kalis@gmail.com>
* Ingest input workfile
* Ingest input workfile
* Ingested expected files, workfile
Implemented LocalFileHandler.
Test name added to structure to separate files for each test.
Removed superfluous `files` to keep other Maya test working
* Missing time import
* Hound
* Skip directories when checking folder structure.
* Update tests/lib/testing_classes.py
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
* Updated integration tests documentation
* Ingested test files for Deadline test in maya
* Removed unneeded files
* Refactored name
---------
Co-authored-by: kalisp <petr.kalis@gmail.com>
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
* Working version
* Improve launched app communication
* Move imports to methods.
* Update tests/integration/hosts/maya/test_publish_in_maya.py
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
* Collect errors from process
* fix startup scripts arguments
* Update openpype/lib/applications.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* Fix application polling
* Docstring
* Revert stdout and stderr
* Revert subprocess.PIPE
* Added missed imports
If we are moving these because of testing, lets move all of them
---------
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: kalisp <petr.kalis@gmail.com>
* OP-7031 - fix thumbnail outputName
This handles situation when ExtractReviewDataMov has multiple outputs for which are thumbnails created. This would cause an issue in integrate if thumbnail repre should be integrated.
* thumbnail name the same as output name
- added `delete` tag so it is not integrated
- adding output preset name to thumb name if multiple bake streams
- adding thumbnails to explicit cleanup paths
- thumbnail file name inherited from representation name
* hound
* comment for py compatibility of unicode
* Update openpype/hosts/nuke/plugins/publish/extract_thumbnail.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* thumbnail path key should be `thumbnailPath`
* Updates to nuke automatic test
Default changed to NOT integrating thumbnail representation.
* Update openpype/hosts/nuke/plugins/publish/extract_thumbnail.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* OP-7031 - updated check for thumbnail representation
To allow use this plugin as 'name' might not contain only 'thumbnail' for multiple outputs.
* Remove possibility of double _
* Implement possibility of multiple thumbnails
This could happen if there are multiple output as in Nuke's ExtractREviewMov
---------
Co-authored-by: Jakub Jezek <jakubjezek001@gmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* OP-6407 - fix wrong value used in comparison
`prerender.farm` is correct value for prerender family sent to farm
* OP-6407 - added test class for prerender family
* OP-5657 - add artist control for review in AfterEffects
Artist can disable review to be created for particular publish.
* OP-5657 - add artist control for review in AfterEffects
Removed configuration for Deadline, should be controlled by what is on instance.
* OP-5657 - handle legacy instances
Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.
* OP-5657 - remove explicit review for all AE
Now handled directly on instance
* OP-5657 - fix - cannot remove now
Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.
* OP-5657 - fix - correct host name used
* OP-5657 - fix - correct handling of review
On local renders review should be added only from families, not from older approach through Settings.
Farm instance cannot have review in families or extract_review would get triggered even locally.
* OP-5657 - refactor - changed label
* OP-5657 - Hound
* OP-5657 - added explicitly skipping review
Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).
* OP-5657 - updated setting of review variable
instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.
* OP-5657 - fix adding review flag
* OP-5657 - updated test
Removed review for second instance.
* OP-5657 - refactor to context plugin
* OP-5657 - tie thumbnail to review for local render
Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
* OP-5656 - added auto creator for review in PS
Review instance should be togglable.
Review instance needs to be created for non publisher based workflows.
* OP-5656 - refactored names
* OP-5656 - refactored names
* OP-5656 - new auto creator for flat image
In old version flat image was created if no instances were created. Explicit auto creator added for clarity.
Standardization of state of plugins
* OP-5656 - updated according to auto image creator
Subset template should be used from autocreator and not be separate.
* OP-5656 - fix proper creator name
* OP-5656 - fix log message
* OP-5656 - fix use enable state
* OP-5656 - fix formatting
* OP-5656 - add review toggle to image instance
For special cases where each image should have separate review.
* OP-5656 - fix description
* OP-5656 - fix not present asset and task in instance context
* OP-5656 - refactor - both auto creators should use same class
Provided separate description.
* OP-5656 - fix - propagate review to families
Image and auto image could have now review flag.
Bottom logic is only for Webpublisher.
* OP-5656 - fix - rename review files to avaid collision
Image family produces jpg and png, jpg review would clash with name. It should be replaced by 'jpg_jpg'.
* OP-5656 - fix - limit additional auto created only on WP
In artist based publishing auto image would be created by auto creator (if enabled). Artist might want to disable image creation.
* OP-5656 - added mark_for_review flag to Publish tab
* OP-5656 - fixes for auto creator
* OP-5656 - fixe - outputDef not needed
outputDef should contain dict of output definition. In PS it doesn't make sense as it has separate extract_review without output definitions.
* OP-5656 - added persistency of changes to auto creators
Changes as enabling/disabling, changing review flag should persist.
* OP-5656 - added documentation for admins
* OP-5656 - added link to new documentation for admins
* OP-5656 - Hound
* OP-5656 - Hound
* OP-5656 - fix shared families list
* OP-5656 - added default variant for review and workfile creator
For workfile Main was default variant, "" was for review.
* OP-5656 - fix - use values from Settings
* OP-5656 - fix - use original name of review for main review family
outputName cannot be in repre or file would have ..._jpg.jpg
* OP-5656 - refactor - standardized settings
Active by default denotes if created instance is active (eg. publishable) when created.
* OP-5656 - fixes for skipping collecting auto_image
data["ids"] are necessary for extracting. Members are physical layers in image, ids are "virtual" items, won't get grouped into real image instance.
* OP-5656 - reworked auto collectors
This allows to use automatic test for proper testing.
* OP-5656 - added automatic tests
* OP-5656 - fixes for auto collectors
* OP-5656 - removed unnecessary collector
Logic moved to auto collectors.
* OP-5656 - Hound
Branch with newly implemented DL tests is targetted to release 3.15, but changes from it affects tests in develop.
This branch should solve issues with automatic tests in develop without need of full release 3.15 changes.
Some files or folders are dynamically created and cannot be part of comparing of published and expected folder structure.
(Example is Logs in AE from DL)
