Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2026-01-01 16:34:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2045 from pypeclub/bugfix/remove_shell_flag_for_ffmpeg

Browse source 
Removed shell flag in subprocess call
This commit is contained in:
Petr Kalis 2021-09-20 17:41:17 +02:00 • committed by GitHub
commit 12f066bd2c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
openpype/hosts/standalonepublisher/plugins/publish/extract_thumbnail.py
View file

@ -108,7 +108,7 @@ class ExtractThumbnailSP(pyblish.api.InstancePlugin):
# run subprocess # run subprocess
self.log.debug("Executing: {}".format(" ".join(subprocess_args))) self.log.debug("Executing: {}".format(" ".join(subprocess_args)))
openpype.api.run_subprocess( openpype.api.run_subprocess(
subprocess_args, shell=True, logger=self.log subprocess_args, logger=self.log
) )
# remove thumbnail key from origin repre # remove thumbnail key from origin repre

2
openpype/hosts/standalonepublisher/plugins/publish/extract_trim_video_audio.py
View file

@ -84,7 +84,7 @@ class ExtractTrimVideoAudio(openpype.api.Extractor):
joined_args = " ".join(ffmpeg_args) joined_args = " ".join(ffmpeg_args)
self.log.info(f"Processing: {joined_args}") self.log.info(f"Processing: {joined_args}")
openpype.api.run_subprocess( openpype.api.run_subprocess(
ffmpeg_args, shell=True, logger=self.log ffmpeg_args, logger=self.log
) )
repre = { repre = {

3
openpype/plugins/publish/extract_jpeg_exr.py
View file

@ -122,13 +122,14 @@ class ExtractJpegEXR(pyblish.api.InstancePlugin):
self.log.debug("{}".format(subprocess_command)) self.log.debug("{}".format(subprocess_command))
try: # temporary until oiiotool is supported cross platform try: # temporary until oiiotool is supported cross platform
run_subprocess( run_subprocess(
subprocess_args, shell=True, logger=self.log subprocess_args, logger=self.log
) )
except RuntimeError as exp: except RuntimeError as exp:
if "Compression" in str(exp): if "Compression" in str(exp):
self.log.debug("Unsupported compression on input files. " + self.log.debug("Unsupported compression on input files. " +
"Skipping!!!") "Skipping!!!")
return return
self.log.warning("Conversion crashed", exc_info=True)
raise raise
if "representations" not in instance.data: if "representations" not in instance.data:

2
openpype/plugins/publish/extract_review.py
View file

@ -228,7 +228,7 @@ class ExtractReview(pyblish.api.InstancePlugin):
) )
openpype.api.run_subprocess( openpype.api.run_subprocess(
subprocess_args, shell=True, logger=self.log subprocess_args, logger=self.log
) )
# delete files added to fill gaps # delete files added to fill gaps

4
openpype/plugins/publish/extract_review_slate.py
View file

@ -209,7 +209,7 @@ class ExtractReviewSlate(openpype.api.Extractor):
"Slate Executing: {}".format(" ".join(slate_subprocess_args)) "Slate Executing: {}".format(" ".join(slate_subprocess_args))
) )
openpype.api.run_subprocess( openpype.api.run_subprocess(
slate_subprocess_args, shell=True, logger=self.log slate_subprocess_args, logger=self.log
) )
# create ffmpeg concat text file path # create ffmpeg concat text file path
@ -244,7 +244,7 @@ class ExtractReviewSlate(openpype.api.Extractor):
"Executing concat: {}".format(" ".join(concat_args)) "Executing concat: {}".format(" ".join(concat_args))
) )
openpype.api.run_subprocess( openpype.api.run_subprocess(
concat_args, shell=True, logger=self.log concat_args, logger=self.log
) )
self.log.debug("__ repre[tags]: {}".format(repre["tags"])) self.log.debug("__ repre[tags]: {}".format(repre["tags"]))