mirror of
https://github.com/ynput/ayon-core.git
synced 2026-01-01 08:24:53 +01:00
Refactor transcoding and thumbnail extraction code
- Removed the unused `additional_input_args` parameter from the `convert_colorspace` function in `transcoding.py` - Renamed the `additional_input_args` parameter to `additional_command_args` in the `ExtractThumbnail` class in `extract_thumbnail.py` These changes improve code clarity and remove unnecessary parameters.
This commit is contained in:
parent
7449f27855
commit
30800c1c2c
2 changed files with 1 additions and 6 deletions
|
|
@ -1103,7 +1103,6 @@ def convert_colorspace(
|
||||||
target_colorspace=None,
|
target_colorspace=None,
|
||||||
view=None,
|
view=None,
|
||||||
display=None,
|
display=None,
|
||||||
additional_input_args=None,
|
|
||||||
additional_command_args=None,
|
additional_command_args=None,
|
||||||
logger=None,
|
logger=None,
|
||||||
):
|
):
|
||||||
|
|
@ -1125,7 +1124,6 @@ def convert_colorspace(
|
||||||
both 'view' and 'display' must be filled (if 'target_colorspace')
|
both 'view' and 'display' must be filled (if 'target_colorspace')
|
||||||
display (str): name for display-referred reference space (ocio valid)
|
display (str): name for display-referred reference space (ocio valid)
|
||||||
both 'view' and 'display' must be filled (if 'target_colorspace')
|
both 'view' and 'display' must be filled (if 'target_colorspace')
|
||||||
additional_input_args (list): arguments for input file
|
|
||||||
additional_command_args (list): arguments for oiiotool (like binary
|
additional_command_args (list): arguments for oiiotool (like binary
|
||||||
depth for .dpx)
|
depth for .dpx)
|
||||||
logger (logging.Logger): Logger used for logging.
|
logger (logging.Logger): Logger used for logging.
|
||||||
|
|
@ -1140,9 +1138,6 @@ def convert_colorspace(
|
||||||
# Collect channels to export
|
# Collect channels to export
|
||||||
input_arg, channels_arg = get_oiio_input_and_channel_args(input_info)
|
input_arg, channels_arg = get_oiio_input_and_channel_args(input_info)
|
||||||
|
|
||||||
if additional_input_args:
|
|
||||||
input_arg = "{} {}".format(input_arg, " ".join(additional_input_args))
|
|
||||||
|
|
||||||
# Prepare subprocess arguments
|
# Prepare subprocess arguments
|
||||||
oiio_cmd = get_oiio_tool_args(
|
oiio_cmd = get_oiio_tool_args(
|
||||||
"oiiotool",
|
"oiiotool",
|
||||||
|
|
|
||||||
|
|
@ -371,7 +371,7 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
|
||||||
display=repre_display or oiio_default_display,
|
display=repre_display or oiio_default_display,
|
||||||
view=repre_view or oiio_default_view,
|
view=repre_view or oiio_default_view,
|
||||||
target_colorspace=oiio_default_colorspace,
|
target_colorspace=oiio_default_colorspace,
|
||||||
additional_input_args=resolution_arg,
|
additional_command_args=resolution_arg,
|
||||||
logger=self.log,
|
logger=self.log,
|
||||||
)
|
)
|
||||||
except Exception:
|
except Exception:
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue