Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-24 21:04:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review

Browse source 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
This commit is contained in:
Jakub Ježek 2025-05-12 13:46:54 +02:00 • committed by GitHub
parent bf44622c05
commit 57b808e924
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 24 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

53
client/ayon_core/plugins/publish/extract_thumbnail.py
View file

@ -497,7 +497,7 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
# For very short videos, just use the first frame
# Calculate seek position safely
seek_position = 0
seek_position = 0.0
# Only use timestamp calculation for videos longer than 0.1 seconds
if duration > 0.1:
seek_position = duration * self.duration_split
@ -539,36 +539,31 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
self.log.debug(
"Thumbnail created: {}".format(output_thumb_file_path))
return output_thumb_file_path
else:
self.log.warning(
"Output file was not created or is empty: {}".format(
output_thumb_file_path))
# Fallback to extracting the first frame without seeking
if "-ss" in cmd_args:
self.log.debug("Trying fallback without seeking")
# Remove -ss and its value
ss_index = cmd_args.index("-ss")
cmd_args.pop(ss_index) # Remove -ss
cmd_args.pop(ss_index) # Remove the timestamp value
# Create new command and try again
cmd = get_ffmpeg_tool_args("ffmpeg", *cmd_args)
self.log.debug("Fallback command: {}".format(
" ".join(cmd)))
run_subprocess(cmd, logger=self.log)
if (
os.path.exists(output_thumb_file_path)
and os.path.getsize(output_thumb_file_path) > 0
):
self.log.debug(
"Fallback thumbnail created: {}".format(
output_thumb_file_path)
)
return output_thumb_file_path
self.log.warning("Output file was not created or is empty")
# Try to create thumbnail without offset
# - skip if offset did not happen
if "-ss" not in cmd_args:
return None
self.log.debug("Trying fallback without offset")
# Remove -ss and its value
ss_index = cmd_args.index("-ss")
cmd_args.pop(ss_index) # Remove -ss
cmd_args.pop(ss_index) # Remove the timestamp value
# Create new command and try again
cmd = get_ffmpeg_tool_args("ffmpeg", *cmd_args)
self.log.debug("Fallback command: {}".format(" ".join(cmd)))
run_subprocess(cmd, logger=self.log)
if (
os.path.exists(output_thumb_file_path)
and os.path.getsize(output_thumb_file_path) > 0
):
self.log.debug(f"Fallback thumbnail created")
return output_thumb_file_path
return None
except RuntimeError as error:
self.log.warning(
"Failed intermediate thumb source using ffmpeg: {}".format(