Merge pull request #2148 from pypeclub/feature/PYPE-1315-Nuke--use-reformat-instead-of-crop-in-render-write

openpype/hosts/nuke/api/lib.py

@@ -1032,27 +1032,6 @@ class WorkfileSettings(object):
             log.error(msg)
             nuke.message(msg)
 
-        bbox = self._asset_entity.get('data', {}).get('crop')
-
-        if bbox:
-            try:
-                x, y, r, t = bbox.split(".")
-                data.update(
-                    {
-                        "x": int(x),
-                        "y": int(y),
-                        "r": int(r),
-                        "t": int(t),
-                    }
-                )
-            except Exception as e:
-                bbox = None
-                msg = ("{}:{} \nFormat:Crop need to be set with dots, "
-                       "example: 0.0.1920.1080, "
-                       "/nSetting to default").format(__name__, e)
-                log.error(msg)
-                nuke.message(msg)
-
         existing_format = None
         for format in nuke.formats():
             if data["name"] == format.name():
@@ -1064,12 +1043,6 @@ class WorkfileSettings(object):
             existing_format.setWidth(data["width"])
             existing_format.setHeight(data["height"])
             existing_format.setPixelAspect(data["pixel_aspect"])
-
-            if bbox:
-                existing_format.setX(data["x"])
-                existing_format.setY(data["y"])
-                existing_format.setR(data["r"])
-                existing_format.setT(data["t"])
         else:
             format_string = self.make_format_string(**data)
             log.info("Creating new format: {}".format(format_string))

openpype/hosts/nuke/plugins/create/create_write_render.py

@@ -99,7 +99,7 @@ class CreateWriteRender(plugin.PypeCreator):
                 "fpath_template": ("{work}/renders/nuke/{subset}"
                                    "/{subset}.{frame}.{ext}")})
 
-        # add crop node to cut off all outside of format bounding box
+        # add reformat node to cut off all outside of format bounding box
         # get width and height
         try:
             width, height = (selected_node.width(), selected_node.height())
@@ -109,15 +109,11 @@ class CreateWriteRender(plugin.PypeCreator):
 
         _prenodes = [
             {
-                "name": "Crop01",
-                "class": "Crop",
+                "name": "Reformat01",
+                "class": "Reformat",
                 "knobs": [
-                    ("box", [
-                        0.0,
-                        0.0,
-                        width,
-                        height
-                    ])
+                    ("resize", 0),
+                    ("black_outside", 1),
                 ],
                 "dependent": None
             }

openpype/hosts/nuke/plugins/publish/validate_output_resolution.py

@@ -56,8 +56,8 @@ class ValidateOutputResolution(pyblish.api.InstancePlugin):
 
     def process(self, instance):
 
-        # Skip bounding box check if a crop node exists.
-        if instance[0].dependencies()[0].Class() == "Crop":
+        # Skip bounding box check if a reformat node exists.
+        if instance[0].dependencies()[0].Class() == "Reformat":
             return
 
         msg = "Bounding box is outside the format."