Commit graph

213 commits

Author SHA1 Message Date
Thomas Fricard
34528b6eeb
Deactivate closed Kitsu projects on OP (#4619)
* update openpype projects status from kitsu settings

* fix linting errors

* get all projects and verify the project status for each project

* optimizing project status name verification

* sync only if project exists and is active in OP

* remove noqa

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* break from all_status for loop and add comment for non sync projects

---------

Co-authored-by: jeremy.oblet <jeremy.oblet@fixstudio.com>
Co-authored-by: Thomas Fricard <tfricard@ws114.prs.vfx.int>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-04-03 12:11:53 +02:00
Jakub Trllo
6f04af0d92
Merge branch 'develop' into enhancemen_kitsu_note_family_requirements 2023-03-29 10:57:50 +02:00
Sharkitty
0cc5f3ee37 Changed logic as suggested 2023-03-24 15:44:29 +01:00
Roy Nieterau
0a085c7001
Kitsu: Slightly less strict with instance data (#4678)
* Match family and families

* Allow kitsu note to not have set comment and capture it without erroring in IntegrateKitsuReview

* Allow fallback to context for instance `task`

* Shush hound

* Refactor variable names
2023-03-23 12:06:05 +01:00
Sharkitty
3af2736790 linted 2023-03-22 14:38:42 +01:00
Sharkitty
583fecd400 Fixes and adjustments based on reviews 2023-03-22 14:37:59 +01:00
Sharkitty
5ca5498b03 Changed family requirement check based on discussions 2023-03-21 17:33:50 +01:00
Sharkitty
2022a38c65 Apply suggestions from code review
Adjustment to documentation, and families set declaration

Co-authored-by: Félix David <felixg.david@gmail.com>
2023-03-21 16:34:23 +01:00
Sharkitty
83aabf4c2b Linted 2023-03-21 16:30:24 +01:00
Sharkitty
d8360b5b19 Made changes to resolve conflicts with develop. Changes how publisshed families are accessed. 2023-03-21 16:21:29 +01:00
Sharkitty
7356887df6 Renaming equality into condition, made a new screenshot so both equal and not equal settings are shown 2023-03-21 16:15:39 +01:00
Sharkitty
b467909fd6 Using lower cases for families and a small fix 2023-03-21 16:10:21 +01:00
Sharkitty
c42ce4e96c Enhancement: Adding family requirements option to kitsu note 2023-03-21 16:10:11 +01:00
Sharkitty
6f16f3e4f4
Enhancement kitsu note with exceptions (#4537)
* Enhancement: Allowing kitsu not status exceptions

* Update openpype/modules/kitsu/plugins/publish/integrate_kitsu_note.py

Co-authored-by: Félix David <felixg.david@gmail.com>

* adding equal/not equal option

* Making equal/not equal option available at for every list item

* Changed  into , renamed  into , added documentation

* Using upper cases during check, so the new settings aren't case sensitive

* Linting little detail

* Renaming Equality into Condition, new screenshot with both equal and not equal shown on it

* Update website/docs/module_kitsu.md

README adjustments

Co-authored-by: Félix David <felixg.david@gmail.com>

* Changes needed to resolve conflict

* Changing context into instance where appropriate

* Minor change to avoid changing a line that doesn't need to be changed

* Turning exceptions into conditions. Making checks positive instead of negative. Changing implementation based on suggestions.

---------

Co-authored-by: Félix David <felixg.david@gmail.com>
2023-03-21 15:22:23 +01:00
Roy Nieterau
ec9b6cb56d
Merge pull request #4596 from EmberLightVFX/kitsu-int-metadata
Kitsu: Sync OP with zou, make sure value-data is int or float
2023-03-21 14:55:06 +01:00
Jacob Danell
94ba8151e7 Read the comment from the instance instead from the context 2023-03-17 16:23:13 +01:00
Jacob Danell
8a91e4aaa0 Fixed comment 2023-03-17 16:22:28 +01:00
Jacob Danell
5a7bf785f7 Fixed hound comments 2023-03-16 17:13:17 +01:00
Jacob Danell
f70eac116d Made the format function more logical 2023-03-16 17:11:16 +01:00
Jacob Danell
adc648616f Look for review in families instead of family 2023-03-16 10:40:03 +01:00
Jacob Danell
ce22b665b4 Fixed comments in code 2023-03-16 10:39:47 +01:00
Jacob Danell
b3816ae876 Fixed key check towards kwargs 2023-03-15 17:05:00 +01:00
Jacob Danell
a789b135ae Changed the instance check from render to review 2023-03-14 18:33:00 +01:00
Jacob Danell
c53e5b2302 Added docstring 2023-03-14 18:32:41 +01:00
Jacob Danell
383ce7ccb6 Change variable name to snake_case 2023-03-14 18:32:18 +01:00
Jacob Danell
78ce629ba6 Removed double casting 2023-03-14 18:14:19 +01:00
Jacob Danell
a797d78d45 Added a check so only renders gets published to Kitsu 2023-03-10 23:19:31 +01:00
Jacob Danell
7c1789faab Add custom message functionally 2023-03-10 23:07:41 +01:00
Jacob Danell
6e34c4aed2 Make sure value-data is int or float 2023-03-09 16:13:32 +01:00
Jacob Danell
acbfb5985b Fixed task itteration
From the last PR (https://github.com/ynput/OpenPype/pull/4425) a comment-commit last second messed up and resultet in two lines being the same, crashing the script.
This fixes that.
2023-03-07 19:34:12 +01:00
Jacob Danell
67bc287321 Fix hound comments 2023-03-03 16:49:11 +01:00
Jacob Danell
8fc6978ea2 Formatted with Black 2023-03-03 16:49:11 +01:00
Ember Light
c50678bcb8 Update openpype/modules/kitsu/utils/update_op_with_zou.py
Co-authored-by: Félix David <felixg.david@gmail.com>
2023-03-03 16:49:11 +01:00
Jacob Danell
7176be9f92 Log msg for new_task now work for both shot and assets 2023-03-03 16:49:11 +01:00
Jacob Danell
804cdcafd6 Store the gazu asset data in OPs DB as sync_service does
This isn't the most optimal way to do it but it makes sure the data is consistent through out the code until we can revision sync_service to only use the ID from the dict.
2023-03-03 16:49:11 +01:00
Jacob Danell
966ba0166e Fixed delete_task msg creation to work with assets and episodes 2023-03-03 16:49:11 +01:00
Jacob Danell
95e1f95bc1 Moved all ep_dict code into one function 2023-03-03 16:49:11 +01:00
Ember Light
93eb9fce86 Update openpype/modules/kitsu/utils/sync_service.py
Co-authored-by: Félix David <felixg.david@gmail.com>
2023-03-03 16:49:11 +01:00
Jacob Danell
5a9ea0d130 Changed back from dict to doc for var names 2023-03-03 16:49:11 +01:00
Jacob Danell
247778575f Project creation logs happens outside of write_project_to_op() function 2023-03-03 16:49:11 +01:00
Jacob Danell
0beec8c3a7 Fixed hound's comments 2023-03-03 16:49:11 +01:00
Jacob Danell
0d981a6129 Fixed hound's comments 2023-03-03 16:49:11 +01:00
Jacob Danell
8bf970e8b9 fixed hound's comments 2023-03-03 16:49:11 +01:00
Jacob Danell
962d0783b0 Fixed fetching of kitsu_task + moved data checks to the top of loop 2023-03-03 16:49:11 +01:00
Jacob Danell
7965b91daf Moved kitsu_project out of context loop 2023-03-03 16:49:11 +01:00
Jacob Danell
d153e6c224 Split up the difference in name and type Assets/Shots generate
Before it was only working for shots. Now it also works for Assets.
I'm ding an elif as Kitsu now also have tasks for sequences, edits and other things.
Will try and add those in at a later stage.
2023-03-03 16:49:11 +01:00
Jacob Danell
d9ac1ee952 Cleaned up log.info() message creation 2023-03-03 16:49:11 +01:00
Jacob Danell
bcea2c70a2 Cleaned up project deletion code 2023-03-03 16:49:11 +01:00
Jacob Danell
13a4c7201e change task to task_id 2023-03-03 16:49:11 +01:00
Jacob Danell
0f76d3a44e Cleaned up the fetching of the entity_id
Also changed the name kitsu_id to entity_id and kitsu_entity to just entity as that's what it is.
2023-03-03 16:49:11 +01:00