Jakub Trllo
6f04af0d92
Merge branch 'develop' into enhancemen_kitsu_note_family_requirements
2023-03-29 10:57:50 +02:00
Sharkitty
0cc5f3ee37
Changed logic as suggested
2023-03-24 15:44:29 +01:00
Roy Nieterau
0a085c7001
Kitsu: Slightly less strict with instance data ( #4678 )
...
* Match family and families
* Allow kitsu note to not have set comment and capture it without erroring in IntegrateKitsuReview
* Allow fallback to context for instance `task`
* Shush hound
* Refactor variable names
2023-03-23 12:06:05 +01:00
Sharkitty
3af2736790
linted
2023-03-22 14:38:42 +01:00
Sharkitty
583fecd400
Fixes and adjustments based on reviews
2023-03-22 14:37:59 +01:00
Sharkitty
5ca5498b03
Changed family requirement check based on discussions
2023-03-21 17:33:50 +01:00
Sharkitty
2022a38c65
Apply suggestions from code review
...
Adjustment to documentation, and families set declaration
Co-authored-by: Félix David <felixg.david@gmail.com>
2023-03-21 16:34:23 +01:00
Sharkitty
83aabf4c2b
Linted
2023-03-21 16:30:24 +01:00
Sharkitty
d8360b5b19
Made changes to resolve conflicts with develop. Changes how publisshed families are accessed.
2023-03-21 16:21:29 +01:00
Sharkitty
7356887df6
Renaming equality into condition, made a new screenshot so both equal and not equal settings are shown
2023-03-21 16:15:39 +01:00
Sharkitty
b467909fd6
Using lower cases for families and a small fix
2023-03-21 16:10:21 +01:00
Sharkitty
c42ce4e96c
Enhancement: Adding family requirements option to kitsu note
2023-03-21 16:10:11 +01:00
Sharkitty
6f16f3e4f4
Enhancement kitsu note with exceptions ( #4537 )
...
* Enhancement: Allowing kitsu not status exceptions
* Update openpype/modules/kitsu/plugins/publish/integrate_kitsu_note.py
Co-authored-by: Félix David <felixg.david@gmail.com>
* adding equal/not equal option
* Making equal/not equal option available at for every list item
* Changed into , renamed into , added documentation
* Using upper cases during check, so the new settings aren't case sensitive
* Linting little detail
* Renaming Equality into Condition, new screenshot with both equal and not equal shown on it
* Update website/docs/module_kitsu.md
README adjustments
Co-authored-by: Félix David <felixg.david@gmail.com>
* Changes needed to resolve conflict
* Changing context into instance where appropriate
* Minor change to avoid changing a line that doesn't need to be changed
* Turning exceptions into conditions. Making checks positive instead of negative. Changing implementation based on suggestions.
---------
Co-authored-by: Félix David <felixg.david@gmail.com>
2023-03-21 15:22:23 +01:00
Jacob Danell
94ba8151e7
Read the comment from the instance instead from the context
2023-03-17 16:23:13 +01:00
Jacob Danell
8a91e4aaa0
Fixed comment
2023-03-17 16:22:28 +01:00
Jacob Danell
5a7bf785f7
Fixed hound comments
2023-03-16 17:13:17 +01:00
Jacob Danell
f70eac116d
Made the format function more logical
2023-03-16 17:11:16 +01:00
Jacob Danell
adc648616f
Look for review in families instead of family
2023-03-16 10:40:03 +01:00
Jacob Danell
ce22b665b4
Fixed comments in code
2023-03-16 10:39:47 +01:00
Jacob Danell
b3816ae876
Fixed key check towards kwargs
2023-03-15 17:05:00 +01:00
Jacob Danell
a789b135ae
Changed the instance check from render to review
2023-03-14 18:33:00 +01:00
Jacob Danell
c53e5b2302
Added docstring
2023-03-14 18:32:41 +01:00
Jacob Danell
383ce7ccb6
Change variable name to snake_case
2023-03-14 18:32:18 +01:00
Jacob Danell
a797d78d45
Added a check so only renders gets published to Kitsu
2023-03-10 23:19:31 +01:00
Jacob Danell
7c1789faab
Add custom message functionally
2023-03-10 23:07:41 +01:00
Jacob Danell
8fc6978ea2
Formatted with Black
2023-03-03 16:49:11 +01:00
Jacob Danell
8bf970e8b9
fixed hound's comments
2023-03-03 16:49:11 +01:00
Jacob Danell
962d0783b0
Fixed fetching of kitsu_task + moved data checks to the top of loop
2023-03-03 16:49:11 +01:00
Jacob Danell
7965b91daf
Moved kitsu_project out of context loop
2023-03-03 16:49:11 +01:00
Jacob Danell
13a4c7201e
change task to task_id
2023-03-03 16:49:11 +01:00
Jacob Danell
0f76d3a44e
Cleaned up the fetching of the entity_id
...
Also changed the name kitsu_id to entity_id and kitsu_entity to just entity as that's what it is.
2023-03-03 16:49:11 +01:00
Jacob Danell
07ac3d8d4d
If no task in instance, continue
...
fix fore https://github.com/ynput/OpenPype/pull/4425#discussion_r1108582918
2023-03-03 16:49:11 +01:00
Jacob Danell
793af30caa
Changed AssertionError to ValueError
2023-03-03 16:49:11 +01:00
Jacob Danell
8652dab478
Fixed 'instance' code
2023-03-03 16:49:11 +01:00
Jacob Danell
c44c5c9ddb
Get asset and task names from instance only
2023-03-03 16:49:11 +01:00
Jacob Danell
dc2b519fd5
Fixed hound-bots comments
2023-03-03 16:49:11 +01:00
Jacob Danell
72270005ed
Update Kitsu plugin to work without assetEntry
2023-03-03 16:49:11 +01:00
Jacob Danell
27c8a1f360
Fixed so correct review file gets uploaded to Kitsu
2023-03-03 16:49:11 +01:00
Jacob Danell
785825751a
Add render to families to make sure a task exists to process
2023-03-03 16:49:11 +01:00
Jakub Trllo
1d1e4fa18a
Merge pull request #4082 from quadproduction/220-wizz_upload-only-review-files-on-kitsu
...
TvPaint: Upload only main review file on kitsu from TvPaint
2022-11-22 11:37:56 +01:00
clement hector
fd08bbf170
remove useless import
2022-11-14 15:13:11 +01:00
clement hector
1e995ea6d9
remove reviewMain checks
2022-11-14 15:06:12 +01:00
Thomas Fricard
f90e9f6412
Update openpype/modules/kitsu/plugins/publish/collect_kitsu_username.py
...
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2022-11-09 11:30:49 +01:00
clement hector
8936512b67
simplifcation + check customData to avoid overriding it
2022-11-09 11:17:07 +01:00
clement hector
94114d5ed0
add instance name and extension checks to filter only reviewMain file
2022-11-08 11:21:52 +01:00
clement hector
c0f2de08d9
get username from kitsu login
2022-11-07 16:11:38 +01:00
Felix David
49af7d9d2d
black line length
2022-07-29 18:47:32 +02:00
Felix David
7d23558ac0
Kitsu|Fix: Collect entities error cause of Python2
...
Fix #3552
2022-07-29 18:34:33 +02:00
Kaa Maurice
6e3fd1122b
Kitsu bugfix update assets attributes
2022-07-05 17:13:11 +02:00
Félix David
6976546505
cleaning
2022-05-17 11:51:58 +02:00
