Commit graph

2380 commits

Author SHA1 Message Date
Ondřej Samohel
2e40a26beb
Merge branch 'develop' into bugfix/OP-5883_3dsmax-Publishing-Deadline-jobs-from-RedShift 2023-05-31 18:13:14 +02:00
Milan Kolar
c18e1d384d
Merge pull request #4919 from Michaelredaa/kitsu-sync-specific-projects 2023-05-30 22:01:23 +02:00
Jakub Trllo
5fbae39a74
Ftrack: Role names are not case sensitive in ftrack event server status action (#5058)
* statuser is not case sensitive about role names

* safer role check
2023-05-30 13:32:27 +02:00
Milan Kolar
84b3f00203
Merge pull request #4910 from ynput/bugfix/escape-deadline-publish-path-arg 2023-05-29 23:22:11 +02:00
Kayla Man
e506d88ed3 style fix 2023-05-29 20:33:40 +08:00
Kayla Man
9d9eebfe09 using current file to render and add validator for deadline publish in max hosts 2023-05-29 19:25:49 +08:00
Kayla Man
0fccdaf5f5 use expected files instead of files 2023-05-29 15:54:55 +08:00
Kayla Man
11d750f1af Merge branch 'develop' into bugfix/OP-5883_3dsmax-Publishing-Deadline-jobs-from-RedShift 2023-05-29 12:58:39 +08:00
Kayla Man
f85051863c hound fix 2023-05-29 12:44:22 +08:00
Kayla Man
56642ac175 getting the filename from render settings and add save_scene before all the extractors running 2023-05-29 12:37:25 +08:00
Kayla Man
271d017bdb remove the print function, and set verify to true for payload in publishing job 2023-05-27 00:56:11 +08:00
Kayla Man
32562e0b39 give beauty name to RGB 2023-05-27 00:53:40 +08:00
Kayla Man
c14525f371 fix the wrong directory for rendering 2023-05-26 23:13:17 +08:00
Jakub Trllo
6843ae8532
General: Small code cleanups (#5034)
* make sure the message type is set and unset correctly

* Update dummy data in readme

* remove debug message from main thread callbacks

* removed unused import

* cleanup code in muster addon

* simplified 'get_publish_instance_label' function

* even better json file handling

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-05-26 14:44:47 +02:00
Kayla Man
4303b281aa hound fix 2023-05-26 19:38:05 +08:00
Kayla Man
2d3ba2af05 add _beauty to subset name 2023-05-26 19:36:14 +08:00
Kayla Man
e633cc7dec expected file can get the aov path 2023-05-26 18:19:50 +08:00
Kayla Man
bb16fbdb79 refactor the collect render in 3dsmax 2023-05-26 17:32:56 +08:00
Jakub Trllo
48b4934ee3
limit number of ftrack events to query at once (#5033) 2023-05-25 13:33:11 +02:00
Roy Nieterau
17a38c32a4
Enhancement: Improve logging levels and messages for artist facing publish reports (#5018)
* Tweak log levels and message to be more informative to artist in report page

* Tweak levels and clarity of logs

* Tweak levels and clarity of logs + tweak grammar

* Cosmetics

* Improve logging

* Simplify logging

* Convert to debug log if it's skipping thumbnail integration if there's no thumbnail whatsoever to integrate

* Tweak to debug since they only show representation ids hardly understandable to the artist

* Match logging message across hosts + include filepath for full clarity

* Tweak message to clarify it only starts checking and not that it requires filling + to debug log

* Tweak to debug log if there's basically no thumbnail to integrate at the end

* Tweak log levels

- Artist doesn't care what's prepared, especially since afterwards it's logged what gets written to the database anyway

* Log clearly it's processing a legacy instance

* Cosmetics
2023-05-24 10:54:31 +02:00
Petr Kalis
fe02a09312
Deadline: fix selection from multiple webservices (#5015)
* OP-4380 - override default DL from project settings

* OP-4380 - updated documentation
2023-05-24 10:01:59 +02:00
Jakub Ježek
8ff3ba95c3
Merge branch 'develop' into feature/OP-5548_Fusion-Deadline-and-publish 2023-05-22 15:00:57 +02:00
Félix David
87802d0620
Fix: Download last workfile doesn't work if wf not already downloaded (#4942) 2023-05-18 14:39:27 +02:00
Michael
0de8fd04bd
Merge branch 'develop' into kitsu-sync-specific-projects 2023-05-17 20:45:07 +03:00
Jakub Jezek
0f80ad01ec
adding deadline settings
including Pools
2023-05-17 14:16:49 +02:00
Jakub Jezek
37827f63ba
Merge branch 'develop' into feature/OP-5548_Fusion-Deadline-and-publish 2023-05-15 21:29:18 +02:00
Ember Light
78f8bbfd80
Kitsu - Add "image", "online" and "plate" to review families (#4923)
* Add kitsu review to the default png review's tags

* Add "image", "online" and "plate" as possible review families
2023-05-12 17:29:38 +02:00
Toke Jepsen
ab357eb03e
Addons directory (#4893)
* Add addons directory

* add addons dir to modules dirs automatically

---------

Co-authored-by: iLLiCiTiT <jakub.trllo@gmail.com>
2023-05-12 16:44:44 +02:00
Jakub Trllo
ce1e45f708
fix key assignment on instance data (#4966) 2023-05-12 16:35:10 +02:00
Jakub Jezek
78b0e3daa1
removing unusable attribute GPU 2023-05-12 13:35:15 +02:00
Jakub Jezek
fbee0a8b3c
pr comments 2023-05-12 11:07:50 +02:00
Kayla Man
be386a3688 hound fix 2023-05-11 17:05:56 +08:00
Kayla Man
9a6ae240e2 using currentfile for redshift renderer 2023-05-11 17:00:29 +08:00
Jakub Jezek
9cbbbe818c
deadline fusion: frame range taken from handles version 2023-05-10 11:19:40 +02:00
Jakub Jezek
aace680fa1
fusion deadline, rewriting to new instance data 2023-05-09 17:22:31 +02:00
Michael
ae7137a055
Merge branch 'develop' into kitsu-sync-specific-projects 2023-05-09 13:31:48 +03:00
Jakub Jezek
2cc22174a0
Merge branch 'enhancement/OP-5548_Fusion-saver-settings' into feature/OP-5548_Fusion-Deadline-and-publish 2023-05-08 14:46:32 +02:00
Michael reda
07cf84e648 add variable name to @click.option 2023-05-05 14:14:12 +02:00
Michael reda
8242e61ad8 update linting 2023-05-05 13:54:24 +02:00
Jakub Jezek
b9055d61af
POC wip 2023-05-04 17:42:16 +02:00
Petr Kalis
e7aa413038
AfterEffects: add review flag to each instance (#4884)
* OP-5657 - add artist control for review in AfterEffects

Artist can disable review to be created for particular publish.

* OP-5657 - add artist control for review in AfterEffects

Removed configuration for Deadline, should be controlled by what is on instance.

* OP-5657 - handle legacy instances

Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.

* OP-5657 - remove explicit review for all AE

Now handled directly on instance

* OP-5657 - fix - cannot remove now

Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.

* OP-5657 - fix - correct host name used

* OP-5657 - fix - correct handling of review

On local renders review should be added only from families, not from older approach through Settings.

Farm instance cannot have review in families or extract_review would get triggered even locally.

* OP-5657 - refactor - changed label

* OP-5657 - Hound

* OP-5657 - added explicitly skipping review

Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).

* OP-5657 - updated setting of review variable

instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.

* OP-5657 - fix adding review flag

* OP-5657 - updated test

Removed review for second instance.

* OP-5657 - refactor to context plugin

* OP-5657 - tie thumbnail to review for local render

Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
2023-05-04 12:16:58 +02:00
Michael
44e533ff33
Update sync_all_projects function with filtered projects 2023-05-03 20:20:43 +03:00
Michael
c5dd4d21ee
Add listen-only flag to sync 2023-05-03 20:16:23 +03:00
Michael
ad4f5876ce
update condition to sync specific projects 2023-05-03 12:40:32 +03:00
Michael
6e9b6f6bef
correct arg name in sync_all_projects 2023-05-03 12:38:42 +03:00
Michael
0a3d206680
solve syntex error 2023-05-03 12:23:17 +03:00
Michael
2a9a7d6fd4
handle reviews 2023-05-03 12:18:43 +03:00
Petr Kalis
fec104de8e
Fix: Locally copied version of last published workfile is not incremented (#4722)
* Fix: Locally copied version of last published workfile is not incremented

* fix subset first match

* correct anatomy name

* Fix typo and linting

* keep source filepath for further path conformation

* fetch also input dependencies of workfile

* required changes

* lint

* fix case only one subset

* Enhancement:  copy last workfile as reusable methods (#6)

* Enhancement: copy last published workfile as reusable methods (WiP)

* Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile

* Plugged in the new methods + minor changes

* Added docstrings, last workfile optional argument, and removed unused code

* Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix

* Refactoring and fixed double dots

* Added match subset_id and get representation method, plus clan up

* Removed unused vars

* Fixed some rebasing errors

* delinted unchanged code and renamed get_representation into get_representation_with_task

* This time it's really delinted, I hope...

* Update openpype/modules/sync_server/sync_server.py

reprenation isn't the right spelling (:

Co-authored-by: Félix David <felixg.david@gmail.com>

* Changes based on reviews

* Fixed non imperative docstring and missing space

* Fixed another non imperative docstring

* Update openpype/modules/sync_server/sync_server.py

Fixed typo

Co-authored-by: Félix David <felixg.david@gmail.com>

Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Félix David <felixg.david@gmail.com>

* Fix: syntax error

* fix single subset case

* Restore sync server enabled test in hook

* Python2 syntax

* renaming and missing key case handling

* Fix local workfile overwritten on update in some cases (#7)

* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)

* Changed regex search, clean up

* Readded mistakenly removed newline

* lint

* remove anticipated functions for cleaner PR

* remove funcs from entities.py

* change to get_last_workfile_with_version

* clean

* Update openpype/modules/sync_server/sync_server.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* removed get_last_published_workfile_path

* moved hook to sync server module

* fix lint

* Refactor - download only if not present

* Refactor - change to list instead of set

* Refactor - removing unnecessary code

last_published_workfile_path must exists or we wouldn't get there. Use version only from that.

* Refactor - removing unnecessary imports

* Added check for max fail tries

* Refactor - cleaned up how to get last workfile

* Updated docstrings

* Remove unused imports

Co-authored-by: Félix David <felixg.david@gmail.com>

* OP-5466 - run this on more DCC

* Updated documentation

* Fix - handle hero versions

Skip hero versions, look only for versioned published to get max version id.

* Hound

* Refactor - simplified download_last_published_workfile

Logic should be in pre hook

* Skip if no profile found

* Removed unwanted import

* Use collected project_doc

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Use cached project_settings

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

---------

Co-authored-by: Félix David <felixg.david@gmail.com>
Co-authored-by: Sharkitty <81646000+Sharkitty@users.noreply.github.com>
Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
2023-05-02 18:49:02 +02:00
Michael reda
84cef9d3cf handel long lines 2023-05-02 11:12:18 +02:00
Ondrej Samohel
557cbb72ce
♻️ escape rootless path 2023-04-27 11:26:57 +02:00