Commit graph

1209 commits

Author SHA1 Message Date
Roy Nieterau
053021eb64 Merge remote-tracking branch 'upstream/develop' into substance_integration 2023-04-03 11:33:00 +02:00
Roy Nieterau
74f73969ad
Remove "preview" data from representation (#4759)
* Remove "preview" data from representation

* pop "preview" from component in standalone publisher

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-31 17:08:58 +02:00
Jakub Ježek
d933917a53
Merge branch 'develop' into refactor/cleanup_grammar 2023-03-31 14:28:22 +02:00
Roy Nieterau
5b163fe84d
Apply suggestions from code review
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-30 22:40:44 +02:00
Jakub Trllo
d2e48426a6
add all sites of previous files to new files (#4737)
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
2023-03-30 19:04:44 +02:00
Roy Nieterau
3fae1f8521 Just some grammar tweaks 2023-03-30 13:59:22 +02:00
Toke Jepsen
b7f6589886
Merge branch 'develop' into feature/OP-3278_camera-focal-length 2023-03-29 11:12:09 +02:00
Petr Kalis
1531708236
Global: persistent staging directory for renders (#4583)
* OP-4258 - Settings for transient template

* OP-4258 - added collector for transient staging dir

Allows setting profiles to create persistent stagingDir.

* OP-4258 - implemented persistent stagingDir in cleanup

* OP-4258 - updated logging

* OP-4258 - updated settings

* OP-4258 - Hound

* OP-4258 - renamed class to better name

* OP-4258 - changed location of Settings

Should be used in create and collecting phase also.

* OP-4258 - remove version placeholder from transient template

It was discussed that it shouldn't be used for now.

* OP-4258 - extracted transient dir query logic

This should be used in collection and creation phase for DCCs which are storing staging dir path directly into nodes.

* OP-4258 - added use of scene_name placeholder in collector

DCC dependent, way how to implement versioning, might not be used.

* OP-4258 - fix scene_name

* OP-4258 - remove wrong defaults

* OP-4258 - added possibility of different template name

Studio might want to put renders to different place from caches.

* OP-4258 - renamed according to GH comments

* OP-4258 - use is active filter

* OP-4258 - use is active filter

* OP-4793 - added project_settings to signature

* OP-4793 - updated logging message

* OP-4793 - added documentation

* OP-4258 - fix function arguments

* OP-4258 - updates to documentation


* OP-4258 - added known issues to documentation

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-03-24 16:30:46 +01:00
Roy Nieterau
13aa1c82fa Merge remote-tracking branch 'upstream/develop' into substance_integration 2023-03-23 13:41:07 +01:00
Roy Nieterau
5b3af11f0f Fix the if statement 2023-03-23 11:04:25 +01:00
Roy Nieterau
4fdb31611d Allow to mark an instance to skip integration explicitly
Use `instance.data["integrate"] = False`
2023-03-23 11:03:54 +01:00
Roy Nieterau
f681e9843d
Extract Review code refactor (#3930)
* Tweak variable names

* Use `filter_profiles` from lib

* Fix type fallback

* Simplify additional family filters

* Use legacy_io.Session instead of os.environ

* Fix logging message

* Indent todo comment for better todo highlighting in Pycharm

* Simplify gap filling logic

* Optimize getting nearest frames

* Fix logic for nearest frame

- This fixes cases where nearest frame isn't directly the next frame

* Refactor `index` in variable `idx` to match `missing_idx` naming

* Use `filter_profiles` from lib

* Match family filter validation of extract review

* Fix typo `overscal` -> `overscan`

* Use `legacy_io.Session` instead of `os.environ`

* Remove unused import

* use 'KnownPublishError' instead of 'AssertionError'

* modify nearest frame logic in holes fill

* Fix unsupported indexing of clique Collection + slightly simplify

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
2023-03-23 09:50:28 +01:00
Toke Stuart Jepsen
22dac59ccf Store burnin data as dictionary directly. 2023-03-22 14:58:46 +00:00
Toke Stuart Jepsen
e9eb09e100 Initial working version 2023-03-22 12:58:33 +00:00
Roy Nieterau
28b424bf2f
Publisher: Windows reduce command window pop-ups during Publishing (#4672)
* Avoid command pop-ups during publishing (tip by @iLLiCiTiT)

* No need to pass creationflags because it's already done in `run_subprocess`

* Hide command window for `shell=True` calls

* Update openpype/lib/execute.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-22 12:13:21 +01:00
Roy Nieterau
96e184c8ca
Integrator: Enforce unique destination transfers, disallow overwrites in queued transfers (#4662)
* Fix #4656: Enforce unique destination transfer in Integrator

Note that this is per instance - it doesn't validate cross-instance destinations in the context

* Use explicit DuplicateDestinationError and raise as KnownPublishError
2023-03-21 15:29:19 +01:00
Petr Kalis
a0c599203e
Global: add tags field to thumbnail representation (#4660)
* Fix add tags field to thumbnail representation

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-03-21 10:42:06 +01:00
Roy Nieterau
c0a2a190e5 Merge remote-tracking branch 'upstream/develop' into substance_integration 2023-03-20 14:06:49 +01:00
Kayla Man
fa69594c70 creator, validator and extractor for point cloud from tyFlow 2023-03-17 22:56:00 +01:00
moonyuet
739b2db0f0 MaxScene Family introduction 2023-03-17 22:52:50 +01:00
Jakub Trllo
3159bcb878 Use right plugic class for 'CollectInstanceCommentDef' 2023-03-17 17:39:54 +01:00
Simone Barbieri
6754e97490
Merge branch 'develop' into feature/blender-review 2023-03-14 10:04:49 +00:00
Roy Nieterau
dc333560d2 Merge remote-tracking branch 'upstream/develop' into substance_integration 2023-03-13 22:50:55 +01:00
Jakub Trllo
b3636b9f55
General: Input representation ids are not ObjectIds (#4576)
* input representation ids are not ObjectIds during publishing

* changed set back to list

* use 'setdefault' to set 'inputVersions'

* added default value to 'get'

* Use default value in second loop too

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

* simplify variable assignment

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-03-07 13:45:49 +01:00
Jakub Ježek
f5ef4597b2
Merge pull request #4556 from ynput/feature/OP-5006_Nuke-publish-colorspaceData-from-rendered-images 2023-03-06 11:52:37 +01:00
Jakub Trllo
5efc9e0ff0
Editorial: Fix tasks removal (#4558)
Fix tasks removal in editorial
2023-03-06 11:00:02 +01:00
Roy Nieterau
6d01fb8e14 Merge remote-tracking branch 'upstream/develop' into substance_integration 2023-03-03 12:44:04 +01:00
Ondřej Samohel
e7cf87d3ac
Merge branch 'develop' into feature/OP-5006_Nuke-publish-colorspaceData-from-rendered-images 2023-03-02 11:47:13 +01:00
Petr Kalis
9f35ed2a63
Fix - store target_colorspace as new colorspace (#4544)
When transcoding into new colorspace, representation must carry this information instead original color space.
2023-02-28 16:33:18 +01:00
Jakub Jezek
ee3e346c8d
Global: refactory colormanaged exctractor into plugin mixin 2023-02-28 14:53:49 +01:00
Petr Kalis
72a3572d95 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 16:35:42 +01:00
Petr Kalis
9eaa0d1ff8 OP-4643 - split command line arguments to separate items
Reuse existing method from ExtractReview, put it into transcoding.py
2023-02-23 16:31:25 +01:00
Petr Kalis
cce048fd3e OP-4642 - refactored newly added representations 2023-02-23 16:30:54 +01:00
Petr Kalis
7f94f7ef71 OP-4643 - allow new repre to stay
One might want to delete outputs with 'delete' tag, but repre must stay there at least until extract_review.

More universal new tag might be created for this.
2023-02-23 16:29:05 +01:00
Petr Kalis
195e9b4360 OP-4643 - name of new representation from output definition key 2023-02-23 16:27:24 +01:00
Petr Kalis
c038fbf884 OP-4643 - fix no tags in repre 2023-02-23 16:26:25 +01:00
Petr Kalis
d2f8407111 OP-4643 - fix files to delete 2023-02-23 16:26:24 +01:00
Petr Kalis
64a142ef64 OP-4643 - fix for full file paths 2023-02-23 16:05:31 +01:00
Petr Kalis
945f1dfe55 OP-4643 - added explicit enum for transcoding type
As transcoding info (colorspace, display) might be collected from DCC, it must be explicit which should be used.
2023-02-23 15:39:55 +01:00
Petr Kalis
7ecf6fde48 OP-4643 - fix colorspace from DCC
representation["colorspaceData"]["colorspace"] is only input colorspace
2023-02-23 15:39:55 +01:00
Petr Kalis
f30b3c5230 OP-4643 - allow colorspace to be empty and collected from DCC 2023-02-23 15:39:55 +01:00
Petr Kalis
559d54c3a1 Revert "OP-4643 - split command line arguments to separate items"
This reverts commit deaad39437.
2023-02-23 15:39:55 +01:00
Petr Kalis
51c54e1aa1 OP-4643 - refactor - changed existence check 2023-02-23 15:39:54 +01:00
Petr Kalis
984974d7e0 OP-4643 - split command line arguments to separate items
Reuse existing method from ExtractReview, put it into transcoding.py
2023-02-23 15:39:54 +01:00
Petr Kalis
cf066d1441 OP-4643 - fixed subset filtering
Co-authored-by: Toke Jepsen <tokejepsen@gmail.com>
2023-02-23 15:39:54 +01:00
Petr Kalis
263d3dccc2 OP-4642 - refactored query of representations
line 73 returns if no representations.
2023-02-23 15:39:54 +01:00
Petr Kalis
0834b7564b OP-4642 - refactored newly added representations 2023-02-23 15:39:54 +01:00
Petr Kalis
3921982365 OP-4642 - added additional command arguments for oiiotool
Some extension requires special command line arguments (.dpx and binary depth).
2023-02-23 15:39:54 +01:00
Petr Kalis
1d12316ee1 OP-4643 - allow new repre to stay
One might want to delete outputs with 'delete' tag, but repre must stay there at least until extract_review.

More universal new tag might be created for this.
2023-02-23 15:39:53 +01:00
Petr Kalis
82b44da739 OP-4643 - fix logging
Wrong variable used
2023-02-23 15:39:53 +01:00