Commit graph

2658 commits

Author SHA1 Message Date
Roy Nieterau
fe58cb3c7c
Enhancement: More descriptive error messages for Loaders (#5227)
* More descriptive error messages for Loaders

* Restructure error reporting
2023-07-03 13:42:00 +02:00
Jakub Trllo
6e69d3a87f
Publisher: Fix disappearing actions (#5184)
* store action ids by plugin ids

* fix underscore in variables

* fix access to action
2023-06-23 17:48:09 +02:00
Roy Nieterau
7973c5fbe0
Workfile Builder UI: Workfile builder window is not modal (#5131)
* Open create placeholder window as regular window instead of modal dialog

* Allow to create even as root node without a parent selection

* Cosmetics: typo

* Keep create dialog open after create so user can directly create another with similar settings

* Match functionality in Nuke to the one in Maya

---------

Co-authored-by: Roy Nieterau <roy@colorbleed.nl>
2023-06-23 16:27:37 +02:00
Jakub Trllo
3ffef444ba
Publisher: Edge case fixes (#5165)
* do not crash whole controller because of invalid exception

* handle missing instance label

* fix also list view
2023-06-23 16:11:23 +02:00
Alexey Bogomolov
a4c63c12cf
Add height, width and fps setup to project manager (#5075)
* add width, height and fps setup

* add corresponding ui tweaks

* update docstring

* remove unnecessary fallbacks

* remove print

* hound

* remove whitespace

* revert operations change

* wip commit project update with new data

* formatting

* update the project data correctly

* Update openpype/tools/project_manager/project_manager/widgets.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* show default settings, use spinbox to validate values
add pixel aspec, frame start, frame end

* formatting

* get default anatomy settings properly

* check if singlestep is set

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* not used

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* mindless code copying is evil, removed unnecesary parts

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Update openpype/tools/project_manager/project_manager/widgets.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Update openpype/tools/project_manager/project_manager/widgets.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* remove unused import

* use integer or float instead of text

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* import PixmapLabel from 'utils'

* fix spinbox field length for macos

* set aspect decimals to 2

* remove set size policy

* set field growth policy for macos

* add newline

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-06-19 13:15:34 +02:00
Jakub Trllo
3d41ee6591
TrayPublisher & StandalonePublisher: Specify version (#5142)
* modified simple creator plugin to be able handle version control

* added 'allow_version_control' to simple creators

* don't remove 'create_context' from pyblish context during publishing

* implemented validator for existing version override

* actually fill version on collected instances

* version can be again changed from standalone publisher

* added comment to collector

* make sure the version is set always to int

* removed unused import

* disable validator if is disabled

* fix filtered instances loop
2023-06-16 16:26:04 +02:00
Jakub Trllo
f9a64192b3
fix match check of save sequence (#5148) 2023-06-16 10:50:38 +02:00
Clément Hector
59b7e265da
add label to matching family (#5128)
* add label to matching family

* Update openpype/tools/creator/model.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-06-15 10:13:49 +02:00
Oscar Domingo
1a27169c15
Merge pull request #5119 from ynput/enhancement/OP-5919_keep_variant_name_after_creating_subset
Keep `publisher.create_widget` variant when creating subsets
2023-06-13 10:58:35 +01:00
Jakub Trllo
b24b4a9d5f
Loader: Hide inactive versions in UI (#5100)
* Function 'get_last_versions' have active filter

* filter in active versions in loader
2023-06-08 11:54:41 +02:00
Oscar Domingo
f423ebcfcb Keep publisher.create_widget variant when creating subsets
Whenever a person is creating a subset to publish, the "creator" widget
resets (where you choose the variant, product, etc.) so if the person
is publishing several images of the a variant which is not the default
one, they have to keep selecting the correct one after every "create".

This commit resets the original variant upon successful creation of a
subset for publishing.
2023-06-08 10:40:46 +01:00
Fabià Serra Arrizabalaga
29c0b8a12a
Sort actions by label if it exists instead of name (#5106) 2023-06-06 18:51:44 +02:00
Milan Kolar
6242413349
Merge pull request #5093 from fabiaserra/feature/user_details_workfiles 2023-06-05 22:54:05 +02:00
Fabià Serra Arrizabalaga
bde1595359
Update openpype/tools/workfiles/window.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-06-05 15:17:10 +02:00
Fabià Serra Arrizabalaga
7c70ea968d
Update openpype/tools/workfiles/window.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-06-05 15:07:35 +02:00
Fabià Serra Arrizabalaga
c12e6995de
Update openpype/tools/workfiles/window.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-06-05 14:49:58 +02:00
Ondřej Samohel
6a8405316b
Merge pull request #5089 from fabiaserra/feature/publisher_window_flags 2023-06-05 12:16:02 +02:00
Fabià Serra Arrizabalaga
9c4e1ad4b1 Only add User details if platform isn't windows 2023-06-02 18:08:28 +02:00
Fabià Serra Arrizabalaga
aa7dceb79c Add 'user' details on workfile manager details pane tab for Unix platform 2023-06-02 18:04:22 +02:00
Jakub Trllo
e64779b345
fix restart arguments in tray (#5085) 2023-06-02 15:07:55 +02:00
Fabià Serra Arrizabalaga
4eaeb5682c Remove default windowFlags as it makes the publisher window not show minimize/maximize hints 2023-06-02 00:17:37 +02:00
Jakub Trllo
26b99db61e removed unused import 2023-05-30 15:18:53 +02:00
Jakub Trllo
4bc61d1c89 Fix border widget 2023-05-30 13:33:58 +02:00
Jakub Trllo
6607037710
Publisher: Call explicitly prepared tab methods (#5044)
* call explicitly prepared tab methods

* add an overlay message
2023-05-29 11:25:14 +02:00
Jakub Trllo
6843ae8532
General: Small code cleanups (#5034)
* make sure the message type is set and unset correctly

* Update dummy data in readme

* remove debug message from main thread callbacks

* removed unused import

* cleanup code in muster addon

* simplified 'get_publish_instance_label' function

* even better json file handling

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-05-26 14:44:47 +02:00
Jakub Trllo
124493affd
Publisher: UI works with instances without label (#5032)
* implemented helper function to get instance label

* use 'get_publish_instance_label' in some of existing plugins

* use 'get_publish_instance_label' in publisher controller
2023-05-25 11:51:44 +02:00
Roy Nieterau
41ae41d751
Enhancement/publisher: Remove "hit play to continue" label on continue (#5029)
* Clear message label on publish so that on "continue" it does not persist the "Hit play to continue" message

* Clear main label on reset since the label isn't visible anyway

* Remove unnecessary comment

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-05-25 10:00:29 +02:00
Jakub Trllo
a73d19b612
Publisher: Show instances in report page (#4915)
* renamed 'validations_widget.py' to 'report_page.py'

* Implemented base logic and widgets for logs

* make one report page

* added missing imports

* added missing constants

* move and rename 'VerticallScrollArea' to 'VerticalScrollArea'

* Validation erro item have id

* use 'ReportPageWidget' in window

* change 'bg-button-hover' key to 'bg-buttons-hover' in style colors

* move publish actions widgets

* Refactored how validation error title is showed

* remove item id from validation error item but add id to group items

* remove margins from actions widget

* shrink publish frame on finished publishing

* fix dash line draw

* add missing styles

* fix dash line in thumbnail widget

* added crash widget and changed layout a little

* added infor overlay message

* export and copy report happens in main window

* fix docstrings

* added per plugin filtering for validation errors

* added implementation of 'FlowLayout'

* actions buttons are in flow layout

* fix actions order

* implemented expanding text edit widget

* expand button has some signals and properties

* description and details are separated widgets

* fix typo

* added constans to '__all__'

* parse icon def is a function

* change layout of widgets

* fix log filtering

* added state icon to instances

* fix pyside6 issues

* implemented 'ClassicExpandBtnLabel' with arrow images

* modified details separator

* added some spacing to layouts

* fix syle of description inputs and progress color

* removed unused import

* add 'is_validation_error' to errored result

* validation error has different icon in logs view

* added plugin name to ValueError if happens

* spacer before detail inputs moved out of detals widget

* fix actions visible in craash report

* ignore pyblish base classes

* filter base plugins in discovery

* use 'is' comparison instead of '__eq__'

* fix action error handling

* Fix handling of 'None' values in comparison

* formatting fix

* Report instance card have same margins as in create mode

* publish instances are grouped by family

* log messages are rstripped
2023-05-23 18:16:05 +02:00
kaamaurice
76352bdfea fix error dialog missing parent arg 2023-05-05 15:07:30 +02:00
Jakub Trllo
38347ece5a
Publisher: Small style changes (#4894)
* border hover has color without alpha

* changed border radius to 0.2em

* removed border from scroll area

* variant hint button has 0.5em width

* inputs in attribute definitions have smaller padding

* label is shown only to value inputs and added tooltips

* change spacing for attribute befinitions

* align labels to right

* implemented 'ComboBox' which ignores wheel events and has styled delegate

* PixmalLabel has minimum sizeHint

* cards are smaller

* renamed 'Options' to 'Context'

* implemented active state changes in card view

* set object name of main window to "PublishWindow"

* plugin don't have to pass 'title' to an error

* fix PySide6 support for custom keysequences

* check for exact match for all bindings

* added validation of exact match for save shortcut
2023-04-25 10:37:49 +02:00
Roy Nieterau
4ed1c1f65d
Enhancement: Fix PySide 6.5 support for loader (#4900)
* Reverse inheritance order to avoid PySide6.5 bug `PYSIDE-2294` & `PYSIDE-2304`

* Fix PySide6 support
2023-04-25 10:29:12 +02:00
Jakub Trllo
ebcd48d138
Publisher: Keep track about current context and fix context selection widget (#4892)
* keep track about last context so it can be updated on context change

* don't use '_asset_name' attribute for validation of selected asset

* use current context after publisher window close
2023-04-24 17:36:26 +02:00
Jakub Trllo
ed1fd82ff2
Scene inventory: Model refresh fix with cherry picking (#4895)
* fix bug in model refresh

* fix signal callbacks

* rename '_refresh_callback' to '_on_refresh_request'
2023-04-24 13:16:38 +02:00
Roy Nieterau
b751c539c3
Publisher: Make sure to reset asset widget when hidden and reshown (#4886)
* Make sure to reset asset widget when hidden and reshown

* change '_soft_reset_enabled' only on controller reset

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
2023-04-21 12:22:11 +02:00
Roy Nieterau
a2f79419bc
Clear publisher comment on successful publish or on window close (#4885) 2023-04-21 11:59:41 +02:00
Roy Nieterau
b05afaa837
Global: Optimize anatomy formatting by only formatting used templates instead (#4784)
* TemplatesDict can create different type of template

* anatomy templates can be formatted on their own

* return objected templates on get item

* '_rootless_path' is public classmethod 'rootless_path_from_result'

* 'AnatomyStringTemplate' expect anatomy templates

* remove key getters

* fix typo 'create_ojected_templates' -> 'create_objected_templates'

* Fix type of argument

* Fix long line

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Optimize formatting to use single template formatting instead of formatting full anatomy

* Use format strict + code cosmetics

* Get template from the formatted data

* Update openpype/plugins/publish/integrate_legacy.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Cosmetics

* Move template obj definition for path up + rename to `path_template_obj`

* Refactor more cases from `anatomy.format` to template obj `.format_strict`

* Refactor more cases from `anatomy.format` to template obj `.format_strict`

* Refactor more cases from `anatomy.format` to template obj `.format_strict`

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-04-17 14:53:15 +02:00
Ondřej Samohel
7dc0bfbd5d
Merge branch 'develop' into feature/OP-5529_Settings-Allow-setting-a-size-hint-for-text-fields 2023-04-13 12:08:55 +02:00
Jakub Trllo
380930e06f
Settings: Version settings popup fix (#4822)
* added no mouse relay attribute to popup

* completer is not shown if widget is not visible

* remove unused import
2023-04-11 11:41:08 +02:00
Jakub Trllo
caf25ddf13
Publisher: Plugin active attribute is respected (#4798)
* added helper function to get publish plugin settings

* use new function to get plugin settings

* remove disabled settings when settings are applied

* added some comments

* added check for active state of publish plugin

* docstring changes

* limit the active state check only for 'OptionalPyblishPluginMixin'

* apply suggestions

* show plugin name if label is not available
2023-04-11 10:52:09 +02:00
Jakub Trllo
e4e6b8dc9a Use minimum lines to affect minimum size hint 2023-04-08 17:24:07 +02:00
Jakub Trllo
199f70e1ca
add missing variable 'handles' to loader (#4781) 2023-04-05 14:35:07 +02:00
Roy Nieterau
0b590ea31d Merge remote-tracking branch 'upstream/develop' into refactor/remove_handles
# Conflicts:
#	openpype/hosts/maya/plugins/publish/collect_review.py
2023-04-03 18:07:15 +02:00
Petr Kalis
177cce233c
Workfiles: keep Browse always enabled (#4766)
* OP-5494 - keep Browse always enable din Workfiles

Browse might make sense even if there are no workfiles present, better in that case it makes the most sense (eg. I want to locate workfile from outside).

* use last existing directory of workfile root instead of goint to cwd

* use lstring instead of index cut

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
2023-04-03 18:01:33 +02:00
Jakub Ježek
c0d4ab010a
Merge branch 'develop' into refactor/remove_handles 2023-03-31 21:58:53 +02:00
Roy Nieterau
3fae1f8521 Just some grammar tweaks 2023-03-30 13:59:22 +02:00
Roy Nieterau
d958f989e0 Remove "handles" backwards compatibility 2023-03-29 23:57:35 +02:00
Jakub Trllo
2244a634b2
change minimum frame start/end to '0' (#4719) 2023-03-27 16:06:52 +02:00
Jakub Ježek
2bbb91c8c9
Merge pull request #4680 from BigRoy/docs_minor_typo 2023-03-24 10:58:35 +01:00
Jakub Trllo
0f6d969867
fix shortcut key sequence check (#4694) 2023-03-23 14:35:58 +01:00
Jakub Trllo
d0f083ec19
Publisher: Explicit save (#4676)
* added save button class

* added save button to window

* workfiles is also part of context in CreateContext to be able check if context changed

* window cares about trigger of convertors

* use abstractproperty with property and abstractmethod decorators

* save changes happens using main window and can be blocked

* fix pyside compatibility

* use create context to get current context names

* Fix docstring label

* added shortcuts for save and reset

* change control string matching for macos

* added 'publish_has_started' property

* allow save only if publishing did not start yet

* rename 'get_selected_convertors' to 'get_selected_legacy_convertors' and added docstrings

* Added Saved changes

* disable instances toggle when publishing started

* Fix reset button tooltip

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

* Use QKeySequence to string for tooltips

* added example output

* use predefined method to emit card message

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-03-23 12:52:25 +01:00