In Nuke is correctly `prerendere.farm` in families, which wasn't handled here. Eventually this query should be simplified only to `prerender.farm`, but this way it is safer for now.
* make sure the message type is set and unset correctly
* Update dummy data in readme
* remove debug message from main thread callbacks
* removed unused import
* cleanup code in muster addon
* simplified 'get_publish_instance_label' function
* even better json file handling
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
---------
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
* Tweak log levels and message to be more informative to artist in report page
* Tweak levels and clarity of logs
* Tweak levels and clarity of logs + tweak grammar
* Cosmetics
* Improve logging
* Simplify logging
* Convert to debug log if it's skipping thumbnail integration if there's no thumbnail whatsoever to integrate
* Tweak to debug since they only show representation ids hardly understandable to the artist
* Match logging message across hosts + include filepath for full clarity
* Tweak message to clarify it only starts checking and not that it requires filling + to debug log
* Tweak to debug log if there's basically no thumbnail to integrate at the end
* Tweak log levels
- Artist doesn't care what's prepared, especially since afterwards it's logged what gets written to the database anyway
* Log clearly it's processing a legacy instance
* Cosmetics
* OP-5657 - add artist control for review in AfterEffects
Artist can disable review to be created for particular publish.
* OP-5657 - add artist control for review in AfterEffects
Removed configuration for Deadline, should be controlled by what is on instance.
* OP-5657 - handle legacy instances
Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.
* OP-5657 - remove explicit review for all AE
Now handled directly on instance
* OP-5657 - fix - cannot remove now
Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.
* OP-5657 - fix - correct host name used
* OP-5657 - fix - correct handling of review
On local renders review should be added only from families, not from older approach through Settings.
Farm instance cannot have review in families or extract_review would get triggered even locally.
* OP-5657 - refactor - changed label
* OP-5657 - Hound
* OP-5657 - added explicitly skipping review
Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).
* OP-5657 - updated setting of review variable
instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.
* OP-5657 - fix adding review flag
* OP-5657 - updated test
Removed review for second instance.
* OP-5657 - refactor to context plugin
* OP-5657 - tie thumbnail to review for local render
Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.