* OP-5657 - add artist control for review in AfterEffects
Artist can disable review to be created for particular publish.
* OP-5657 - add artist control for review in AfterEffects
Removed configuration for Deadline, should be controlled by what is on instance.
* OP-5657 - handle legacy instances
Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.
* OP-5657 - remove explicit review for all AE
Now handled directly on instance
* OP-5657 - fix - cannot remove now
Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.
* OP-5657 - fix - correct host name used
* OP-5657 - fix - correct handling of review
On local renders review should be added only from families, not from older approach through Settings.
Farm instance cannot have review in families or extract_review would get triggered even locally.
* OP-5657 - refactor - changed label
* OP-5657 - Hound
* OP-5657 - added explicitly skipping review
Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).
* OP-5657 - updated setting of review variable
instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.
* OP-5657 - fix adding review flag
* OP-5657 - updated test
Removed review for second instance.
* OP-5657 - refactor to context plugin
* OP-5657 - tie thumbnail to review for local render
Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
* Fix: Locally copied version of last published workfile is not incremented
* fix subset first match
* correct anatomy name
* Fix typo and linting
* keep source filepath for further path conformation
* fetch also input dependencies of workfile
* required changes
* lint
* fix case only one subset
* Enhancement: copy last workfile as reusable methods (#6)
* Enhancement: copy last published workfile as reusable methods (WiP)
* Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile
* Plugged in the new methods + minor changes
* Added docstrings, last workfile optional argument, and removed unused code
* Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix
* Refactoring and fixed double dots
* Added match subset_id and get representation method, plus clan up
* Removed unused vars
* Fixed some rebasing errors
* delinted unchanged code and renamed get_representation into get_representation_with_task
* This time it's really delinted, I hope...
* Update openpype/modules/sync_server/sync_server.py
reprenation isn't the right spelling (:
Co-authored-by: Félix David <felixg.david@gmail.com>
* Changes based on reviews
* Fixed non imperative docstring and missing space
* Fixed another non imperative docstring
* Update openpype/modules/sync_server/sync_server.py
Fixed typo
Co-authored-by: Félix David <felixg.david@gmail.com>
Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Félix David <felixg.david@gmail.com>
* Fix: syntax error
* fix single subset case
* Restore sync server enabled test in hook
* Python2 syntax
* renaming and missing key case handling
* Fix local workfile overwritten on update in some cases (#7)
* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)
* Changed regex search, clean up
* Readded mistakenly removed newline
* lint
* remove anticipated functions for cleaner PR
* remove funcs from entities.py
* change to get_last_workfile_with_version
* clean
* Update openpype/modules/sync_server/sync_server.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* removed get_last_published_workfile_path
* moved hook to sync server module
* fix lint
* Refactor - download only if not present
* Refactor - change to list instead of set
* Refactor - removing unnecessary code
last_published_workfile_path must exists or we wouldn't get there. Use version only from that.
* Refactor - removing unnecessary imports
* Added check for max fail tries
* Refactor - cleaned up how to get last workfile
* Updated docstrings
* Remove unused imports
Co-authored-by: Félix David <felixg.david@gmail.com>
* OP-5466 - run this on more DCC
* Updated documentation
* Fix - handle hero versions
Skip hero versions, look only for versioned published to get max version id.
* Hound
* Refactor - simplified download_last_published_workfile
Logic should be in pre hook
* Skip if no profile found
* Removed unwanted import
* Use collected project_doc
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* Use cached project_settings
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
---------
Co-authored-by: Félix David <felixg.david@gmail.com>
Co-authored-by: Sharkitty <81646000+Sharkitty@users.noreply.github.com>
Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
* TemplatesDict can create different type of template
* anatomy templates can be formatted on their own
* return objected templates on get item
* '_rootless_path' is public classmethod 'rootless_path_from_result'
* 'AnatomyStringTemplate' expect anatomy templates
* remove key getters
* fix typo 'create_ojected_templates' -> 'create_objected_templates'
* Fix type of argument
* Fix long line
* Optimize formatting to use single template formatting instead of formatting full anatomy
* Optimize formatting to use single template formatting instead of formatting full anatomy
* Optimize formatting to use single template formatting instead of formatting full anatomy
* Optimize formatting to use single template formatting instead of formatting full anatomy
* Optimize formatting to use single template formatting instead of formatting full anatomy
* Optimize formatting to use single template formatting instead of formatting full anatomy
* Optimize formatting to use single template formatting instead of formatting full anatomy
* Use format strict + code cosmetics
* Get template from the formatted data
* Update openpype/plugins/publish/integrate_legacy.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* Cosmetics
* Move template obj definition for path up + rename to `path_template_obj`
* Refactor more cases from `anatomy.format` to template obj `.format_strict`
* Refactor more cases from `anatomy.format` to template obj `.format_strict`
* Refactor more cases from `anatomy.format` to template obj `.format_strict`
---------
Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* update openpype projects status from kitsu settings
* fix linting errors
* get all projects and verify the project status for each project
* optimizing project status name verification
* sync only if project exists and is active in OP
* remove noqa
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* break from all_status for loop and add comment for non sync projects
---------
Co-authored-by: jeremy.oblet <jeremy.oblet@fixstudio.com>
Co-authored-by: Thomas Fricard <tfricard@ws114.prs.vfx.int>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* modify action to use 'CustomAttributeValue' and fix bugs
* modify and fix event handler to push hierarchical values
* added few smaller comments
* removed unused variables
* Match family and families
* Allow kitsu note to not have set comment and capture it without erroring in IntegrateKitsuReview
* Allow fallback to context for instance `task`
* Shush hound
* Refactor variable names
* Enhancement: Allowing kitsu not status exceptions
* Update openpype/modules/kitsu/plugins/publish/integrate_kitsu_note.py
Co-authored-by: Félix David <felixg.david@gmail.com>
* adding equal/not equal option
* Making equal/not equal option available at for every list item
* Changed into , renamed into , added documentation
* Using upper cases during check, so the new settings aren't case sensitive
* Linting little detail
* Renaming Equality into Condition, new screenshot with both equal and not equal shown on it
* Update website/docs/module_kitsu.md
README adjustments
Co-authored-by: Félix David <felixg.david@gmail.com>
* Changes needed to resolve conflict
* Changing context into instance where appropriate
* Minor change to avoid changing a line that doesn't need to be changed
* Turning exceptions into conditions. Making checks positive instead of negative. Changing implementation based on suggestions.
---------
Co-authored-by: Félix David <felixg.david@gmail.com>
