Commit graph

30295 commits

Author SHA1 Message Date
Petr Kalis
fec104de8e
Fix: Locally copied version of last published workfile is not incremented (#4722)
* Fix: Locally copied version of last published workfile is not incremented

* fix subset first match

* correct anatomy name

* Fix typo and linting

* keep source filepath for further path conformation

* fetch also input dependencies of workfile

* required changes

* lint

* fix case only one subset

* Enhancement:  copy last workfile as reusable methods (#6)

* Enhancement: copy last published workfile as reusable methods (WiP)

* Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile

* Plugged in the new methods + minor changes

* Added docstrings, last workfile optional argument, and removed unused code

* Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix

* Refactoring and fixed double dots

* Added match subset_id and get representation method, plus clan up

* Removed unused vars

* Fixed some rebasing errors

* delinted unchanged code and renamed get_representation into get_representation_with_task

* This time it's really delinted, I hope...

* Update openpype/modules/sync_server/sync_server.py

reprenation isn't the right spelling (:

Co-authored-by: Félix David <felixg.david@gmail.com>

* Changes based on reviews

* Fixed non imperative docstring and missing space

* Fixed another non imperative docstring

* Update openpype/modules/sync_server/sync_server.py

Fixed typo

Co-authored-by: Félix David <felixg.david@gmail.com>

Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Félix David <felixg.david@gmail.com>

* Fix: syntax error

* fix single subset case

* Restore sync server enabled test in hook

* Python2 syntax

* renaming and missing key case handling

* Fix local workfile overwritten on update in some cases (#7)

* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)

* Changed regex search, clean up

* Readded mistakenly removed newline

* lint

* remove anticipated functions for cleaner PR

* remove funcs from entities.py

* change to get_last_workfile_with_version

* clean

* Update openpype/modules/sync_server/sync_server.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* removed get_last_published_workfile_path

* moved hook to sync server module

* fix lint

* Refactor - download only if not present

* Refactor - change to list instead of set

* Refactor - removing unnecessary code

last_published_workfile_path must exists or we wouldn't get there. Use version only from that.

* Refactor - removing unnecessary imports

* Added check for max fail tries

* Refactor - cleaned up how to get last workfile

* Updated docstrings

* Remove unused imports

Co-authored-by: Félix David <felixg.david@gmail.com>

* OP-5466 - run this on more DCC

* Updated documentation

* Fix - handle hero versions

Skip hero versions, look only for versioned published to get max version id.

* Hound

* Refactor - simplified download_last_published_workfile

Logic should be in pre hook

* Skip if no profile found

* Removed unwanted import

* Use collected project_doc

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* Use cached project_settings

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

---------

Co-authored-by: Félix David <felixg.david@gmail.com>
Co-authored-by: Sharkitty <81646000+Sharkitty@users.noreply.github.com>
Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
2023-05-02 18:49:02 +02:00
Petr Kalis
b8ce6e9e9c
Photoshop: add autocreators for review and flat image (#4871)
* OP-5656 - added auto creator for review in PS

Review instance should be togglable.
Review instance needs to be created for non publisher based workflows.

* OP-5656 - refactored names

* OP-5656 - refactored names

* OP-5656 - new auto creator for flat image

In old version flat image was created if no instances were created. Explicit auto creator added for clarity.

Standardization of state of plugins

* OP-5656 - updated according to auto image creator

Subset template should be used from autocreator and not be separate.

* OP-5656 - fix proper creator name

* OP-5656 - fix log message

* OP-5656 - fix use enable state

* OP-5656 - fix formatting

* OP-5656 - add review toggle to image instance

For special cases where each image should have separate review.

* OP-5656 - fix description

* OP-5656 - fix not present asset and task in instance context

* OP-5656 - refactor - both auto creators should use same class

Provided separate description.

* OP-5656 - fix - propagate review to families

Image and auto image could have now review flag.
Bottom logic is only for Webpublisher.

* OP-5656 - fix - rename review files to avaid collision

Image family produces jpg and png, jpg review would clash with name. It should be replaced by 'jpg_jpg'.

* OP-5656 - fix - limit additional auto created only on WP

In artist based publishing auto image would be created by auto creator (if enabled). Artist might want to disable image creation.

* OP-5656 - added mark_for_review flag to Publish tab

* OP-5656 - fixes for auto creator

* OP-5656 - fixe - outputDef not needed

outputDef should contain dict of output definition. In PS it doesn't make sense as it has separate extract_review without output definitions.

* OP-5656 - added persistency of changes to auto creators

Changes as enabling/disabling, changing review flag should persist.

* OP-5656 - added documentation for admins

* OP-5656 - added link to new documentation for admins

* OP-5656 - Hound

* OP-5656 - Hound

* OP-5656 - fix shared families list

* OP-5656 - added default variant for review and workfile creator

For workfile Main was default variant, "" was for review.

* OP-5656 - fix - use values from Settings

* OP-5656 - fix - use original name of review for main review family

outputName cannot be in repre or file would have ..._jpg.jpg

* OP-5656 - refactor - standardized settings

Active by default denotes if created instance is active (eg. publishable) when created.

* OP-5656 - fixes for skipping collecting auto_image

data["ids"] are necessary for extracting. Members are physical layers in image, ids are "virtual" items, won't get grouped into real image instance.

* OP-5656 - reworked auto collectors

This allows to use automatic test for proper testing.

* OP-5656 - added automatic tests

* OP-5656 - fixes for auto collectors

* OP-5656 - removed unnecessary collector

Logic moved to auto collectors.

* OP-5656 - Hound
2023-05-02 11:19:50 +02:00
ynbot
7dbf2cd613
[Automated] Merged main into develop 2023-04-29 05:25:19 +02:00
Ynbot
37d7a87fd1 [Automated] Bump version 2023-04-29 03:25:06 +00:00
ynbot
b3c98702d7
[Automated] Merged develop into main 2023-04-29 05:24:25 +02:00
Jakub Trllo
4107874eb9
Project packager: Backup and restore can store only database (#4879)
* added helper functions to client mongo api

* pack and unpack project functions can work without project files

* added flag argument to pack project command to zip only project files

* unpack project has also only project argument

* Fix extractions
2023-04-27 23:41:00 +02:00
ynbot
dc527e3c5e
[Automated] Merged main into develop 2023-04-26 05:25:49 +02:00
Ynbot
a724bd1c77 [Automated] Bump version 2023-04-26 03:25:35 +00:00
ynbot
d1685dbf4e
[Automated] Merged develop into main 2023-04-26 05:24:54 +02:00
Jakub Trllo
38347ece5a
Publisher: Small style changes (#4894)
* border hover has color without alpha

* changed border radius to 0.2em

* removed border from scroll area

* variant hint button has 0.5em width

* inputs in attribute definitions have smaller padding

* label is shown only to value inputs and added tooltips

* change spacing for attribute befinitions

* align labels to right

* implemented 'ComboBox' which ignores wheel events and has styled delegate

* PixmalLabel has minimum sizeHint

* cards are smaller

* renamed 'Options' to 'Context'

* implemented active state changes in card view

* set object name of main window to "PublishWindow"

* plugin don't have to pass 'title' to an error

* fix PySide6 support for custom keysequences

* check for exact match for all bindings

* added validation of exact match for save shortcut
2023-04-25 10:37:49 +02:00
Roy Nieterau
4ed1c1f65d
Enhancement: Fix PySide 6.5 support for loader (#4900)
* Reverse inheritance order to avoid PySide6.5 bug `PYSIDE-2294` & `PYSIDE-2304`

* Fix PySide6 support
2023-04-25 10:29:12 +02:00
Ynbot
0567701ddb chore(): update bug report / version 2023-04-25 06:32:26 +00:00
Jakub Jezek
0ef59fcb39
adding ci user and email 2023-04-25 08:18:46 +02:00
Roy Nieterau
5595762164
Fusion: Simplify creator icons code (#4899)
* Simplify setting creator icons

* Use font-awesome 5 explicitly
2023-04-24 17:47:33 +02:00
ynbot
2133a96b20
[Automated] Merged release main into develop 2023-04-24 17:42:33 +02:00
Ynbot
afa3f563e4 [Automated] Release 2023-04-24 15:41:57 +00:00
ynbot
9b4ad20dfd
[Automated] Merged develop into main 2023-04-24 17:41:41 +02:00
64qam
d85553bf18
Merge pull request #4897 from ynput/bugfix/nuke-prerender-review
Nuke: Pre-render and missing review flag on instance causing crash
2023-04-24 17:38:33 +02:00
Jakub Trllo
ebcd48d138
Publisher: Keep track about current context and fix context selection widget (#4892)
* keep track about last context so it can be updated on context change

* don't use '_asset_name' attribute for validation of selected asset

* use current context after publisher window close
2023-04-24 17:36:26 +02:00
Jakub Trllo
ed1fd82ff2
Scene inventory: Model refresh fix with cherry picking (#4895)
* fix bug in model refresh

* fix signal callbacks

* rename '_refresh_callback' to '_on_refresh_request'
2023-04-24 13:16:38 +02:00
Ondrej Samohel
60d386b127
🐛 fix missing review flag on instance with pre-render 2023-04-24 12:53:17 +02:00
64qam
f669e7d453
Merge pull request #4887 from ynput/bugfix/OP-5764_nuke-slate-workflow-broken-on-deadline
Nuke: fixed broken slate workflow once published on deadline
2023-04-24 12:51:08 +02:00
Ondřej Samohel
6f12bda46f
Merge pull request #4575 from ynput/enhancement/unreal-rendering_settings 2023-04-24 12:42:17 +02:00
Ondřej Samohel
20c0745bd8
Merge branch 'develop' into enhancement/unreal-rendering_settings 2023-04-24 12:40:31 +02:00
Ondřej Samohel
37cb21ab33
Merge pull request #4477 from ynput/enhancement/unreal-render_creator_improvements 2023-04-24 12:38:55 +02:00
Ondrej Samohel
7d7206953c
Merge branch 'develop' into enhancement/unreal-render_creator_improvements 2023-04-24 12:38:07 +02:00
ynbot
5c4297d888
[Automated] Merged main into develop 2023-04-22 05:26:03 +02:00
Ynbot
f4ee2a7537 [Automated] Bump version 2023-04-22 03:25:51 +00:00
ynbot
12869aeb9e
[Automated] Merged develop into main 2023-04-22 05:25:07 +02:00
Roy Nieterau
cf7e704964
Collect currentFile context data separate from workfile instance (#4883) 2023-04-21 18:43:01 +02:00
Ondřej Samohel
aa3a5134eb
Merge pull request #4878 from ynput/bugfix/OP-5761_look-publishing-texture-hash 2023-04-21 15:32:25 +02:00
Jakub Trllo
34b1ad105b
implemented collector for review instances to fix extract review issues (#4891) 2023-04-21 15:18:41 +02:00
Jakub Jezek
d03200238b
prerelease step with workflow dispatch for update bug. 2023-04-21 13:27:10 +02:00
ynbot
8b4251f01f
[Automated] Merged main into develop 2023-04-21 13:23:38 +02:00
Ynbot
edccc0f9e9 [Automated] Bump version 2023-04-21 11:23:24 +00:00
ynbot
a2b6bb6d96
[Automated] Merged develop into main 2023-04-21 13:22:33 +02:00
Jakub Jezek
d5ccdcbaab
fixing nightly workflow 2023-04-21 13:21:46 +02:00
Roy Nieterau
b751c539c3
Publisher: Make sure to reset asset widget when hidden and reshown (#4886)
* Make sure to reset asset widget when hidden and reshown

* change '_soft_reset_enabled' only on controller reset

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
2023-04-21 12:22:11 +02:00
Roy Nieterau
cac990cd3c
Code: Tweak docstrings and return type hints (#4875)
* Tweak docstrings and return type hints

* Remove test import of `typing`

* Fix indentations

* Fix indentations

* Fix typos

* Update openpype/client/entities.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

* `fields` as `Optional` iterable of strings.

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2023-04-21 12:20:10 +02:00
Kayla Man
5b1854e902
Add fps as instance.data in collect review in Houdini. (#4888)
* add fps as instance data in collect review data

* Trllo's feedback
2023-04-21 12:17:01 +02:00
Roy Nieterau
a2f79419bc
Clear publisher comment on successful publish or on window close (#4885) 2023-04-21 11:59:41 +02:00
Jakub Trllo
843fd5f1b9
Nuke: Legacy convertor skips deprecation warnings (#4846)
* convert legacy checks for AVALON_TAB to avoid deprecation warnings

* simplify 'get_avalon_knob_data'
2023-04-21 11:31:52 +02:00
Jakub Jezek
aa2d683dd9
adding test routine for the slate condition 2023-04-20 21:49:58 +02:00
Jakub Jezek
f05f7510b4
adding slate condition to plugin 2023-04-20 21:39:49 +02:00
Ondřej Samohel
452b4623ba
Merge pull request #4872 from BigRoy/enhancement/maya_hide_animation_creator 2023-04-20 16:29:56 +02:00
Ondřej Samohel
6b19c8c7e1
Merge branch 'develop' into enhancement/maya_hide_animation_creator 2023-04-20 16:28:15 +02:00
Ondřej Samohel
f18c917074
Merge pull request #4866 from BigRoy/enhancement/houdini_loaders_implement_switch 2023-04-20 16:05:27 +02:00
Ondřej Samohel
b7b9225252
Merge branch 'develop' into enhancement/houdini_loaders_implement_switch 2023-04-20 16:05:15 +02:00
Roy Nieterau
14c66af582 Merge branch 'enhancement/maya_hide_animation_creator' of https://github.com/BigRoy/OpenPype into enhancement/maya_hide_animation_creator 2023-04-20 14:12:11 +02:00
Roy Nieterau
a8abe2dda8 Fix typo 2023-04-20 14:04:40 +02:00