Commit graph

29508 commits

Author SHA1 Message Date
Roy Nieterau
22dbc4e4fa Remove unused variable NONLINEAR_FILE_FORMATS 2023-03-27 15:40:33 +02:00
Roy Nieterau
108bcd8f27 Fix missing variable declaration 2023-03-27 15:37:27 +02:00
Roy Nieterau
2cb03b75b7 Clean up imports a bit. 2023-03-27 15:35:03 +02:00
Roy Nieterau
5ed6c29eee Mimic Arnold tx manager behavior whenever maya color management is disabled
- Do no color conversion when color management is disabled
2023-03-27 15:23:14 +02:00
Roy Nieterau
bf60e73704 Remove .png from nonlinear formats assumption because apparently they can be 32-bit 2023-03-27 13:47:26 +02:00
Roy Nieterau
e11d1f279a Add assumption for some file formats to be sRGB: .png, .jpeg and .jpg 2023-03-27 13:46:33 +02:00
Roy Nieterau
6f015d6d64 Cleanup/refactor based on @fabiaserra comments 2023-03-27 13:31:33 +02:00
Roy Nieterau
3444660a98 Convert to "linear" because it's always available in OIIO if OCIO is disabled or no valid config is found
- If OCIO is not enabled (or cannot find a valid configuration, OIIO will at least be able to convert among linear, sRGB, and Rec709.)
2023-03-27 13:20:26 +02:00
Roy Nieterau
7dfaa5b4f4 Add maketx hardcoded flags to the file hash 2023-03-27 12:36:59 +02:00
Roy Nieterau
db27765637 Grammar 2023-03-27 12:31:01 +02:00
Roy Nieterau
39d6878067 Support flags without values for extra maketx arguments
- Add todo for hardcoded maketx arguments
- Add sourceHash argument at end to increase readability of the log
2023-03-27 12:30:31 +02:00
Roy Nieterau
7f4fe957bc Move get_oiio_tools_path import to top of file 2023-03-27 12:02:44 +02:00
Roy Nieterau
9773cbbedc Cleanup 2023-03-27 10:27:13 +02:00
Roy Nieterau
95fcce48bd Move REDSHIFT_COREDATAPATH environment check to get_redshift_tool 2023-03-27 10:22:33 +02:00
Roy Nieterau
35f76a2365 Fix Redshift .rstexbin support 2023-03-27 10:20:02 +02:00
Roy Nieterau
00e5f220f4 Add todo 2023-03-26 21:12:37 +02:00
Roy Nieterau
2917ee2775 Fix logging 2023-03-26 21:10:57 +02:00
Roy Nieterau
03e5ff92ea Fix typo 2023-03-26 21:07:38 +02:00
Roy Nieterau
81e25eb3a3 Move caching into one place 2023-03-26 21:06:50 +02:00
Roy Nieterau
b340f6a57c Clarify more about the issue in logging message + minor cleanup 2023-03-26 20:51:10 +02:00
Roy Nieterau
16e5bb630f Cleanup 2023-03-26 20:30:35 +02:00
Roy Nieterau
81b5d77127 Cleanup, fix Py2 compatibility 2023-03-25 20:42:34 +01:00
Roy Nieterau
0fa5eab7c9 Implement TextureResult dataclass + fix publishing with and without maketx 2023-03-25 20:29:49 +01:00
Roy Nieterau
ba1d0c570a Fix arguments 2023-03-25 15:01:03 +01:00
Roy Nieterau
d8c763c191 Include extra args in maketx texture hash 2023-03-25 14:56:15 +01:00
Roy Nieterau
e83708a3fb Cosmetics 2023-03-25 14:54:52 +01:00
Roy Nieterau
c181d3ff2e Intialize texture processors with applied settings 2023-03-25 14:54:19 +01:00
Roy Nieterau
44c0009e72 Allow to configure extra arguments in OP settings for maketx 2023-03-25 14:37:33 +01:00
Roy Nieterau
6b841253d7 Fix hash args 2023-03-25 14:26:22 +01:00
Roy Nieterau
a6a392e964 Allow maketx with color management enabled 2023-03-25 12:32:35 +01:00
Roy Nieterau
b37c15f582 More WIP refactoring for TextureProcessors 2023-03-25 10:52:44 +01:00
Roy Nieterau
5961d6dfb9 Merge remote-tracking branch 'upstream/feature/OP-2524_Maya-looks-support-for-native-Redshift-texture-format' into maya_extract_look_tx_colorspace
# Conflicts:
#	openpype/hosts/maya/plugins/publish/extract_look.py
2023-03-24 20:15:09 +01:00
Roy Nieterau
c7e12b5184 Cosmetics 2023-03-24 19:39:51 +01:00
Roy Nieterau
2baabed6be Work in progress extract look cleanup
- Fix file hashing so it includes arguments to maketx
- Fix maketx destination colorspace when OCIO is enabled
- Use pre-collected colorspaces of the resources instead of trying to retrieve again
- Fix colorspace attributes being reinterpreted by maya on export (fix remapping)
- Fix support for checking config path of maya default OCIO config (due to using `lib.get_color_management_preferences` which remaps that path)
2023-03-24 18:50:09 +01:00
Jakub Jezek
8b9a3547d9
adding project actions 2023-03-23 17:15:40 +01:00
Ondřej Samohel
f8e765eab0
Merge pull request #4600 from BigRoy/maya_look_assigner_get_all_nodes 2023-03-23 15:28:03 +01:00
Jakub Ježek
47f4e9ec2c
Merge pull request #4677 from ynput/feature/OP-4997_CelAction-Deadline-chunk-size 2023-03-23 14:54:45 +01:00
Jakub Trllo
0f6d969867
fix shortcut key sequence check (#4694) 2023-03-23 14:35:58 +01:00
Jakub Jezek
f5117f4593
celaction: fixes after testing 2023-03-23 14:28:05 +01:00
Jakub Jezek
011e635c1f
hound 2023-03-23 12:56:54 +01:00
Jakub Jezek
79eb8f105f
celaction: make parameters enumerator 2023-03-23 12:54:55 +01:00
Jakub Trllo
d0f083ec19
Publisher: Explicit save (#4676)
* added save button class

* added save button to window

* workfiles is also part of context in CreateContext to be able check if context changed

* window cares about trigger of convertors

* use abstractproperty with property and abstractmethod decorators

* save changes happens using main window and can be blocked

* fix pyside compatibility

* use create context to get current context names

* Fix docstring label

* added shortcuts for save and reset

* change control string matching for macos

* added 'publish_has_started' property

* allow save only if publishing did not start yet

* rename 'get_selected_convertors' to 'get_selected_legacy_convertors' and added docstrings

* Added Saved changes

* disable instances toggle when publishing started

* Fix reset button tooltip

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

* Use QKeySequence to string for tooltips

* added example output

* use predefined method to emit card message

---------

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
2023-03-23 12:52:25 +01:00
Ondřej Samohel
04ecb8afa1
Merge pull request #4344 from ynput/docs/add_architecture_document 2023-03-23 12:32:57 +01:00
Ondřej Samohel
25a3bb350e
Merge pull request #4685 from ynput/enhancement/increment_workfile_version_3dsmax 2023-03-23 12:06:15 +01:00
Roy Nieterau
0a085c7001
Kitsu: Slightly less strict with instance data (#4678)
* Match family and families

* Allow kitsu note to not have set comment and capture it without erroring in IntegrateKitsuReview

* Allow fallback to context for instance `task`

* Shush hound

* Refactor variable names
2023-03-23 12:06:05 +01:00
Ondřej Samohel
81b659e933
Update openpype/hosts/max/plugins/publish/increment_workfile_version.py 2023-03-23 12:06:01 +01:00
Roy Nieterau
4d53e4f5fb
Application launch context: Include app group name in logger (#4684)
* Include app group name with app name for logger

* Include app group name in launch finished log message

* Include app group name with launching message

* Use `application.full_name` instead
2023-03-23 10:27:02 +01:00
Roy Nieterau
a14b645d89
Fix class name and docstring (#4683) 2023-03-23 10:01:50 +01:00
Roy Nieterau
90f5cdf7f3
Use app.full_name (#4686) 2023-03-23 09:59:56 +01:00
Roy Nieterau
f681e9843d
Extract Review code refactor (#3930)
* Tweak variable names

* Use `filter_profiles` from lib

* Fix type fallback

* Simplify additional family filters

* Use legacy_io.Session instead of os.environ

* Fix logging message

* Indent todo comment for better todo highlighting in Pycharm

* Simplify gap filling logic

* Optimize getting nearest frames

* Fix logic for nearest frame

- This fixes cases where nearest frame isn't directly the next frame

* Refactor `index` in variable `idx` to match `missing_idx` naming

* Use `filter_profiles` from lib

* Match family filter validation of extract review

* Fix typo `overscal` -> `overscan`

* Use `legacy_io.Session` instead of `os.environ`

* Remove unused import

* use 'KnownPublishError' instead of 'AssertionError'

* modify nearest frame logic in holes fill

* Fix unsupported indexing of clique Collection + slightly simplify

---------

Co-authored-by: Jakub Trllo <jakub.trllo@gmail.com>
2023-03-23 09:50:28 +01:00