Jakub Jezek
9791fda4f6
Applied suggestions from @iLLiCiTiT
...
Ensures that any generated thumbnail files that are empty
are removed to prevent issues with subsequent processing
or storage.
2025-05-12 14:02:45 +02:00
Jakub Jezek
4ed5039732
Merge remote-tracking branch 'origin/bugfix/AY-7730_thumbnail-creation-for-single-frame-video_1249' into bugfix/AY-7730_thumbnail-creation-for-single-frame-video_1249
2025-05-12 13:57:15 +02:00
Jakub Jezek
f0be8cd877
Applied suggestions from @iLLiCiTiT
...
Simplifies the ffmpeg command construction by moving the seek position argument to the beginning of the command list if a seek position is specified, leading to a clearer and more maintainable structure. This also ensures that the output path is always the last argument passed to ffmpeg.
2025-05-12 13:57:09 +02:00
Jakub Jezek
fe3995f07d
Applied suggestions from @iLLicit
...
Simplifies the ffmpeg command construction by moving the seek position argument to the beginning of the command list if a seek position is specified, leading to a clearer and more maintainable structure. This also ensures that the output path is always the last argument passed to ffmpeg.
2025-05-12 13:56:43 +02:00
Jakub Ježek
57b808e924
Apply suggestions from code review
...
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2025-05-12 13:46:54 +02:00
Jakub Jezek
bf44622c05
Improves thumbnail extraction reliability
...
Ensures thumbnail extraction falls back to the first frame if the initial attempt fails, handling potential issues with seek position calculation or output file creation. This enhances the robustness of the thumbnail creation process.
2025-04-17 12:55:02 +02:00
Jakub Jezek
ca12d13a40
Improves thumbnail extraction reliability
...
Enhances thumbnail extraction by retrying without seeking
if the initial attempt fails.
This addresses issues where the generated thumbnail file
is either missing or empty. It also calculates the seek position
more accurately and avoid seeking for very short videos.
2025-04-17 12:50:28 +02:00
Roy Nieterau
c1d7cde34d
Merge pull request #1248 from BigRoy/chore/remove_duplicate_code_get_legacy_product_name
2025-04-17 12:07:45 +02:00
Roy Nieterau
599ed3ab04
Merge branch 'develop' into chore/remove_duplicate_code_get_legacy_product_name
2025-04-17 12:04:07 +02:00
Roy Nieterau
644765cb85
Remove redundant duplicate lines of code
2025-04-16 22:03:02 +02:00
Roy Nieterau
28c9709a65
Merge pull request #1214 from BigRoy/enhancement/allow_disabling_removal_of_rendereed_files_on_farm
2025-04-16 21:54:10 +02:00
Roy Nieterau
8d25303333
Revert defaults so removal of rendered files is disabled by default
2025-04-16 21:53:17 +02:00
Roy Nieterau
1845556612
Merge branch 'develop' into enhancement/allow_disabling_removal_of_rendereed_files_on_farm
2025-04-16 16:05:11 +02:00
Jakub Trllo
b8d1f97c2a
Merge pull request #1244 from ynput/enhancement/ruff-add-preview
...
Chore: Ruff add preview and docstring convetion
2025-04-16 12:45:38 +02:00
Jakub Trllo
fb8ee108b5
Merge branch 'develop' into enhancement/ruff-add-preview
2025-04-16 12:37:23 +02:00
Jakub Trllo
1845c0a8ef
Merge pull request #1247 from ynput/bugfix/fix-variable-usage-in-thumbnail-extractor
...
Extract Thumbnail: Fix original intnetion of thumbnail created logging
2025-04-16 10:59:01 +02:00
Jakub Trllo
4f9f7724ac
fix original intnetion of thumbnail created logging
2025-04-16 10:35:41 +02:00
Mustafa Jafar
a3d3865e78
Merge branch 'develop' into enhancement/allow_disabling_removal_of_rendereed_files_on_farm
2025-04-15 18:07:50 +02:00
Jakub Ježek
3429d5914f
Merge pull request #1242 from ynput/bugfix/AY-7717_nuke-multiple-intermediate-fails-thumbnail-in-integrator_1241
...
Fixes thumbnail creation logic
2025-04-15 16:35:13 +02:00
Jakub Ježek
602a17999d
Merge branch 'develop' into bugfix/AY-7717_nuke-multiple-intermediate-fails-thumbnail-in-integrator_1241
2025-04-15 15:50:47 +02:00
Jakub Jezek
d5f599b811
Fixes thumbnail creation logic for multiple reps
...
Resets the `repre_thumb_created` flag for each representation to ensure that thumbnails are correctly generated for all reviewable representations when multiple are present.
This prevents the logic from skipping subsequent representations after the first one successfully creates a thumbnail.
2025-04-15 14:45:36 +02:00
Jakub Trllo
dc6bb42013
define docstyle convention
2025-04-14 17:56:33 +02:00
Jakub Trllo
b0ac87b7b1
handle unused variables
2025-04-14 17:56:21 +02:00
Jakub Trllo
486be39faa
fix whitespaces
2025-04-14 17:55:48 +02:00
Jakub Trllo
b403fccf05
fix new line chars
2025-04-14 17:54:45 +02:00
Jakub Trllo
b5961dcb92
enable preview in ruff linting
2025-04-14 17:52:25 +02:00
Ynbot
400774d438
[Automated] Update version in package.py for develop
2025-04-14 14:32:11 +00:00
Ynbot
122a4a9f09
[Automated] Add generated package files from main
2025-04-14 14:31:37 +00:00
Jakub Ježek
c924c252bd
Merge pull request #1238 from ynput/bugfix/inplace-integration
...
Fixes issue with original directory lookup
2025-04-14 15:48:24 +02:00
Jakub Ježek
6f9664e41e
Merge branch 'develop' into bugfix/inplace-integration
2025-04-14 15:46:51 +02:00
Jakub Jezek
f770a35d54
Fixes thumbnail creation logic
...
Moves the `thumbnail_created` flag initialization inside the loop.
This ensures that the flag is reset for each representation, preventing it from being incorrectly skipped if a previous representation failed to create a thumbnail.
2025-04-14 15:42:12 +02:00
Ondřej Samohel
8205ee8b27
Merge pull request #1235 from ynput/chore/update-ruff-action
...
Update ruff action and take the ruff version from pyproject
2025-04-14 14:06:29 +02:00
Jakub Ježek
d12632e000
Merge branch 'develop' into bugfix/inplace-integration
2025-04-14 14:00:28 +02:00
Jakub Ježek
97bfd0459d
Update client/ayon_core/plugins/publish/integrate.py
...
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2025-04-14 14:00:18 +02:00
Jakub Ježek
46f7fa4cc1
Update client/ayon_core/plugins/publish/integrate.py
...
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2025-04-14 14:00:11 +02:00
Ondřej Samohel
39a3b7c78e
Merge branch 'develop' into chore/update-ruff-action
2025-04-14 13:50:37 +02:00
Jakub Trllo
2b8a16a960
Merge pull request #1237 from ynput/bugfix/fix-jpeg-thumbnail
...
Chore: Fix thumbnail upload
2025-04-14 12:25:04 +02:00
Jakub Trllo
ac7084dc68
Merge branch 'develop' into bugfix/fix-jpeg-thumbnail
2025-04-14 12:24:31 +02:00
Jakub Trllo
f37fe8c361
Merge pull request #1239 from ynput/bugfix/unify-output-value-type
...
Tools: Fix thumbnails output value type
2025-04-12 01:18:18 +02:00
Jakub Trllo
047b77e501
return the same output all the time
2025-04-12 01:06:29 +02:00
Ondřej Samohel
36a9151d0c
Merge branch 'develop' into chore/update-ruff-action
2025-04-11 16:35:57 +02:00
Jakub Jezek
402e98b443
Fixes issue with original directory lookup
...
Fixes a bug where the instance staging directory was being incorrectly used
when looking up the original directory for publish in place workflows,
instead of the staging directory from representation.
Adds debug logging to inspect instance data during integration.
2025-04-11 15:55:05 +02:00
Jakub Trllo
8cefce5887
Merge branch 'develop' into bugfix/fix-jpeg-thumbnail
2025-04-11 15:38:43 +02:00
Jakub Trllo
36c43c7cf3
Merge pull request #1236 from ynput/bugfix/ffmpeg-commands-update
...
Chore: Update ffmpeg commands
2025-04-11 15:38:28 +02:00
Jakub Trllo
7ec8494b1a
fix thumbnail upload
2025-04-11 15:34:11 +02:00
Jakub Trllo
3dc1eb49b1
don't use deprecated commands
2025-04-10 17:49:42 +02:00
Ondřej Samohel
63a29cd9ec
⬆️ : update ruff action and take the ruff version from pyproject
2025-04-10 14:15:20 +02:00
Ondřej Samohel
ebeb1d1e19
Merge pull request #1231 from ynput/chore/delete-poetry-lock
...
Delete poetry.lock
2025-04-09 14:43:49 +02:00
Ondřej Samohel
acf9bb56eb
🔨 add poetry.lock to .gitignore
2025-04-09 14:42:44 +02:00
Ondřej Samohel
6f1981ca96
Delete poetry.lock
...
Poetry lock shouldn't be tracked file to avoid conflics, it should be always recreated from dependencies defined in `pyproject.toml`
2025-04-09 11:54:25 +02:00
