* OP-5657 - add artist control for review in AfterEffects
Artist can disable review to be created for particular publish.
* OP-5657 - add artist control for review in AfterEffects
Removed configuration for Deadline, should be controlled by what is on instance.
* OP-5657 - handle legacy instances
Legacy instances wont't have mark_for_review in creator_attributes. Set to true as by default we always want review.
* OP-5657 - remove explicit review for all AE
Now handled directly on instance
* OP-5657 - fix - cannot remove now
Without this 'review' wont be added to tags on representation. Eventually this should be refactored.
Control on whole instance, eg. disabling review, should be enough.
* OP-5657 - fix - correct host name used
* OP-5657 - fix - correct handling of review
On local renders review should be added only from families, not from older approach through Settings.
Farm instance cannot have review in families or extract_review would get triggered even locally.
* OP-5657 - refactor - changed label
* OP-5657 - Hound
* OP-5657 - added explicitly skipping review
Instance might have set 'review' to False, which should explicitly skip review (might come from Publisher where artist can disable/enable review on an instance).
* OP-5657 - updated setting of review variable
instance.data.review == False >> explicitly set to do not create review. Keep None to let logic decide.
* OP-5657 - fix adding review flag
* OP-5657 - updated test
Removed review for second instance.
* OP-5657 - refactor to context plugin
* OP-5657 - tie thumbnail to review for local render
Produce thumbnail only when review should be created to synchronize state with farm rendering.
Move creation of thumnbail out of this plugin to general plugin to limit duplication of logic.
* Fix: Locally copied version of last published workfile is not incremented
* fix subset first match
* correct anatomy name
* Fix typo and linting
* keep source filepath for further path conformation
* fetch also input dependencies of workfile
* required changes
* lint
* fix case only one subset
* Enhancement: copy last workfile as reusable methods (#6)
* Enhancement: copy last published workfile as reusable methods (WiP)
* Added get_host_extensions method, added subset_id and las_version_doc access, added optional arguments to get_last_published_workfile
* Plugged in the new methods + minor changes
* Added docstrings, last workfile optional argument, and removed unused code
* Using new implementation to get local workfile path. Warning: It adds an extra dot to the extension which I need to fix
* Refactoring and fixed double dots
* Added match subset_id and get representation method, plus clan up
* Removed unused vars
* Fixed some rebasing errors
* delinted unchanged code and renamed get_representation into get_representation_with_task
* This time it's really delinted, I hope...
* Update openpype/modules/sync_server/sync_server.py
reprenation isn't the right spelling (:
Co-authored-by: Félix David <felixg.david@gmail.com>
* Changes based on reviews
* Fixed non imperative docstring and missing space
* Fixed another non imperative docstring
* Update openpype/modules/sync_server/sync_server.py
Fixed typo
Co-authored-by: Félix David <felixg.david@gmail.com>
Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Félix David <felixg.david@gmail.com>
* Fix: syntax error
* fix single subset case
* Restore sync server enabled test in hook
* Python2 syntax
* renaming and missing key case handling
* Fix local workfile overwritten on update in some cases (#7)
* Fix: Local workfile overwrite when local version number is higher than published workfile version number (WiP)
* Changed regex search, clean up
* Readded mistakenly removed newline
* lint
* remove anticipated functions for cleaner PR
* remove funcs from entities.py
* change to get_last_workfile_with_version
* clean
* Update openpype/modules/sync_server/sync_server.py
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* removed get_last_published_workfile_path
* moved hook to sync server module
* fix lint
* Refactor - download only if not present
* Refactor - change to list instead of set
* Refactor - removing unnecessary code
last_published_workfile_path must exists or we wouldn't get there. Use version only from that.
* Refactor - removing unnecessary imports
* Added check for max fail tries
* Refactor - cleaned up how to get last workfile
* Updated docstrings
* Remove unused imports
Co-authored-by: Félix David <felixg.david@gmail.com>
* OP-5466 - run this on more DCC
* Updated documentation
* Fix - handle hero versions
Skip hero versions, look only for versioned published to get max version id.
* Hound
* Refactor - simplified download_last_published_workfile
Logic should be in pre hook
* Skip if no profile found
* Removed unwanted import
* Use collected project_doc
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
* Use cached project_settings
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
---------
Co-authored-by: Félix David <felixg.david@gmail.com>
Co-authored-by: Sharkitty <81646000+Sharkitty@users.noreply.github.com>
Co-authored-by: Hayley GUILLOT <hayleyguillot@outlook.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
* OP-5656 - added auto creator for review in PS
Review instance should be togglable.
Review instance needs to be created for non publisher based workflows.
* OP-5656 - refactored names
* OP-5656 - refactored names
* OP-5656 - new auto creator for flat image
In old version flat image was created if no instances were created. Explicit auto creator added for clarity.
Standardization of state of plugins
* OP-5656 - updated according to auto image creator
Subset template should be used from autocreator and not be separate.
* OP-5656 - fix proper creator name
* OP-5656 - fix log message
* OP-5656 - fix use enable state
* OP-5656 - fix formatting
* OP-5656 - add review toggle to image instance
For special cases where each image should have separate review.
* OP-5656 - fix description
* OP-5656 - fix not present asset and task in instance context
* OP-5656 - refactor - both auto creators should use same class
Provided separate description.
* OP-5656 - fix - propagate review to families
Image and auto image could have now review flag.
Bottom logic is only for Webpublisher.
* OP-5656 - fix - rename review files to avaid collision
Image family produces jpg and png, jpg review would clash with name. It should be replaced by 'jpg_jpg'.
* OP-5656 - fix - limit additional auto created only on WP
In artist based publishing auto image would be created by auto creator (if enabled). Artist might want to disable image creation.
* OP-5656 - added mark_for_review flag to Publish tab
* OP-5656 - fixes for auto creator
* OP-5656 - fixe - outputDef not needed
outputDef should contain dict of output definition. In PS it doesn't make sense as it has separate extract_review without output definitions.
* OP-5656 - added persistency of changes to auto creators
Changes as enabling/disabling, changing review flag should persist.
* OP-5656 - added documentation for admins
* OP-5656 - added link to new documentation for admins
* OP-5656 - Hound
* OP-5656 - Hound
* OP-5656 - fix shared families list
* OP-5656 - added default variant for review and workfile creator
For workfile Main was default variant, "" was for review.
* OP-5656 - fix - use values from Settings
* OP-5656 - fix - use original name of review for main review family
outputName cannot be in repre or file would have ..._jpg.jpg
* OP-5656 - refactor - standardized settings
Active by default denotes if created instance is active (eg. publishable) when created.
* OP-5656 - fixes for skipping collecting auto_image
data["ids"] are necessary for extracting. Members are physical layers in image, ids are "virtual" items, won't get grouped into real image instance.
* OP-5656 - reworked auto collectors
This allows to use automatic test for proper testing.
* OP-5656 - added automatic tests
* OP-5656 - fixes for auto collectors
* OP-5656 - removed unnecessary collector
Logic moved to auto collectors.
* OP-5656 - Hound
* added helper functions to client mongo api
* pack and unpack project functions can work without project files
* added flag argument to pack project command to zip only project files
* unpack project has also only project argument
* Fix extractions
